PHPDoc: Replace non-existing return type bitmask with string
AcceptedPublic
Actions

Authored by aklapper on Thu, Jun 5, 11:47.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Summary

bitmask is not a valid type. See https://docs.phpdoc.org/guide/references/phpdoc/types.html and https://docs.phpdoc.org/guide/references/phpdoc/tags/return.html.

Test Plan

Read docs; run static code analysis.

Diff Detail

Repository

rARC Arcanist

Branch

phpdocBitmask (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 2062
Build 2062: arc lint + arc unit

Event Timeline

aklapper created this revision.Thu, Jun 5, 11:47

Owners added a reviewer: O1: Blessed Committers.Thu, Jun 5, 11:47

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptThu, Jun 5, 11:47

aklapper requested review of this revision.Thu, Jun 5, 11:47

Harbormaster completed remote builds in B2062: Diff 3159.Thu, Jun 5, 11:47

valerio.bozzolan accepted this revision.Thu, Jun 5, 17:33

This revision is now accepted and ready to land.Thu, Jun 5, 17:33

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

Packages

src/

repository/

api/

ArcanistRepositoryAPI.php

6 lines

24%

O1: Blessed Committers

Diff 3159

View Options

src/repository/api/ArcanistRepositoryAPI.php

PHPDoc: Replace non-existing return type bitmask with stringAcceptedPublicActions