Paths

Table of Contentst

Differential D26056

Mention number of search tokens for Global Search result
Needs ReviewPublic
Actions

Authored by aklapper on Tue, Jun 3, 09:27.

Details

Reviewers

None

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T16092: Explicitly mention number of search tokens for Global Search result

Summary

When using the Global Search, make it slightly clearer to users that entering i want to search for something are 6 separate search tokens and thus different from "i want to search for something" being 1 search token.

Closes T16092

Test Plan

Go to https://we.phorge.it/search/query/advanced/
In the Query field, enter bleh =zsd +a NOT(x) "phrase like this" a -phasa ~amp title:fb "use meo" érr.
Click Search button.
See string Searched For XX Terms: [...] instead of Searched For: [...].

Diff Detail

Repository

Branch

globalSearchNumberTokens (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 2048
Build 2048: arc lint + arc unit

Event Timeline

aklapper created this revision.Tue, Jun 3, 09:27

Owners added a reviewer: O1: Blessed Committers.Tue, Jun 3, 09:27

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptTue, Jun 3, 09:27

aklapper requested review of this revision.Tue, Jun 3, 09:27

Harbormaster completed remote builds in B2047: Diff 3142.Tue, Jun 3, 09:27

Don't output "1 Terms" but "x Term(s)"

Harbormaster completed remote builds in B2048: Diff 3143.Tue, Jun 3, 09:28

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

Packages

src/

applications/

search/

query/

PhabricatorSearchApplicationSearchEngine.php

4 lines

1%

Loading...

O1: Blessed Committers

Diff 3143

src/applications/search/query/PhabricatorSearchApplicationSearchEngine.php

Loading...