Page MenuHomePhorge
Differential D26039

LiskDAO::getConfiguration return typing
AcceptedPublic
Actions

Authored by amybones on Fri, May 30, 23:11.

Details

Reviewers
aklapper
Group Reviewers
O1: Blessed Committers
Summary

This clears up a common source of type check errors when using php intelephense.

Test Plan

See the squiggles in vscode go away :)

Diff Detail

Repository
rP Phorge
Branch
query_templates (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 2028
Build 2028: arc lint + arc unit

Event Timeline

amybones created this revision.Fri, May 30, 23:11
Owners added a reviewer: O1: Blessed Committers.Fri, May 30, 23:11
Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptFri, May 30, 23:11
amybones requested review of this revision.Fri, May 30, 23:11
Harbormaster completed remote builds in B2028: Diff 3119.Fri, May 30, 23:11
amybones added a parent revision: D26038: phpDoc PhabricatorApplicationQuery.Fri, May 30, 23:11
aklapper accepted this revision.Sat, May 31, 13:33
aklapper subscribed.

Nice find. Applying this patch removes about 250 errors in phpstan output here.

As neither dict nor dictionary (sigh) are listed as a complex type in https://we.phorge.it/source/arcanist/browse/master/src/parser/PhutilTypeSpec.php I cannot imagine side effects (well it's "only" PHPDocs anyway).
(We should probably kill all those dict and dictionary PHPDoc items and for the start mass-replace them with array?)

This revision is now accepted and ready to land.Sat, May 31, 13:33

Revision Contents
Changeset List

PathSizePackages
src/
infrastructure/
storage/
lisk/
2 linesO1: Blessed Committers

Diff 3119

View Options

src/infrastructure/storage/lisk/LiskDAO.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0