Add the newlline

this unfortunately caused T15963: LDAP over TLS is broken :/

(I still need to understand the old intentions on the old regex, and the new one, but it seems much magically readable, thanks)

Double slam accept

Simplify return of validateRealName() as proposed by Valerio

BTW I think the page is reached by a crawler that is visiting a branch root on a specific commit:

Wow. Assuming the line is the one with phutil_nonempty_string($branch), why branch "main" is considered a number?

sgtm. Thanks :) just that comment

Thanks for catching that! Amend in new PhutilNumber()

Finally got a reproducer URI in downstream:

• Broken: https://phabricator.wikimedia.org/diffusion/OSWB/branches/main/.gitignore;5a588bf0ee10546ddb9d0872d1be1bf48b3f3c07 (branches in URI).
• Works: https://phabricator.wikimedia.org/diffusion/OSWB/browse/main/.gitignore;5a588bf0ee10546ddb9d0872d1be1bf48b3f3c07 (browse in URI).

In D25696#22447, @valerio.bozzolan wrote:

Maybe relevant but PhabricatorObjectHandleData seems to do some magic

Yes maniphest.edit is the modern way to do it.

Maybe relevant but PhabricatorObjectHandleData seems to do some magic about filling PhabricatorObjectHandle with stuff like the name.

Thanks for the comment

Works on my machine!

Thanks :)

Also update the PhpDoc accordingly

Ignore PHP 8.3.0's new DateMalformedStringException and stick to generic Exception in all cases instead

@taavi: Uhm, thanks! If you have a chance to test D25839 that would be great. :)

Handle whitespace-only task and project titles correctly

This needs rework as the logic currently does not properly handle entering a title consisting of whitespace only. (Outcome gets unpleasant afterwards.)

It might be slightly safer to use PhutilURI, but this is in any case a potentially-unsafe configuration.

https://devina.io/redos-checker says the new regex is still prone to polynomial backtracking, but that can happen only on extremely contrived input, whereas the old one was exponential on a common case.

Fix lint

Digging deeper, the problem is specific to ProjectRemarkupRule::getObjectIDPattern. That returns:

Step 2: Remove irrelevant character class exclusions:

Disentangling that monster regex, step 1:

Indeed https://devina.io/redos-checker says the aformentioned regex is exponential time worst-case

I monkeypatched the code to print preg_last_error when the problematic preg_match returns null. The error is "Backtrack limit exhausted".

Thanks :)

This should be resolved by now in git master

Ah, the mythical Platypus Ornithopter!