seems good
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Jun 22 2024
Jun 22 2024
speck accepted D25518: Allow setting default value for SearchFields; set Maniphest Page Size to 100.
I take it the api used by Phorge hasn’t updated or changed in the update?
I didn’t find changes in our fork regarding this. We should either change these parameters to be optional in their definition or throw exceptions when they aren’t specified. Changing them to be optional seems the better behavior.
speck added inline comments to D25648: Fix call to non-existing newEmptyValue() in PhabricatorDashboardPortalProfileMenuEngine.
speck accepted D25690: Fix "Undefined offset: 1" exception in Diviner when @task value in PHPDoc is a single word.
Not having a title seems j like a bug elsewhere
Jun 21 2024
Jun 21 2024
Add fallback languages for locale files
mturdus committed rP1f5c54c35a1a: Conduit API: allow phriction.edit to modify viewPolicy and editPolicy.
Conduit API: allow phriction.edit to modify viewPolicy and editPolicy
aklapper updated the test plan for D25648: Fix call to non-existing newEmptyValue() in PhabricatorDashboardPortalProfileMenuEngine.
valerio.bozzolan updated the summary of D25691: Fix arc diff in Subversion for non-English languages.
aklapper added inline comments to D25690: Fix "Undefined offset: 1" exception in Diviner when @task value in PHPDoc is a single word.
valerio.bozzolan updated the task description for T15855: Fix "arc diff" in Subversion for non-English languages.
In D25691#19103, @aklapper wrote:Any chance to share the related stacktrace?
I realize how little I remember SVN to set up testing, sigh... Any chance to share the related stacktrace?
aklapper retitled D25619: Fix overflowing of AphrontSideNavFilterView on small screens and tidy up nav bar styles from Fixes overflowing of AphrontSideNavFilterView on small screens and tidies up nav bar styles
Per my last comment
Add Standard Custom Fields to Item List
avivey renamed Blog Post: 2024 "Not Officially Summer" release blog post from 2024 "Not officially summer" release to 2024 "Not Officially Summer" release.
Promote 2024.19 to stable
Promote 2024.19 to stable
valerio.bozzolan added a comment to D25694: Set "preconnect" HTTP header when "security.alternate-file-domain" is set.
In D25694#19020, @avivey wrote:What if $cdn has some evil characters? Do we have some escaping
Jun 20 2024
Jun 20 2024
valerio.bozzolan added inline comments to D25051: Destroy file attachments when file is deleted, or object is deleted.
valerio.bozzolan added inline comments to D25051: Destroy file attachments when file is deleted, or object is deleted.
valerio.bozzolan updated the diff for D25051: Destroy file attachments when file is deleted, or object is deleted.
git rebase master
speck added inline comments to D25051: Destroy file attachments when file is deleted, or object is deleted.
valerio.bozzolan updated the name of F2236006: Phorge error Unknown objects.png from "image.png" to "Phorge error Unknown objects.png".
pppery added a comment to T15862: Some messages that support PLURAL are not detected as such by the i18n string extractor.
From an attempt I made to fix this before running out of motivation (this lists all parameters that vary on number in the US English translation but the i18n extractor thinks they don't)
WARNING /applications/calendar/notifications/PhabricatorCalendarNotificationEngine.php:269: missing PhutilNumber call? WARNING /applications/config/check/PhabricatorExtraConfigSetupCheck.php:72: missing PhutilNumber call? WARNING /applications/config/view/PhabricatorSetupIssueView.php:58: missing PhutilNumber call? WARNING /applications/config/view/PhabricatorSetupIssueView.php:73: missing PhutilNumber call? WARNING /applications/config/view/PhabricatorSetupIssueView.php:316: missing PhutilNumber call? WARNING /applications/config/view/PhabricatorSetupIssueView.php:321: missing PhutilNumber call? WARNING /applications/config/view/PhabricatorSetupIssueView.php:347: missing PhutilNumber call? WARNING /applications/config/view/PhabricatorSetupIssueView.php:390: missing PhutilNumber call? WARNING /applications/config/view/PhabricatorSetupIssueView.php:397: missing PhutilNumber call? WARNING /applications/config/view/PhabricatorSetupIssueView.php:524: missing PhutilNumber call? WARNING /applications/config/view/PhabricatorSetupIssueView.php:578: missing PhutilNumber call? WARNING /applications/conpherence/xaction/ConpherenceThreadParticipantsTransaction.php:74: missing PhutilNumber call? WARNING /applications/conpherence/xaction/ConpherenceThreadParticipantsTransaction.php:80: missing PhutilNumber call? WARNING /applications/differential/edge/DifferentialRevisionDependedOnByRevisionEdgeType.php:36: missing PhutilNumber call? WARNING /applications/differential/edge/DifferentialRevisionDependedOnByRevisionEdgeType.php:48: missing PhutilNumber call? WARNING /applications/differential/edge/DifferentialRevisionDependedOnByRevisionEdgeType.php:78: missing PhutilNumber call? WARNING /applications/differential/edge/DifferentialRevisionDependedOnByRevisionEdgeType.php:92: missing PhutilNumber call? WARNING /applications/differential/edge/DifferentialRevisionDependsOnRevisionEdgeType.php:39: missing PhutilNumber call? WARNING /applications/differential/edge/DifferentialRevisionDependsOnRevisionEdgeType.php:51: missing PhutilNumber call? WARNING /applications/differential/edge/DifferentialRevisionDependsOnRevisionEdgeType.php:81: missing PhutilNumber call? WARNING /applications/differential/edge/DifferentialRevisionDependsOnRevisionEdgeType.php:95: missing PhutilNumber call? WARNING /applications/differential/edge/DifferentialRevisionHasCommitEdgeType.php:34: missing PhutilNumber call? WARNING /applications/differential/edge/DifferentialRevisionHasCommitEdgeType.php:46: missing PhutilNumber call? WARNING /applications/differential/edge/DifferentialRevisionHasReviewerEdgeType.php:18: missing PhutilNumber call? WARNING /applications/differential/edge/DifferentialRevisionHasReviewerEdgeType.php:30: missing PhutilNumber call? WARNING /applications/differential/edge/DifferentialRevisionHasReviewerEdgeType.php:61: missing PhutilNumber call? WARNING /applications/differential/edge/DifferentialRevisionHasReviewerEdgeType.php:75: missing PhutilNumber call? WARNING /applications/differential/edge/DifferentialRevisionHasTaskEdgeType.php:33: missing PhutilNumber call? WARNING /applications/differential/edge/DifferentialRevisionHasTaskEdgeType.php:45: missing PhutilNumber call? WARNING /applications/differential/edge/DifferentialRevisionHasTaskEdgeType.php:76: missing PhutilNumber call? WARNING /applications/differential/edge/DifferentialRevisionHasTaskEdgeType.php:90: missing PhutilNumber call? WARNING /applications/differential/mail/DifferentialCreateMailReceiver.php:75: missing PhutilNumber call? WARNING /applications/differential/render/DifferentialChangesetHTMLRenderer.php:523: missing PhutilNumber call? WARNING /applications/differential/render/DifferentialChangesetHTMLRenderer.php:525: missing PhutilNumber call? WARNING /applications/differential/render/DifferentialChangesetHTMLRenderer.php:529: missing PhutilNumber call? WARNING /applications/differential/render/DifferentialChangesetHTMLRenderer.php:531: missing PhutilNumber call? WARNING /applications/differential/render/DifferentialChangesetHTMLRenderer.php:556: missing PhutilNumber call? WARNING /applications/differential/render/DifferentialChangesetHTMLRenderer.php:558: missing PhutilNumber call? WARNING /applications/differential/render/DifferentialChangesetHTMLRenderer.php:562: missing PhutilNumber call? WARNING /applications/differential/render/DifferentialChangesetHTMLRenderer.php:564: missing PhutilNumber call? WARNING /applications/differential/storage/DifferentialTransaction.php:593: missing PhutilNumber call? WARNING /applications/differential/storage/DifferentialTransaction.php:597: missing PhutilNumber call? WARNING /applications/diffusion/edge/DiffusionCommitHasRevisionEdgeType.php:34: missing PhutilNumber call? WARNING /applications/diffusion/edge/DiffusionCommitHasRevisionEdgeType.php:46: missing PhutilNumber call? WARNING /applications/diffusion/edge/DiffusionCommitHasTaskEdgeType.php:33: missing PhutilNumber call? WARNING /applications/diffusion/edge/DiffusionCommitHasTaskEdgeType.php:45: missing PhutilNumber call? WARNING /applications/diffusion/edge/DiffusionCommitHasTaskEdgeType.php:76: missing PhutilNumber call? WARNING /applications/diffusion/edge/DiffusionCommitHasTaskEdgeType.php:90: missing PhutilNumber call? WARNING /applications/diffusion/edge/DiffusionCommitRevertedByCommitEdgeType.php:22: missing PhutilNumber call? WARNING /applications/diffusion/edge/DiffusionCommitRevertedByCommitEdgeType.php:34: missing PhutilNumber call? WARNING /applications/diffusion/edge/DiffusionCommitRevertedByCommitEdgeType.php:64: missing PhutilNumber call? WARNING /applications/diffusion/edge/DiffusionCommitRevertedByCommitEdgeType.php:78: missing PhutilNumber call? WARNING /applications/diffusion/edge/DiffusionCommitRevertsCommitEdgeType.php:25: missing PhutilNumber call? WARNING /applications/diffusion/edge/DiffusionCommitRevertsCommitEdgeType.php:37: missing PhutilNumber call? WARNING /applications/diffusion/edge/DiffusionCommitRevertsCommitEdgeType.php:67: missing PhutilNumber call? WARNING /applications/diffusion/edge/DiffusionCommitRevertsCommitEdgeType.php:81: missing PhutilNumber call? WARNING /applications/legalpad/edge/LegalpadObjectNeedsSignatureEdgeType.php:17: missing PhutilNumber call? WARNING /applications/maniphest/edge/ManiphestTaskDependedOnByTaskEdgeType.php:32: missing PhutilNumber call? WARNING /applications/maniphest/edge/ManiphestTaskDependedOnByTaskEdgeType.php:44: missing PhutilNumber call? WARNING /applications/maniphest/edge/ManiphestTaskDependedOnByTaskEdgeType.php:74: missing PhutilNumber call? WARNING /applications/maniphest/edge/ManiphestTaskDependedOnByTaskEdgeType.php:88: missing PhutilNumber call? WARNING /applications/maniphest/edge/ManiphestTaskDependsOnTaskEdgeType.php:37: missing PhutilNumber call? WARNING /applications/maniphest/edge/ManiphestTaskDependsOnTaskEdgeType.php:49: missing PhutilNumber call? WARNING /applications/maniphest/edge/ManiphestTaskDependsOnTaskEdgeType.php:79: missing PhutilNumber call? WARNING /applications/maniphest/edge/ManiphestTaskDependsOnTaskEdgeType.php:93: missing PhutilNumber call? WARNING /applications/maniphest/edge/ManiphestTaskHasCommitEdgeType.php:33: missing PhutilNumber call? WARNING /applications/maniphest/edge/ManiphestTaskHasCommitEdgeType.php:45: missing PhutilNumber call? WARNING /applications/maniphest/edge/ManiphestTaskHasCommitEdgeType.php:76: missing PhutilNumber call? WARNING /applications/maniphest/edge/ManiphestTaskHasCommitEdgeType.php:90: missing PhutilNumber call? WARNING /applications/maniphest/edge/ManiphestTaskHasMockEdgeType.php:21: missing PhutilNumber call? WARNING /applications/maniphest/edge/ManiphestTaskHasMockEdgeType.php:33: missing PhutilNumber call? WARNING /applications/maniphest/edge/ManiphestTaskHasRevisionEdgeType.php:33: missing PhutilNumber call? WARNING /applications/maniphest/edge/ManiphestTaskHasRevisionEdgeType.php:45: missing PhutilNumber call? WARNING /applications/maniphest/edge/ManiphestTaskHasRevisionEdgeType.php:76: missing PhutilNumber call? WARNING /applications/maniphest/edge/ManiphestTaskHasRevisionEdgeType.php:90: missing PhutilNumber call? WARNING /applications/owners/xaction/PhabricatorOwnersPackageOwnersTransaction.php:54: missing PhutilNumber call? WARNING /applications/owners/xaction/PhabricatorOwnersPackageOwnersTransaction.php:60: missing PhutilNumber call? WARNING /applications/pholio/edge/PholioMockHasTaskEdgeType.php:21: missing PhutilNumber call? WARNING /applications/pholio/edge/PholioMockHasTaskEdgeType.php:33: missing PhutilNumber call? WARNING /applications/pholio/xaction/PholioImageFileTransaction.php:61: missing PhutilNumber call? WARNING /applications/pholio/xaction/PholioImageFileTransaction.php:67: missing PhutilNumber call? WARNING /applications/phortune/controller/account/PhortuneAccountOverviewController.php:116: missing PhutilNumber call? WARNING /applications/phortune/edge/PhortuneAccountHasMemberEdgeType.php:17: missing PhutilNumber call? WARNING /applications/phortune/edge/PhortuneAccountHasMemberEdgeType.php:29: missing PhutilNumber call? WARNING /applications/phortune/edge/PhortuneMerchantHasMemberEdgeType.php:17: missing PhutilNumber call? WARNING /applications/phortune/edge/PhortuneMerchantHasMemberEdgeType.php:29: missing PhutilNumber call? WARNING /applications/project/edge/PhabricatorProjectMemberOfProjectEdgeType.php:22: missing PhutilNumber call? WARNING /applications/project/edge/PhabricatorProjectMemberOfProjectEdgeType.php:34: missing PhutilNumber call? WARNING /applications/project/edge/PhabricatorProjectObjectHasProjectEdgeType.php:24: missing PhutilNumber call? WARNING /applications/project/edge/PhabricatorProjectObjectHasProjectEdgeType.php:36: missing PhutilNumber call? WARNING /applications/project/edge/PhabricatorProjectObjectHasProjectEdgeType.php:67: missing PhutilNumber call? WARNING /applications/project/edge/PhabricatorProjectObjectHasProjectEdgeType.php:81: missing PhutilNumber call? WARNING /applications/project/edge/PhabricatorProjectProjectHasMemberEdgeType.php:22: missing PhutilNumber call? WARNING /applications/project/edge/PhabricatorProjectProjectHasMemberEdgeType.php:34: missing PhutilNumber call? WARNING /applications/project/edge/PhabricatorProjectProjectHasMemberEdgeType.php:64: missing PhutilNumber call? WARNING /applications/project/edge/PhabricatorProjectProjectHasMemberEdgeType.php:78: missing PhutilNumber call? WARNING /applications/project/storage/PhabricatorProjectTransaction.php:108: missing PhutilNumber call? WARNING /applications/project/storage/PhabricatorProjectTransaction.php:120: missing PhutilNumber call? WARNING /applications/project/xaction/PhabricatorProjectSlugsTransaction.php:56: missing PhutilNumber call? WARNING /applications/project/xaction/PhabricatorProjectSlugsTransaction.php:62: missing PhutilNumber call? WARNING /applications/project/xaction/PhabricatorProjectSlugsTransaction.php:90: missing PhutilNumber call? WARNING /applications/project/xaction/PhabricatorProjectSlugsTransaction.php:97: missing PhutilNumber call? WARNING /applications/repository/worker/PhabricatorRepositoryPushMailWorker.php:77: missing PhutilNumber call? WARNING /applications/repository/worker/PhabricatorRepositoryPushMailWorker.php:108: missing PhutilNumber call? WARNING /applications/subscriptions/engineextension/PhabricatorSubscriptionsCurtainExtension.php:98: missing PhutilNumber call? WARNING /applications/subscriptions/view/SubscriptionListStringBuilder.php:67: missing PhutilNumber call? WARNING /applications/transactions/edges/PhabricatorObjectHasContributorEdgeType.php:22: missing PhutilNumber call? WARNING /applications/transactions/edges/PhabricatorObjectHasContributorEdgeType.php:34: missing PhutilNumber call? WARNING /applications/transactions/edges/PhabricatorObjectHasWatcherEdgeType.php:21: missing PhutilNumber call? WARNING /applications/transactions/edges/PhabricatorObjectHasWatcherEdgeType.php:33: missing PhutilNumber call? WARNING /applications/transactions/edges/PhabricatorObjectHasWatcherEdgeType.php:63: missing PhutilNumber call? WARNING /applications/transactions/edges/PhabricatorObjectHasWatcherEdgeType.php:77: missing PhutilNumber call? WARNING /applications/transactions/response/PhabricatorApplicationTransactionNoEffectResponse.php:38: missing PhutilNumber call? WARNING /applications/transactions/response/PhabricatorApplicationTransactionNoEffectResponse.php:39: missing PhutilNumber call? WARNING /applications/transactions/response/PhabricatorApplicationTransactionNoEffectResponse.php:44: missing PhutilNumber call? WARNING /applications/transactions/response/PhabricatorApplicationTransactionNoEffectResponse.php:55: missing PhutilNumber call? WARNING /applications/transactions/response/PhabricatorApplicationTransactionNoEffectResponse.php:56: missing PhutilNumber call? WARNING /applications/transactions/storage/PhabricatorApplicationTransaction.php:1042: missing PhutilNumber call? WARNING /applications/transactions/storage/PhabricatorApplicationTransaction.php:1053: missing PhutilNumber call? WARNING /infrastructure/diff/view/PHUIDiffTableOfContentsItemView.php:140: missing PhutilNumber call? WARNING /infrastructure/edges/type/PhabricatorEdgeType.php:66: missing PhutilNumber call? WARNING /infrastructure/edges/type/PhabricatorEdgeType.php:78: missing PhutilNumber call? WARNING /infrastructure/edges/type/PhabricatorEdgeType.php:109: missing PhutilNumber call? WARNING /infrastructure/edges/type/PhabricatorEdgeType.php:123: missing PhutilNumber call?
Not all of these should be fixed in the obvious way, or even can be.
Fix a typo
Done that. I left the technically-redundant methods where I have a lengthy comment explaining why I return en_US, since I think it's helpful to explain why that is.
Don't make unnecessary whitespace changes
Set fallback locale in base class
The current behavior if a fallback locale is not specified is to fallback to the proto-English string (English without applying pluralization). It probably does make sense, now that you bring it up, to fall back to en_US instead by default instead of doing that in every locale.
What's the current behavior for fallback from cs_CZ? Would it make sense to set the default to en_US in the base class?
Jun 19 2024
Jun 19 2024
Ce a comment
aklapper planned changes to D25696: Avoid "Unknown Object (????)" for custom Select field values in Herald editor.
This is not a full fix, still it is an improvement (and a base if anyone feels like fixing this perfectly).
Fix lint
aklapper abandoned D25635: Fix PHP 8.1 "preg_replace(null)" exception in PhabricatorEditorURIEngine.php.
revi confirmed this is called by getRepositorySlug() so abandoning this patch as hiding the underlying issue (no repository slug defined?) is not the right approach
• l2dy added inline comments to D25694: Set "preconnect" HTTP header when "security.alternate-file-domain" is set.
$ git show commit d519f75dfdee61bb109468aa708c47f53f3e5128 (HEAD -> stable, origin/stable) Author: Mark Jervelund <EMAIL-REDACTED> Date: Mon Feb 12 11:51:24 2024 +0100
In D25636#17849, @valerio.bozzolan wrote:Nice catch. Basically the question is, why is this not working?
@revi: Could you please double-check and confirm that the line 144 in <phorge>/src/infrastructure/editor/PhabricatorEditorURIEngine.php is
'n' => $this->escapeToken($repository->getRepositorySlug()),
in your installation? Thanks in advance!
aklapper added inline comments to D25694: Set "preconnect" HTTP header when "security.alternate-file-domain" is set.
aklapper added a comment to D25694: Set "preconnect" HTTP header when "security.alternate-file-domain" is set.
can it cause anything bad
avivey added a comment to D25694: Set "preconnect" HTTP header when "security.alternate-file-domain" is set.
What if $cdn has some evil characters? Do we have some escaping, or can it cause anything bad, or do we not care? Looks like we're including a bunch of other config as-is here, so maybe it's ok.
Looks good to me.
aklapper added inline comments to D25694: Set "preconnect" HTTP header when "security.alternate-file-domain" is set.
speck added inline comments to D25694: Set "preconnect" HTTP header when "security.alternate-file-domain" is set.
Jun 18 2024
Jun 18 2024
aklapper committed rP5d479556c329: Display same items in mobile menu on User Profile page as on desktop.
Display same items in mobile menu on User Profile page as on desktop
valerio.bozzolan triaged T15859: Set "preconnect" HTTP header when "security.alternate-file-domain" is set as Wishlist priority.
aklapper added a comment to D25694: Set "preconnect" HTTP header when "security.alternate-file-domain" is set.
Good point, thanks! Updated.
aklapper updated the summary of D25694: Set "preconnect" HTTP header when "security.alternate-file-domain" is set.
• l2dy added a comment to D25694: Set "preconnect" HTTP header when "security.alternate-file-domain" is set.
Should the summary also include https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/rel/preconnect as a reference? https://developer.mozilla.org/en-US/docs/Web/Performance/dns-prefetch doesn't mention preconnect in the first few paragraphs, so it's somewhat confusing.
Also remove now unused private $objectPHID
Remove a needless ->setObjectPHID($object_phid) call I missed now that we pass $object
I still don't like the solution of using place-holder text for that
Thanks for the review (and for your patience!).
Jun 16 2024
Jun 16 2024
avivey updated the question details for Q139: Add remarkup syntax help for custom remarkup rule tokens.
mturdus updated the task description for T15858: Conduit API: allow phriction.edit to modify viewPolicy and editPolicy.
mturdus updated the diff for D25693: Conduit API: allow phriction.edit to modify viewPolicy and editPolicy.
Updating D25693: Conduit API: allow phriction.edit to modify viewPolicy and editPolicy
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0