Just for my curiosity, what lovely package are you crafting? APT? snap? Thanks :)

I accept but please wait at least one day before landing :) Thanks for your code contribution!

I'm inclined to accept this, premising that usually we adopt PlatformSymbols::getPlatformServerPath() but in this case that will not work since this error is very low-level about the load of Arcanist itself.

Thanks but I don't know where that typo is, so, feel free to fix

Triaging to "Unbreak Now!" so to be kindly shown in the homepage :)

I don't remember but that was an attempt to do not release Passphrase credentials as CC BY-SA 4.0 :D :D

Updated to reflect some tips from comments. Also added some "Pro / Cons"

git rebase master

There is a thing, to be honest. We are trimming the $above just in the test, but then we are not using the trimmed string in the rendering. So, the $v = coalesce($v, '') thing, and always trim() later, may still be better.

Maybe other people would like to propose a coalesce() and always trim() that and just have the if(phutil_nonempty...($)), but to be honest this is just correct and somehow minimal.

I tried browsing that page without being able to trigger the issue

Yeah feel free to review D25301

(I have not tried this patch but I checked with ls -la the mess in my .cache to understand best practices from other software)

• we have an approval from a core contributor
• we tested by at lest 2 persons in real-world
• we tested also in my production for 7 months, using this intensively, without any nuclear implosion
• nobody cares, really, nobody uses Milestones, nobody knows what a Milestone is, people also don't like Workboards, Workboards are evil persons for much core contributors, so we will never receive more feedback here automagically, if we have not received these in 7 months
• since this change is online since the 11st of February (!) :D and since I waited 2 weeks to be kind after approval, ...

I'm generally scared by strlen() things since it means it was probably relying on implicit cast-to-string.

I'm trying to imagine a title that also involves the UX in general about accepting revisions, since it's also about the "Accept Revision" button, but my brain is not helping me right now in this

I was trying to test this, but I don't know how to do a Subversion commit without a committer name 🤔

Decreasing just a bit the priority since we are a bit confused about how to proceed but feel free to change

It could also be some bots sending you fuzzy input. Consider to mark as invalid, until a real human being elevates this as a problem affecting some workflows.

Note that the upstream solution from Phabricator does not fix your problem, since

Are you aware of any non-git repository in Wikimedia?

Kindly marking as "request changes" only to indicate "waiting for author feedback"

I'm talking about Herald Webhook, not Herald Rule. So you can write some web code that is visited when something happens, so you can run custom code when that happens, and you can edit your Tasks.

I tried to test this but I have not a real JIRA account and I was not able to test a non-null value. But, I inspected all the definitions of that method and it seems it only returns pht() so I would assume that it only returns strings.

I think this is apparently unrelated to projects. It's just needed to edit something else, keeping the date field as empty.

Tested. Thanks!

What do you think about the related tip? Also here I can maybe try to propose a counter-patch next week

What do you think about? Maybe I can try to propose a counter-patch about the related tip

Yeah why not, thanks

comments more sexier for reviewers

The AphrontRequest::getStr() method is known to return null or a string and any other value will cause a nuclear implosion from phutil_nonempty_string() and we like that

Nice! Just few inline tips

While it could be nice to have this, in the meanwhile I think that having something minimal like D25434 would be nice

Just a question. Why under differential and not related to Remarkup?

Nice catch

Content is not in something, rather it's licensed under.

Thanks @aklapper, feel free to edit the Task description according to your proposal.

Nice catch. I agree that we should allow to have texts like asd {{{ lol }}} whey without any nuclear implosion needed by design just because we are trying to give support to cowsay or figlet.

• rollback CSS change

Better now?

• integrate tips from reviewers

Just to inform that maybe a sub-task bug report will be created soon. Related discussion: https://phabricator.wikimedia.org/T333885#9132176