Page MenuHomePhorge
Differential D25445

Update path in startup error
ClosedPublic
Actions

Authored by fgaz on Oct 3 2023, 12:51.

Details

Reviewers
valerio.bozzolan
Group Reviewers
O1: Blessed Committers
Commits
rP71b273a62281: Update path in startup error
Summary

The error mentioned a "phabricator" directory, but according to the docs it has been migrated to "phorge".

Test Plan

Move the "arcanist" directory somewhere else, run something from phorge/bin/.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

fgaz created this revision.Oct 3 2023, 12:51
Owners added a reviewer: O1: Blessed Committers.Oct 3 2023, 12:51
Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptOct 3 2023, 12:51
fgaz requested review of this revision.Oct 3 2023, 12:51
Harbormaster completed remote builds in B858: Diff 1406.Oct 3 2023, 12:51
valerio.bozzolan added a comment.Oct 3 2023, 12:54

Thanks!

I'm inclined to accept this, premising that usually we adopt PlatformSymbols::getPlatformServerPath() but in this case that will not work since this error is very low-level about the load of Arcanist itself.

Let's wait for more eyes on this :)

valerio.bozzolan accepted this revision.Oct 3 2023, 12:55

I accept but please wait at least one day before landing :) Thanks for your code contribution!

This revision is now accepted and ready to land.Oct 3 2023, 12:55
Closed by commit rP71b273a62281: Update path in startup error. · Explain WhyOct 5 2023, 08:36
This revision was automatically updated to reflect the committed changes.
fgaz added a commit: rP71b273a62281: Update path in startup error.

Revision Contents
Changeset List

PathSizePackages
support/
startup/
2 linesO1: Blessed Committers

Diff 1407

View Options

support/startup/PhabricatorStartup.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0