Hello boz,
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Sep 17 2024
Sep 16 2024
Slam-accept
Dear arp, please clone and hack a lot on Phorge :) Thanks and feel free to share any question
What's the status of this one? Just curious if we should fork and hack around it ourselves for now or if it's coming soon.
Don't create an empty title array when there is no $query_text
Uhhh you found the place where the empty array comes from! <3 I failed!
Taking the best from the two: what about assuming a default @link /book/group/best-document-ever-about-link - but still allowing custom @link to allow easy migrations?
After looking again here:
Initialize key as an empty string as proposed by speck
What Valerio says: As $body can be null, make sure that the rest of this function's code deals with an empty string and not with null
Works locally; this makes sense to me (though I'm surprised it's in an Audit related source file).
Rebase; improve PhpDoc
Sep 14 2024
I hope that something is better than nothing I think. Then we can move if we don't like it.
Sep 11 2024
Sep 10 2024
If Harbormaster is fine I better be fine too, dont want no problems with them for reals
Those were just for the looks, but this is of course personal.
I can remove them if you want.
even simpler
Ah! yes - undo ConpherenceViewController
(I don't get the comment about D25784) thanks for feedback
I guess D25784 shouldn't be mashed up in here thus requesting changes.
Uh!
I fail to reproduce a problem locally (after commenting out entire ArcanistBundleTestCase::testGitRepository due to a different issue I'm running into locally).
In D25807#21516, @valerio.bozzolan wrote:P.S. try applying D25809 to check if the red unit test becomes green
@mturdus: Thanks for the patch! I tested this locally on a wiki page with a bunch of sections and on http://phorge.localhost/book/phorge/article/remarkup/ ; and on Differential's /D1 where it does not affect the ToC panel (good).
Sep 9 2024
fix typo
Deprecated. See wojak_depressed macro instead - https://we.phorge.it/macro/view/14/
LOL don't take this too seriously but sometime this cursed thing makes sense
Sep 8 2024
From the text body:IMPORTANT: Share that patch to your DBA <snip>
Sep 7 2024
Moah fixees
Nice catch, thanks! Sorry for this regression in unit tests
Sep 6 2024
Does appear fixed in latest master!