Page MenuHomePhorge
Feed All Stories

Sep 17 2024

tiantiandas closed Q149: [BUG] Conduit API call error: Call to phutil_nonempty_string() expected null or a string, got: float. as obsolete.
Sep 17 2024, 00:17 · Bug Reports, Phorge
tiantiandas added a comment to Q149: [BUG] Conduit API call error: Call to phutil_nonempty_string() expected null or a string, got: float. (Answer 186).

Hello boz,

Sep 17 2024, 00:16

Sep 16 2024

valerio.bozzolan accepted D25769: Fix PHP 8.1 "str_replace(null)" exception in DivinerAtomRef.

Slam-accept

Sep 16 2024, 20:38
valerio.bozzolan added a comment to T15908: More Useful "Quick Create" button on Workboard Columns.

Dear arp, please clone and hack a lot on Phorge :) Thanks and feel free to share any question

Sep 16 2024, 18:57 · Feature Requests, Workboard
arp added a comment to T15908: More Useful "Quick Create" button on Workboard Columns.

What's the status of this one? Just curious if we should fork and hack around it ourselves for now or if it's coming soon.

Sep 16 2024, 18:27 · Feature Requests, Workboard
aklapper edited the content of Next Up.
Sep 16 2024, 17:00
aklapper updated the summary of D25769: Fix PHP 8.1 "str_replace(null)" exception in DivinerAtomRef.
Sep 16 2024, 16:59
aklapper updated the summary of D25769: Fix PHP 8.1 "str_replace(null)" exception in DivinerAtomRef.
Sep 16 2024, 16:59
aklapper updated the diff for D25769: Fix PHP 8.1 "str_replace(null)" exception in DivinerAtomRef.

Don't create an empty title array when there is no $query_text

Sep 16 2024, 16:56
aklapper added a comment to D25769: Fix PHP 8.1 "str_replace(null)" exception in DivinerAtomRef.

Uhhh you found the place where the empty array comes from! <3 I failed!

Sep 16 2024, 16:55
aklapper closed T15929: PHP 8.1 "strlen(null)" exception in PhutilOAuth1Future.php, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Sep 16 2024, 16:27 · PHP 8 support
aklapper closed T15929: PHP 8.1 "strlen(null)" exception in PhutilOAuth1Future.php as Resolved by committing rARC0358ff7ee314: Fix PHP 8.1 "strlen(null)" exception in PhutilOAuth1Future.
Sep 16 2024, 16:27 · PHP 8 support
aklapper closed D25811: Fix PHP 8.1 "strlen(null)" exception in PhutilOAuth1Future.
Sep 16 2024, 16:27
aklapper committed rARC0358ff7ee314: Fix PHP 8.1 "strlen(null)" exception in PhutilOAuth1Future.
Fix PHP 8.1 "strlen(null)" exception in PhutilOAuth1Future
Sep 16 2024, 16:27
aklapper edited the content of Next Up.
Sep 16 2024, 16:26
aklapper closed T15930: PHP 8.1 "strlen(null)" exception in HTTPFutureHTTPResponseStatus, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Sep 16 2024, 16:26 · PHP 8 support
aklapper closed T15930: PHP 8.1 "strlen(null)" exception in HTTPFutureHTTPResponseStatus as Resolved by committing rARCead6759082d2: Fix PHP 8.1 "strlen(null)" exception in HTTPFutureHTTPResponseStatus.
Sep 16 2024, 16:26 · PHP 8 support
aklapper closed D25810: Fix PHP 8.1 "strlen(null)" exception in HTTPFutureHTTPResponseStatus.
Sep 16 2024, 16:26
aklapper committed rARCead6759082d2: Fix PHP 8.1 "strlen(null)" exception in HTTPFutureHTTPResponseStatus.
Fix PHP 8.1 "strlen(null)" exception in HTTPFutureHTTPResponseStatus
Sep 16 2024, 16:26
valerio.bozzolan closed Q123: [Feature] Phorge integrates with Keycloak as obsolete.
Sep 16 2024, 15:01 · Phorge, Feature Requests
valerio.bozzolan added Q123: [Feature] Phorge integrates with Keycloak (Answer 188).
Sep 16 2024, 15:01
valerio.bozzolan created T15942: Native Keycloak auth integration.
Sep 16 2024, 15:00 · Auth
valerio.bozzolan closed Q128: How deeply is Ponder integrated with the rest of Phorge? as resolved.
Sep 16 2024, 14:57 · Ponder, Phorge
valerio.bozzolan added a comment to T15075: Add support for @link in diviner.

Taking the best from the two: what about assuming a default @link /book/group/best-document-ever-about-link - but still allowing custom @link to allow easy migrations?

Sep 16 2024, 14:45 · Diviner, Remarkup
valerio.bozzolan awarded T15911: PHP 8.1 "str_replace(null)" exception in DivinerAtomRef a Doubloon token.
Sep 16 2024, 14:27 · PHP 8 support
valerio.bozzolan requested changes to D25769: Fix PHP 8.1 "str_replace(null)" exception in DivinerAtomRef.

https://we.phorge.it/T15911#19487

Sep 16 2024, 14:26
valerio.bozzolan added a comment to T15911: PHP 8.1 "str_replace(null)" exception in DivinerAtomRef.

After looking again here:

Sep 16 2024, 14:26 · PHP 8 support
valerio.bozzolan accepted D25811: Fix PHP 8.1 "strlen(null)" exception in PhutilOAuth1Future.

sgtm

Sep 16 2024, 13:02
aklapper updated the diff for D25811: Fix PHP 8.1 "strlen(null)" exception in PhutilOAuth1Future.

Initialize key as an empty string as proposed by speck

Sep 16 2024, 12:19
valerio.bozzolan accepted D25810: Fix PHP 8.1 "strlen(null)" exception in HTTPFutureHTTPResponseStatus.

yesyes

Sep 16 2024, 09:52
aklapper updated the diff for D25810: Fix PHP 8.1 "strlen(null)" exception in HTTPFutureHTTPResponseStatus.

What Valerio says: As $body can be null, make sure that the rest of this function's code deals with an empty string and not with null

Sep 16 2024, 09:36
aklapper accepted D25824: Diffusion commit feed: fix commit title repeated twice.

Works locally; this makes sense to me (though I'm surprised it's in an Audit related source file).

Sep 16 2024, 09:04
aklapper updated the diff for D25774: Strike through archived projects in navigation crumbs.

Rebase; improve PhpDoc

Sep 16 2024, 08:52
aklapper edited the content of Next Up.
Sep 16 2024, 08:24
aklapper closed T15848: newOAuth1Future doesn't set a User-Agent as Resolved by committing rP39237c0854fe: Set base-uri as User-Agent for OAuth1 and Github authentication.
Sep 16 2024, 08:22 · Auth
aklapper closed D25758: Set base-uri as User-Agent for OAuth1 and Github authentication.
Sep 16 2024, 08:22
aklapper committed rP39237c0854fe: Set base-uri as User-Agent for OAuth1 and Github authentication.
Set base-uri as User-Agent for OAuth1 and Github authentication
Sep 16 2024, 08:22

Sep 14 2024

mturdus committed R5:b1dde4993c81: User authentication disabled for direct image urls (i.e. /diagram/data/)..
User authentication disabled for direct image urls (i.e. /diagram/data/).
Sep 14 2024, 17:30
valerio.bozzolan moved T15489: Diffusion commit feed: avoid to repeat the commit message twice from Code Sprint Candidate to PingDeath 🌚 on the User-valerio.bozzolan board.
Sep 14 2024, 14:16 · UX, User-valerio.bozzolan, Diffusion
valerio.bozzolan requested review of D25824: Diffusion commit feed: fix commit title repeated twice.
Sep 14 2024, 14:11
valerio.bozzolan added a revision to T15489: Diffusion commit feed: avoid to repeat the commit message twice: D25824: Diffusion commit feed: fix commit title repeated twice.
Sep 14 2024, 14:11 · UX, User-valerio.bozzolan, Diffusion
valerio.bozzolan claimed T15489: Diffusion commit feed: avoid to repeat the commit message twice.
Sep 14 2024, 13:54 · UX, User-valerio.bozzolan, Diffusion
valerio.bozzolan closed T15870: Provide documentation for Javelin scry, find, and findAbove as Resolved by committing rP0fe0b9f681d0: Documentation: add article about Javelin DOM stuff.
Sep 14 2024, 13:40 · User-valerio.bozzolan, Documentation
valerio.bozzolan closed D25822: Documentation: add article about Javelin DOM stuff.
Sep 14 2024, 13:40
valerio.bozzolan committed rP0fe0b9f681d0: Documentation: add article about Javelin DOM stuff.
Documentation: add article about Javelin DOM stuff
Sep 14 2024, 13:40
valerio.bozzolan added a comment to D25822: Documentation: add article about Javelin DOM stuff.

I hope that something is better than nothing I think. Then we can move if we don't like it.

Sep 14 2024, 13:39

Sep 11 2024

valerio.bozzolan updated the task description for T15941: Calendar Import: support Available/Busy.
Sep 11 2024, 09:22 · User-valerio.bozzolan, Calendar
valerio.bozzolan updated the name of F2491485: Phorge imported Calendar Event Busy.png from "image.png" to "Phorge imported Calendar Event Busy.png".
Sep 11 2024, 09:19
valerio.bozzolan created T15941: Calendar Import: support Available/Busy.
Sep 11 2024, 09:15 · User-valerio.bozzolan, Calendar
valerio.bozzolan updated the name of F2491461: Google Calendar Available example.png from "Screenshot_20240911_102858.png" to "Google Calendar Available example.png".
Sep 11 2024, 08:30

Sep 10 2024

aklapper accepted D25822: Documentation: add article about Javelin DOM stuff.

If Harbormaster is fine I better be fine too, dont want no problems with them for reals

Sep 10 2024, 21:51
mturdus added a comment to D25790: Show table of contents by default on wide screens.

Those were just for the looks, but this is of course personal.
I can remove them if you want.

Sep 10 2024, 16:56
valerio.bozzolan updated the diff for D25823: arc browse: add support to Subversion repos.

even simpler

Sep 10 2024, 12:54
valerio.bozzolan updated the diff for D25822: Documentation: add article about Javelin DOM stuff.

Ah! yes - undo ConpherenceViewController

Sep 10 2024, 12:47
valerio.bozzolan updated the diff for D25822: Documentation: add article about Javelin DOM stuff.

(I don't get the comment about D25784) thanks for feedback

Sep 10 2024, 12:43
aklapper requested changes to D25822: Documentation: add article about Javelin DOM stuff.

I guess D25784 shouldn't be mashed up in here thus requesting changes.

Sep 10 2024, 11:33
valerio.bozzolan claimed T15541: "arc browse <file>" does not support Subversion.

Uh!

Sep 10 2024, 11:28 · User-valerio.bozzolan, Arcanist
valerio.bozzolan requested review of D25823: arc browse: add support to Subversion repos.
Sep 10 2024, 11:26
valerio.bozzolan added a revision to T15541: "arc browse <file>" does not support Subversion: D25823: arc browse: add support to Subversion repos.
Sep 10 2024, 11:26 · User-valerio.bozzolan, Arcanist
aklapper added a comment to D25809: ArcanistBundleTestCase: fix support of non-English environments.

I fail to reproduce a problem locally (after commenting out entire ArcanistBundleTestCase::testGitRepository due to a different issue I'm running into locally).

Sep 10 2024, 11:25
aklapper added a comment to D25807: Clarify comment in PhutilJSON about required PHP version.

P.S. try applying D25809 to check if the red unit test becomes green

Sep 10 2024, 10:53
aklapper retitled D25790: Show table of contents by default on wide screens from Make table of contents visible when using wide screens
Sep 10 2024, 10:43
aklapper added a comment to D25790: Show table of contents by default on wide screens.

@mturdus: Thanks for the patch! I tested this locally on a wiki page with a bunch of sections and on http://phorge.localhost/book/phorge/article/remarkup/ ; and on Differential's /D1 where it does not affect the ToC panel (good).

Sep 10 2024, 10:42

Sep 9 2024

valerio.bozzolan updated the diff for D25822: Documentation: add article about Javelin DOM stuff.

fix typo

Sep 9 2024, 19:36
valerio.bozzolan requested review of D25822: Documentation: add article about Javelin DOM stuff.
Sep 9 2024, 16:04
valerio.bozzolan added a revision to T15870: Provide documentation for Javelin scry, find, and findAbove: D25822: Documentation: add article about Javelin DOM stuff.
Sep 9 2024, 16:04 · User-valerio.bozzolan, Documentation
valerio.bozzolan claimed T15870: Provide documentation for Javelin scry, find, and findAbove.
Sep 9 2024, 16:01 · User-valerio.bozzolan, Documentation
valerio.bozzolan claimed T15927: Fix Arcanist unit test ArcanistBundleTestCase->testNonlocalTrailingNewline() on non-English terminal.
Sep 9 2024, 13:52 · User-valerio.bozzolan
valerio.bozzolan added a parent task for T15872: Understand how to defuse localization in GNU Gettext: T15927: Fix Arcanist unit test ArcanistBundleTestCase->testNonlocalTrailingNewline() on non-English terminal.
Sep 9 2024, 13:52 · Bug Reports, User-valerio.bozzolan, Arcanist
valerio.bozzolan added a subtask for T15927: Fix Arcanist unit test ArcanistBundleTestCase->testNonlocalTrailingNewline() on non-English terminal: T15872: Understand how to defuse localization in GNU Gettext.
Sep 9 2024, 13:52 · User-valerio.bozzolan
aklapper closed T15919: AphrontMySQLDatabaseConnection calls external method fb_parallel_query() as Resolved by committing rP30c47690ffe3: Remove unused *ParallelQueries() database connection methods.
Sep 9 2024, 13:51
aklapper closed D25789: Remove unused *ParallelQueries() database connection methods.
Sep 9 2024, 13:51
aklapper committed rP30c47690ffe3: Remove unused *ParallelQueries() database connection methods.
Remove unused *ParallelQueries() database connection methods
Sep 9 2024, 13:51
aklapper closed D25819: PHPDoc: Replace "@return this" with "@return $this".
Sep 9 2024, 13:48
aklapper committed rPaa2b70708e2f: PHPDoc: Replace "@return this" with "@return $this".
PHPDoc: Replace "@return this" with "@return $this"
Sep 9 2024, 13:48
valerio.bozzolan added a comment to F2414418: Wojak depressed.png.

Deprecated. See wojak_depressed macro instead - https://we.phorge.it/macro/view/14/

Sep 9 2024, 13:46
valerio.bozzolan added a comment to Image Macro "wojak_depressed".

LOL don't take this too seriously but sometime this cursed thing makes sense

Sep 9 2024, 13:46
valerio.bozzolan created Image Macro "wojak_depressed".
Sep 9 2024, 13:46
valerio.bozzolan accepted D25819: PHPDoc: Replace "@return this" with "@return $this".

Wojak depressed.png (473×635 px, 160 KB)

Sep 9 2024, 13:45
valerio.bozzolan updated the summary of D25777: Make maniphest.gettasktransactions include metadata and title.
Sep 9 2024, 07:33
valerio.bozzolan edited the content of Organizations Using Phorge.
Sep 9 2024, 07:24

Sep 8 2024

valerio.bozzolan edited the content of 2024 week 35.
Sep 8 2024, 20:11
valerio.bozzolan renamed 2024 week 35 from 2024.35 to 2024 week 35.
Sep 8 2024, 20:10
revi added a comment to 2024 week 35.
From the text body:
IMPORTANT: Share that patch to your DBA <snip>
Sep 8 2024, 18:20
valerio.bozzolan edited the content of Community Resources.
Sep 8 2024, 12:02
aklapper updated the task description for T15940: Update copy of external mimemailparser library.
Sep 8 2024, 08:09

Sep 7 2024

valerio.bozzolan created an object: Internal Documentation.
Sep 7 2024, 16:20
aklapper updated the diff for D25816: Fix implicitly nullable parameter declarations for PHP 8.4.

Moah fixees

Sep 7 2024, 12:29
aklapper updated the test plan for D25816: Fix implicitly nullable parameter declarations for PHP 8.4.
Sep 7 2024, 12:28
aklapper updated the test plan for D25816: Fix implicitly nullable parameter declarations for PHP 8.4.
Sep 7 2024, 12:27
aklapper closed D25820: Fix unit test failure in link-alternate.
Sep 7 2024, 09:00
aklapper committed rPf25c531e5685: Fix unit test failure in link-alternate.
Fix unit test failure in link-alternate
Sep 7 2024, 09:00
valerio.bozzolan accepted D25820: Fix unit test failure in link-alternate.

Nice catch, thanks! Sorry for this regression in unit tests

Sep 7 2024, 08:08
aklapper retitled D25820: Fix unit test failure in link-alternate from Update unit test link-alternate
Sep 7 2024, 07:35
aklapper requested review of D25821: Fix PHP 8.1 "strlen(null)" exception in SVN commit query without identifier.
Sep 7 2024, 07:33
aklapper added a revision to T15936: PHP8.1 strlen(): Passing null to parameter is deprecated: D25821: Fix PHP 8.1 "strlen(null)" exception in SVN commit query without identifier.
Sep 7 2024, 07:33 · PHP 8 support
aklapper requested review of D25820: Fix unit test failure in link-alternate.
Sep 7 2024, 04:36

Sep 6 2024

keithzg closed Q150: Any way to set default visibility on file uploads to Conpherence? as resolved.
Sep 6 2024, 21:51 · Files, Conpherence
keithzg added a comment to Q150: Any way to set default visibility on file uploads to Conpherence? (Answer 187).

Does appear fixed in latest master!

Sep 6 2024, 21:50
valerio.bozzolan added inline comments to rARC06028fad3c6a: Add return statements for PhutilChannelChannel::readBytes()/writeBytes().
Sep 6 2024, 19:11