Initialize key as an empty string as proposed by speck

What Valerio says: As $body can be null, make sure that the rest of this function's code deals with an empty string and not with null

Works locally; this makes sense to me (though I'm surprised it's in an Audit related source file).

Rebase; improve PhpDoc

If Harbormaster is fine I better be fine too, dont want no problems with them for reals

I guess D25784 shouldn't be mashed up in here thus requesting changes.

I fail to reproduce a problem locally (after commenting out entire ArcanistBundleTestCase::testGitRepository due to a different issue I'm running into locally).

In D25807#21516, @valerio.bozzolan wrote:

P.S. try applying D25809 to check if the red unit test becomes green

@mturdus: Thanks for the patch! I tested this locally on a wiki page with a bunch of sections and on http://phorge.localhost/book/phorge/article/remarkup/ ; and on Differential's /D1 where it does not affect the ToC panel (good).

Moah fixees

@valerio.bozzolan: Thank you! I know this is super boring work, but it allows PHPStan to show other type/class issues which are currently hidden due to PHPStan barking earlier about that non-standard question mark when parsing those lines. :-/

Abandoning in favor of T15890 and D25774 per previous discussion

Abandoning in favor of T15890 and D25774 per previous discussion

In T15848#19430, @valerio.bozzolan wrote:

I would like to better understand the root problem.

Why changing the current user agent should improve the situation?

Leave out special case src/workflow/ArcanistWorkflow.php for now

I'd prefer not to increase the diff to upstream (as a side effect of this very task) but instead to pull a more recent upstream version - see T15940.

Right, should have probably also covered that line in D25186 which is more or less the same...

In D25731#21664, @valerio.bozzolan wrote:

Since you helped a lot in D25774 - I'm not sure this is needed anymore. Maybe better to get better opinions. For example I found this a bit irritating for my archived Milestones.

Supporting PHP 8.4 (currently planned for 2024-11-21) will require PHP syntax introduced in PHP 7.1 per T15935.

Note that above two patches only allow passing ./bin/storage upgrade but not to run Phorge. That would be a followup once these initial patches got in.