In D25619#17560, @valerio.bozzolan wrote:

Maybe "feature" but note the left sidebar, is not anymore connected to the end of the viewport:

Before	After

./bin/celerity map

• Fixes non stretching nav bar if content is absolute or does not fill entire page height

@avivey that's an excellent observation.

Uh, Conduit also says Task IDs must be integer numbers. Nice. But how can I reset "Planned Changes"? Only by pushing another revision?

TODO: Check how Conduit reacts to this

Add PHPDoc; tested that return value is always plain string, also with custom logo

In D25668#18281, @avivey wrote:

need to also test the result of renderPhabricatorLogo() when no logo set, when a custom logo is set, and when a custom logo is set but hidden (maybe. Maybe the logo file should be Attached to something public, so this situation can't really happen?)

Move policy.allow-public check from method itself to calling the method

need to also test the result of renderPhabricatorLogo() when no logo set, when a custom logo is set, and when a custom logo is set but hidden (maybe. Maybe the logo file should be Attached to something public, so this situation can't really happen?)

That "don't sign a CLA" article should be titled "don't sign away your copyrights", to be more accurate and less click-bait-y. A CLA may ask you to sign away copyrights (which I feel makes the project non-open-source) ; It doesn't have to.

Note to myself: Still need to test resulting URI when a custom logo is set

Replace a call with a variable

This probably needs more work but seems to function locally.

I'm pretty fine with DCO (which I already do every commit via the git commit -s command) — but I'd rather not sign a CLA. (I’m pretty undecided if I will sign phorge's CLA, but phorge is not commercial entity seeking to mongodb/terraform/elasticsearch-ize the software (read: make a profit from open source, then turn it into All Rights Reserved) so I might do so… after all these incidents I'm rather wary of it.)

Garr, I did not branch.

@20after4: Willing to share some code at some point that folks can poke or play with? :) TIA!

Thanks asd

Valerio may have a point here :D

I'm stupid and should have really checked the commit history first. Sorry!

Uh thanks, I had no idea where the upstream is, good to know because there are a few more issues. :)

shot at line 1162

Thanks :3 Hoping to be useful I will amend with a minimal sed -i 's/QRbitrtream/QRbitstream/' externals/phpqrcode/phpqrcode.php

I tested this with the following snippet:

Thanks :3 It makes sense, and I've also tested that snippet in PHP 5.5 and PHP 8.1 obtaining same results (premising that each() is not available anymore in PHP 8 as already clarified)

It was probably confused with the internal API executeRemovePath

Uh? It seems in use to me, in legacy lines 142, 145, 154, 155, etc.

Uh! I like this.

Probably OK now

Hmm, I also found this mentioned in https://secure.phabricator.com/T12404#256288 proposing a slightly different approach.

Indentation is awesome