Use correct markup for comment about markup

Documentation is arrsum

Thanks everyone for the feedback! Looks like my initial assumptions are already uncommon, so I'm going to decline this ticket for the time being.
The counterproposal makes more sense to me on an 'upstream' level, indeed.

Abandoning per feedback in T15780 (note to myself: may want to consider deploying this in downstream)

Move additional check after existing checks

In D25601#17036, @valerio.bozzolan wrote:

Maybe better to expand the test plan to check user creation as well

Garrrr, I am very sorry, I was locally experimenting with something else in master branch beforehand obviously, and while I did git stash that one file I created continued to exist in the tree when I branched to work on the dashboard exception - my fault.

I pretended to be a webcrawlerLooking into our downstream error logs. Some crawlers seem very creative for reasons I do not know.

Oh liberate me from my previous flawed attempts, almighty arc

Faster logic, higher performance, and better looking strings! Now all included in this brand new version!

A while ago I looked at this in downstream https://phabricator.wikimedia.org/T259329#9354946 (long version).
In short, rPce953ea4479052c7e671c8c75af6833252ebefd4 and rP657f3c380608abc0fc59088d979457f1d8826f06 are the culprits.

Which exact page(s) is this ticket about?

In D25080#16551, @valerio.bozzolan wrote:

Eeeh but in that way it's 84 and 87 chars long.

Note that $xaction->getOldValue() in https://we.phorge.it/source/phorge/browse/master/src/applications/people/xaction/PhabricatorUserUsernameTransaction.php$62 seems to always return null. It does not provide the old/current username, while generateOldValue() actually does.

Screenshot before (M17) and after (M18) applying D25600: