Remove unreached return call as pointed out by speck

In D25502#15384, @speck wrote:

Is it possible to check if anything is relying on this not working with negative numbers?

@deric: Hi, would you like to arc land your patch, or do you need any help? Thanks in advance!

For the records, adding public function getValueForQuery($value) is needed because otherwise Expected a numeric scalar or null for %d conversion. Query: project.projectDepth >= %d

Would anyone fancy reviewing this? :)

Make code more readable

In D25525#15322, @valerio.bozzolan wrote:

Maybe simplify if (empty($v)) { to just if ($v) { and swapping the case

For consideration of the bigger picture, I'd like to mention https://collinmbarrett.com/block-web-fonts (performance etc) and for example Firefox 118+ blocking font fingerprinting in private windows (yes, private only, but I can vaguely imagine expansion).

I am honestly happy that you have the privilege to afford getting bigger screens. Unfortunately not everyone has. The point I'm trying to make is: There may be valid + good reasons to increase font sizes, absolutely. However, "go with the time" and "times have changed" phrases are neither valid reasons nor argumentations. :)

In T15630#15561, @bekay wrote:

Times have changed and we all have very big screens.

Testing if "Foist Upon" does what I hope it does

@avivey Much cleaner and also works as expected (just tested). Thanks for finding that better approach! Now how can I approve your patch as I'm still set as original author, sigh?

In T15726#15440, @avivey wrote:

I'm not sure from the description if it's only broken on php 8. We also have PayPal integration)

Also my fault for obviously not testing /all/ steps in D25530

cf a very similar discussion about default fonts in GNOME at https://gitlab.gnome.org/GNOME/gsettings-desktop-schemas/-/issues/52 regarding aspects to take into consideration

@valerio.bozzolan Thanks. I guess I owe you a drink next weekend :)

@valerio.bozzolan: Which problem would that solve? :)

Test Plan still to be fully executed thus setting "Plan Changes"

In D25529#15137, @aklapper wrote:

I admit I did not test what happens when setting a (deprecated) timezone in Phorge to be removed by this patch, and then applying this patch.

Makes sense.
Fund: Going to http://phorge.localhost/fund/create/ and creating a New Initiative anyway yields

EXCEPTION: (RuntimeException) Undefined array key "totalAsCurrency" at [<arcanist>/src/error/PhutilErrorHandler.php:273]
arcanist(head=master, ref.master=6c7caf3572f4), phorge(head=master, ref.master=c0191a039293)
  #0 <#2> PhutilErrorHandler::handleError(integer, string, string, integer) called at [<phorge>/src/infrastructure/storage/lisk/PhabricatorLiskDAO.php:345]

I admit I did not test what happens when setting a (deprecated) timezone in Phorge to be removed by this patch, and then applying this patch.

In D25517#14978, @valerio.bozzolan wrote:

In an ideal world 1030-1313 could become just:

In D25517#14977, @valerio.bozzolan wrote:

// TODO: Once everything is on EditEngine, just use getIsNewObject()

So maybe this? but I'm not bold enough:

Before and after applying D25525:

In D25500#15024, @aklapper wrote:

and thus remove the only newly added call which returned null in src/applications/meta/query/PhabricatorApplicationApplicationTransactionQuery.php)

In D25500#15027, @aklapper wrote:

Maybe we can return ClassName::class - that is supported since PHP 5.5

there's a lot more code to update in random *Query.php classes defining getQueryApplicationClass() functions, in a separate future patch

Right. Sorry, my previous comment was very misleading!

Maybe we can return ClassName::class - that is supported since PHP 5.5

Note to myself: Makes sense; there's a lot more code to update in random *Query.php classes defining getQueryApplicationClass() functions, in a separate future patch

Revert turning getQueryApplicationClass() abstract in the parent class src/applications/transactions/query/PhabricatorApplicationTransactionQuery.php and make it return null again (and thus remove the only newly added call which returned null in src/applications/meta/query/PhabricatorApplicationApplicationTransactionQuery.php); also return ::class as proposed by Valerio

Fix D25501#14443: Do not show an "Query overheated" error when the user is anonymous and the application has been uninstalled

In D25501#14458, @20after4 wrote:

Are there any feed transactions that are visible to logged out users?

Play it safe by using phutil_nonempty_scalar() and do not assume that integers are actually integers (because "1" and such)

In D25515#14957, @avivey wrote:

I was able to trigger the "missing gd" warning (By uninstalling php*gd), so we're good there.
A bit puzzled about how you got the error if you already have it installed?

In D25515#14842, @valerio.bozzolan wrote:

I wonder if it then, upon deletion of the profile image, it attempts to delete the builtin image