Would there be a bunch of these lying around?

Is the list of PHIDs referring to what types of objects that it creates? Is the expectation that each PHID type corresponds to exactly one Application? Maybe some additional text on that page to explain more what PHIDs mean in this context.

I've tested this locally with:

Premising that I love your new list of PHIDs:

I cannot double-accept but I like this even more

git rebase master
arc lint
arc unit

Basically, it works :D

Tested, it works, thanks :) Just feel free to follow the suggestion

Remove "'hidden' => true," line from javelin config - no longer required.

Initially, the task is in the project's default column:

MariaDB [phabricator_project]> SELECT cp.id, p.name AS projectName, cp.boardPHID, c.name AS columnName, cp.columnPHID FROM project_columnposition cp INNER JOIN project_column c ON cp.columnPHID = c.phid INNER JOIN phabricator_project.project p ON cp.boardPHID = p.phid WHERE objectPHID ="PHID-TASK-f6ri2kdpcvtb3yncho2n";
+-----+----------------+--------------------------------+------------+--------------------------------+
| id  | projectName    | boardPHID                      | columnName | columnPHID                     |
+-----+----------------+--------------------------------+------------+--------------------------------+
| 509 | T139396-parent | PHID-PROJ-yt43plz2cxlidyu4dlia | Backloggg  | PHID-PCOL-no7jbin6vngwkrghrmrk |
+-----+----------------+--------------------------------+------------+--------------------------------+

Update the button such that it toggles between 'Open Index' and 'Close Index'

In D25457#13055, @valerio.bozzolan wrote:

Non-blocking stuff:

3. Maybe we should also evaluate this?
   

Rebuild celerity map

Skipping lint because I cannot get javelinsymbols from https://github.com/phacility/javelin/tree/master to compile under OSX
Actually, it's the out-of-support 13 year old libfbjs (from https://github.com/facebookarchive/libfbjs) from it which won't compile.
I recommend javelin linting is dropped, and replaced with a more modern javascript linter.

Move javascript into a Javelin event.
Correct mistake in Javelin documentation.

So, we are here if I understand correctly:

even more minor change

Revert indentation changes

Ah, thanks for landing

This collapsible is interesting thanks!

In D25457#13043, @valerio.bozzolan wrote:

I like the general idea but I don't know how to improve it graphically. I mean, this is the current rendering for a simple README of two sections:

I don't think any document with a header to text line ratio of 2:3 is going to look good without customised formatting.

The Javascript is inline for now, and we can look at putting it somewhere better if this diff is worth pursuing. Suggestions of where to put it welcome!

Replace method_exists with instance of, as per review

Thanks again for this change

In D25420#12963, @speck wrote:

Instead of adding a checkbox is there precedent for having a separate button alongside Cancel and Submit?

Replacing 'new PhutilSafeHTML' with 'phutil_implode_html' as per review. Much nicer!

Change PHID list to have new lines instead of commas

In D25362#12819, @valerio.bozzolan wrote:

Hi @Matthew can I help in landing this useful change?

Looks OK from XSS perspective - protection already in place. Ready for review!

Need to put in some XSS protection.

Restore fixed interpreter-test.txt

This looks like a reasonable chance to me.

Nice

Great points. Thank you for talking through more details.

Nice, thank you!

Would anyone be willing to give this another review? TIA

Rephrase comment

In D25450#12945, @speck wrote:

Maybe add some doc - the view and edit actions being lumped together are because it would be a larger change to split out that functionality right now, correct?

Show 404 error instead of policy based message

Instead of adding a checkbox is there precedent for having a separate button alongside Cancel and Submit?

I’m surprised the monograms weren’t already defined on the applications - those should be somewhere already, right?

Basically it works

😂

This looks good and I really like the idea of being able to customize the style of external links. Just one tweak to the logic I think we should add before landing.

Looks good to me, I suggest clarifying the comment before landing.

Maybe add some doc - the view and edit actions being lumped together are because it would be a larger change to split out that functionality right now, correct?