Page MenuHomePhorge
Feed All Stories

Nov 9 2023

waldyrious added inline comments to D25458: Adjust message in timezone conflict form.
Nov 9 2023, 00:49

Nov 8 2023

speck accepted D25459: Fix doc link to Restarting Phorge.

Would there be a bunch of these lying around?

Nov 8 2023, 23:20
speck accepted D25362: Show more in Application Detail and List view.

Is the list of PHIDs referring to what types of objects that it creates? Is the expectation that each PHID type corresponds to exactly one Application? Maybe some additional text on that page to explain more what PHIDs mean in this context.

Nov 8 2023, 23:20
speck accepted D25408: Fix Exception in Chat room when you are not a Participant.
Nov 8 2023, 23:17
Bukkit updated Bukkit.
Nov 8 2023, 17:59
valerio.bozzolan accepted D25459: Fix doc link to Restarting Phorge.

I've tested this locally with:

Nov 8 2023, 17:51
l2dy requested review of D25459: Fix doc link to Restarting Phorge.
Nov 8 2023, 14:15
valerio.bozzolan added a comment to D25362: Show more in Application Detail and List view.

Premising that I love your new list of PHIDs:

Nov 8 2023, 11:30
valerio.bozzolan retitled D25362: Show more in Application Detail and List view from Show more in application detail and list view
Nov 8 2023, 11:25
valerio.bozzolan updated the name of F393393: PhabricatorDiffusionApplication after D25362.png from "image.png" to "PhabricatorDiffusionApplication after D25362.png".
Nov 8 2023, 11:23
valerio.bozzolan accepted D25362: Show more in Application Detail and List view.

I cannot double-accept but I like this even more

Nov 8 2023, 11:19
valerio.bozzolan updated the diff for D25362: Show more in Application Detail and List view.

git rebase master
arc lint
arc unit

Nov 8 2023, 11:18
valerio.bozzolan added a comment to D25408: Fix Exception in Chat room when you are not a Participant.

Basically, it works :D

Nov 8 2023, 11:12
valerio.bozzolan accepted D25458: Adjust message in timezone conflict form.

Tested, it works, thanks :) Just feel free to follow the suggestion

Nov 8 2023, 08:36
valerio.bozzolan added inline comments to D25458: Adjust message in timezone conflict form.
Nov 8 2023, 08:34
aklapper awarded D25458: Adjust message in timezone conflict form a Love token.
Nov 8 2023, 08:00
valerio.bozzolan edited the content of 2023 Week 32.
Nov 8 2023, 07:47
valerio.bozzolan edited the content of Next Up.
Nov 8 2023, 07:40

Nov 7 2023

Sten updated the diff for D25457: Update diffusion browse to generate Table of Contents when viewed as remarkup.

Remove "'hidden' => true," line from javelin config - no longer required.

Nov 7 2023, 23:03
aklapper added a comment to T15650: AphrontDuplicateKeyQueryException dragging task from milestone column to main board column: Duplicate entry for key 'boardPHID'.

Initially, the task is in the project's default column:

MariaDB [phabricator_project]> SELECT cp.id, p.name AS projectName, cp.boardPHID, c.name AS columnName, cp.columnPHID FROM project_columnposition cp INNER JOIN project_column c ON cp.columnPHID = c.phid INNER JOIN phabricator_project.project p ON cp.boardPHID = p.phid WHERE objectPHID ="PHID-TASK-f6ri2kdpcvtb3yncho2n";
+-----+----------------+--------------------------------+------------+--------------------------------+
| id  | projectName    | boardPHID                      | columnName | columnPHID                     |
+-----+----------------+--------------------------------+------------+--------------------------------+
| 509 | T139396-parent | PHID-PROJ-yt43plz2cxlidyu4dlia | Backloggg  | PHID-PCOL-no7jbin6vngwkrghrmrk |
+-----+----------------+--------------------------------+------------+--------------------------------+
Nov 7 2023, 23:00 · Affects-Wikimedia, Bug Reports
Sten updated the diff for D25457: Update diffusion browse to generate Table of Contents when viewed as remarkup.

Update the button such that it toggles between 'Open Index' and 'Close Index'

Nov 7 2023, 22:59
Sten added a comment to D25457: Update diffusion browse to generate Table of Contents when viewed as remarkup.

Non-blocking stuff:

  1. Maybe we should also evaluate this?
    Arrow indicating a proposal UX change in a Phorge README.png (168×1 px, 14 KB)
Nov 7 2023, 22:47
Sten updated the diff for D25457: Update diffusion browse to generate Table of Contents when viewed as remarkup.

Rebuild celerity map

Nov 7 2023, 22:43
Sten updated the diff for D25457: Update diffusion browse to generate Table of Contents when viewed as remarkup.

Skipping lint because I cannot get javelinsymbols from https://github.com/phacility/javelin/tree/master to compile under OSX
Actually, it's the out-of-support 13 year old libfbjs (from https://github.com/facebookarchive/libfbjs) from it which won't compile.
I recommend javelin linting is dropped, and replaced with a more modern javascript linter.

Nov 7 2023, 22:42
Sten updated the diff for D25457: Update diffusion browse to generate Table of Contents when viewed as remarkup.

Move javascript into a Javelin event.
Correct mistake in Javelin documentation.

Nov 7 2023, 21:46
Sten added inline comments to D25457: Update diffusion browse to generate Table of Contents when viewed as remarkup.
Nov 7 2023, 21:46
valerio.bozzolan added a comment to D25425: Remove mention of Phabricator in the Auth setup check.

So, we are here if I understand correctly:

Nov 7 2023, 17:32
valerio.bozzolan updated the diff for D25425: Remove mention of Phabricator in the Auth setup check.

even more minor change

Nov 7 2023, 17:20
waldyrious updated the diff for D25425: Remove mention of Phabricator in the Auth setup check.

Revert indentation changes

Nov 7 2023, 16:49
waldyrious requested review of D25458: Adjust message in timezone conflict form.
Nov 7 2023, 15:59
valerio.bozzolan edited the content of Next Up.
Nov 7 2023, 14:12
valerio.bozzolan updated the summary of D25420: Improving UX for ignoring timezone conflicts.
Nov 7 2023, 14:10
valerio.bozzolan updated the task description for T15349: Explicitly cover in "Timezone settings" dialog how to ignore the browser vs profile conflict.
Nov 7 2023, 14:09 · Good Starter Task
valerio.bozzolan changed the visibility for F392356: Adjust time - After.png.
Nov 7 2023, 14:09
valerio.bozzolan changed the visibility for F392354: Adjust time - Before.png.
Nov 7 2023, 14:09
gt updated gt.
Nov 7 2023, 12:06
gt set Timezone to CET on gt.
Nov 7 2023, 12:06
valerio.bozzolan added a project to Q83: Pull security fixes from Mozilla's fork: Security.
Nov 7 2023, 09:46 · Security, Phorge
valerio.bozzolan added inline comments to D25421: Audit Feed: less verbose when the author is the committer.
Nov 7 2023, 09:08
valerio.bozzolan added a comment to D25420: Improving UX for ignoring timezone conflicts.

Ah, thanks for landing

Nov 7 2023, 08:30
roberto.urbani closed T15349: Explicitly cover in "Timezone settings" dialog how to ignore the browser vs profile conflict as Resolved by committing rP37ecdf233697: Improving UX for ignoring timezone conflicts.
Nov 7 2023, 08:29 · Good Starter Task
roberto.urbani closed D25420: Improving UX for ignoring timezone conflicts.
Nov 7 2023, 08:29
roberto.urbani committed rP37ecdf233697: Improving UX for ignoring timezone conflicts.
Improving UX for ignoring timezone conflicts
Nov 7 2023, 08:29
valerio.bozzolan added a comment to D25457: Update diffusion browse to generate Table of Contents when viewed as remarkup.

This collapsible is interesting thanks!

Nov 7 2023, 08:24
valerio.bozzolan updated the name of F391624: Arrow indicating a proposal UX change in a Phorge README.png from "Screenshot_2023_11_07_092015.png" to "Arrow indicating a proposal UX change in a Phorge README.png".
Nov 7 2023, 08:23
valerio.bozzolan added inline comments to D25457: Update diffusion browse to generate Table of Contents when viewed as remarkup.
Nov 7 2023, 08:13

Nov 6 2023

Sten added a comment to D25457: Update diffusion browse to generate Table of Contents when viewed as remarkup.

I like the general idea but I don't know how to improve it graphically. I mean, this is the current rendering for a simple README of two sections:

I don't think any document with a header to text line ratio of 2:3 is going to look good without customised formatting.

Nov 6 2023, 21:50
Sten added a comment to D25457: Update diffusion browse to generate Table of Contents when viewed as remarkup.

The Javascript is inline for now, and we can look at putting it somewhere better if this diff is worth pursuing. Suggestions of where to put it welcome!

Nov 6 2023, 21:47
Sten updated the diff for D25457: Update diffusion browse to generate Table of Contents when viewed as remarkup.

Replace method_exists with instance of, as per review

Nov 6 2023, 21:36
valerio.bozzolan added a comment to D25457: Update diffusion browse to generate Table of Contents when viewed as remarkup.

Thanks again for this change

Nov 6 2023, 15:22
valerio.bozzolan updated the name of F390360: Example README.png from "Screenshot_2023_11_06_161955.png" to "Example README.png".
Nov 6 2023, 15:20
valerio.bozzolan added inline comments to D25457: Update diffusion browse to generate Table of Contents when viewed as remarkup.
Nov 6 2023, 14:47
valerio.bozzolan added a comment to D25420: Improving UX for ignoring timezone conflicts.
In D25420#12963, @speck wrote:

Instead of adding a checkbox is there precedent for having a separate button alongside Cancel and Submit?

Nov 6 2023, 14:26
l2dy added a project to Q83: Pull security fixes from Mozilla's fork: Phorge.
Nov 6 2023, 13:35 · Security, Phorge
l2dy updated the question details for Q83: Pull security fixes from Mozilla's fork.
Nov 6 2023, 13:20 · Security, Phorge
l2dy asked Q83: Pull security fixes from Mozilla's fork.
Nov 6 2023, 13:20 · Security, Phorge
Sten updated the diff for D25457: Update diffusion browse to generate Table of Contents when viewed as remarkup.

Replacing 'new PhutilSafeHTML' with 'phutil_implode_html' as per review. Much nicer!

Nov 6 2023, 08:04
Matthew updated the diff for D25362: Show more in Application Detail and List view.

Change PHID list to have new lines instead of commas

Nov 6 2023, 06:07
valerio.bozzolan added inline comments to D25457: Update diffusion browse to generate Table of Contents when viewed as remarkup.
Nov 6 2023, 06:03
valerio.bozzolan awarded T15443: Add Diffusion policy capability "Can Edit and View Identities" a Like token.
Nov 6 2023, 05:57 · Diffusion, Policy
Matthew added a comment to D25362: Show more in Application Detail and List view.

Hi @Matthew can I help in landing this useful change?

Nov 6 2023, 05:36

Nov 5 2023

Sten requested review of D25457: Update diffusion browse to generate Table of Contents when viewed as remarkup.

Looks OK from XSS perspective - protection already in place. Ready for review!

Nov 5 2023, 17:04
l2dy asked Q82: Consider replacing MyISAM with InnoDB?.
Nov 5 2023, 16:58 · Phorge
Sten planned changes to D25457: Update diffusion browse to generate Table of Contents when viewed as remarkup.

Need to put in some XSS protection.

Nov 5 2023, 16:16
Sten updated the diff for D25457: Update diffusion browse to generate Table of Contents when viewed as remarkup.

Restore fixed interpreter-test.txt

Nov 5 2023, 16:06
Sten requested review of D25457: Update diffusion browse to generate Table of Contents when viewed as remarkup.
Nov 5 2023, 15:57
Sten added a revision to T15660: Generate a Table of Content for Diffusion browse as Remarkup (?as=remarkup): D25457: Update diffusion browse to generate Table of Contents when viewed as remarkup.
Nov 5 2023, 15:57 · Feature Requests
Sten abandoned D25456: Update diffusion browse to generate Table of Contents when viewed as remarkup.
Nov 5 2023, 15:55
Sten requested review of D25456: Update diffusion browse to generate Table of Contents when viewed as remarkup.
Nov 5 2023, 15:54
Sten added a revision to T15660: Generate a Table of Content for Diffusion browse as Remarkup (?as=remarkup): D25456: Update diffusion browse to generate Table of Contents when viewed as remarkup.
Nov 5 2023, 15:54 · Feature Requests
Sten claimed T15660: Generate a Table of Content for Diffusion browse as Remarkup (?as=remarkup).
Nov 5 2023, 15:13 · Feature Requests
speck accepted D25374: Fix PHP 8.1 "urlencode(null)" exception blocking account registration redirect for custom OAuth provider.

This looks like a reasonable chance to me.

Nov 5 2023, 15:13
speck accepted D25455: Fix cursor paging issue in Given Token query call.

Nice

Nov 5 2023, 15:09
speck accepted D25450: Add Diffusion policy capability "Can Edit and View Identities".

Great points. Thank you for talking through more details.

Nov 5 2023, 15:07
speck accepted D25452: Do not expose Contact Numbers settings panel when no SMS support configured.

Nice, thank you!

Nov 5 2023, 15:06
aklapper added a comment to D25374: Fix PHP 8.1 "urlencode(null)" exception blocking account registration redirect for custom OAuth provider.

Would anyone be willing to give this another review? TIA

Nov 5 2023, 14:42
aklapper requested review of D25455: Fix cursor paging issue in Given Token query call.
Nov 5 2023, 14:37
aklapper added a revision to T15652: Unhandled Exception: Call to undefined method PhabricatorTokenGivenQuery::withIDs(): D25455: Fix cursor paging issue in Given Token query call.
Nov 5 2023, 14:37 · Bug Reports
valerio.bozzolan added a member for Trusted Contributors: l2dy.
Nov 5 2023, 13:38
aklapper closed T15636: Project page (using its slug in URL) is a 404 after renaming project as Resolved by committing rP887e344c19af: Fix project page 404 after rename and removing new name from alias slugs.
Nov 5 2023, 12:18 · Bug Reports
aklapper closed D25453: Fix project page 404 after rename and removing new name from alias slugs.
Nov 5 2023, 12:18
aklapper committed rP887e344c19af: Fix project page 404 after rename and removing new name from alias slugs.
Fix project page 404 after rename and removing new name from alias slugs
Nov 5 2023, 12:18
aklapper updated the diff for D25453: Fix project page 404 after rename and removing new name from alias slugs.

Rephrase comment

Nov 5 2023, 12:16
aklapper added a comment to D25450: Add Diffusion policy capability "Can Edit and View Identities".
In D25450#12945, @speck wrote:

Maybe add some doc - the view and edit actions being lumped together are because it would be a larger change to split out that functionality right now, correct?

Nov 5 2023, 11:45
aklapper updated the diff for D25452: Do not expose Contact Numbers settings panel when no SMS support configured.

Show 404 error instead of policy based message

Nov 5 2023, 10:03
aklapper updated the test plan for D25452: Do not expose Contact Numbers settings panel when no SMS support configured.
Nov 5 2023, 10:00
avivey awarded Q81: Documentation for "Restarting Phabricator" is missing a Grey Medal token.
Nov 5 2023, 07:42 · Phorge
l2dy asked Q81: Documentation for "Restarting Phabricator" is missing.
Nov 5 2023, 04:00 · Phorge
l2dy asked Q80: Bug: passing null to strlen in readLocalArcConfig.
Nov 5 2023, 01:38 · Arcanist

Nov 4 2023

aklapper closed T15658: PHP 8.1 "strlen(null)" exception on Diffusion repo URIs page after repo creation, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3, as Resolved.
Nov 4 2023, 18:35 · PHP 8 support
aklapper closed T15658: PHP 8.1 "strlen(null)" exception on Diffusion repo URIs page after repo creation as Resolved by committing rP222a6fea0a1d: Fix PHP 8.1 "strlen(null)" exception on Diffusion repo URIs page after repo….
Nov 4 2023, 18:35 · PHP 8 support
aklapper closed D25454: Fix PHP 8.1 "strlen(null)" exception on Diffusion repo URIs page after repo creation.
Nov 4 2023, 18:35
aklapper committed rP222a6fea0a1d: Fix PHP 8.1 "strlen(null)" exception on Diffusion repo URIs page after repo….
Fix PHP 8.1 "strlen(null)" exception on Diffusion repo URIs page after repo…
Nov 4 2023, 18:35
speck added a comment to D25420: Improving UX for ignoring timezone conflicts.

Instead of adding a checkbox is there precedent for having a separate button alongside Cancel and Submit?

Nov 4 2023, 15:25
speck added a comment to D25362: Show more in Application Detail and List view.

I’m surprised the monograms weren’t already defined on the applications - those should be somewhere already, right?

Nov 4 2023, 15:13
speck accepted D25421: Audit Feed: less verbose when the author is the committer.

Basically it works

😂

Nov 4 2023, 15:07
speck accepted D25454: Fix PHP 8.1 "strlen(null)" exception on Diffusion repo URIs page after repo creation.
Nov 4 2023, 15:00
speck added a comment to D25118: Remarkup: make less internal links open in new tabs.

This looks good and I really like the idea of being able to customize the style of external links. Just one tweak to the logic I think we should add before landing.

Nov 4 2023, 15:00
speck accepted D25453: Fix project page 404 after rename and removing new name from alias slugs.

Looks good to me, I suggest clarifying the comment before landing.

Nov 4 2023, 14:50
speck added a comment to D25450: Add Diffusion policy capability "Can Edit and View Identities".

Maybe add some doc - the view and edit actions being lumped together are because it would be a larger change to split out that functionality right now, correct?

Nov 4 2023, 14:46