Page MenuHomePhorge

Fix project page 404 after rename and removing new name from alias slugs
ClosedPublic

Authored by aklapper on Oct 28 2023, 18:24.
Tags
None
Referenced Files
Unknown Object (File)
Sun, May 5, 01:55
Unknown Object (File)
Sun, May 5, 01:55
Unknown Object (File)
Fri, May 3, 21:33
Unknown Object (File)
Fri, May 3, 21:33
Unknown Object (File)
Mon, Apr 29, 00:25
Unknown Object (File)
Mon, Apr 29, 00:25
Unknown Object (File)
Mon, Apr 29, 00:25
Unknown Object (File)
Mon, Apr 29, 00:21

Details

Summary

When renaming a project to a slug already listed under Additional hashtags and explicitly also removing that to-become slug, accessing the project via the URL /tag/projectname/ returned a 404 until someone added the current project name explicitly under "Additional hashtags" again.

In that case, do not remove the alternative hashtag to avoid the 404.

Closes T15636

Test Plan

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

speck subscribed.

Looks good to me, I suggest clarifying the comment before landing.

src/applications/project/editor/PhabricatorProjectTransactionEditor.php
298

Maybe rephrase this comment

Do not allow removing the page’s primary slug, which the edit form may allow through a series of renames/moves, see T15636

This revision is now accepted and ready to land.Nov 4 2023, 14:50