Page MenuHomePhorge
Feed Advanced Search

Sun, May 5

waldyrious changed the visibility for F2179138: image.png.
Sun, May 5, 11:09
waldyrious updated the task description for T15270: "Access Denied: Restricted File" strings concatenated without whitespace.
Sun, May 5, 11:08 · UX, Good Starter Task, Files
waldyrious accepted D25419: Fix the whitespace issue in the message "Access Denied: Restricted File".
Sun, May 5, 10:58 · UX
waldyrious added a comment to D25419: Fix the whitespace issue in the message "Access Denied: Restricted File".

Thanks for the recommendation, Andre! I conferred with @valerio.bozzolan and he agrees, too. I have updated the patch.

Sun, May 5, 10:57 · UX
waldyrious updated the diff for D25419: Fix the whitespace issue in the message "Access Denied: Restricted File".
  • Use phutil_implode_html() instead of implode()
Sun, May 5, 10:56 · UX
valerio.bozzolan awarded T15813: Being subscribed by others should generate a notification a Like token.
Sun, May 5, 01:10 · Bug Reports

Sat, May 4

waldyrious created T15813: Being subscribed by others should generate a notification.
Sat, May 4, 23:48 · Bug Reports

Apr 25 2024

waldyrious removed a watcher for Affects-Wikimedia: waldyrious.
Apr 25 2024, 22:07

Dec 21 2023

waldyrious added a comment to D25419: Fix the whitespace issue in the message "Access Denied: Restricted File".

That's so weird! My instinct is of course to say that it should be completely unrelated to this patch since no CSS is touched in this one-line change... I have no idea how to debug this ☹️

Dec 21 2023, 22:57 · UX

Dec 15 2023

waldyrious added a project to T15270: "Access Denied: Restricted File" strings concatenated without whitespace: UX.
Dec 15 2023, 08:49 · UX, Good Starter Task, Files
waldyrious added a project to D25419: Fix the whitespace issue in the message "Access Denied: Restricted File": UX.
Dec 15 2023, 08:48 · UX
waldyrious added a comment to D25419: Fix the whitespace issue in the message "Access Denied: Restricted File".

Thanks for the note, Andre! I've went ahead and updated the revision as discussed above.

Dec 15 2023, 08:43 · UX
waldyrious updated the diff for D25419: Fix the whitespace issue in the message "Access Denied: Restricted File".
  • Add spaces in HTML message builder instead of to each item text
Dec 15 2023, 08:42 · UX

Dec 7 2023

waldyrious closed D25466: Improve command line prompts in setup issue pages.
Dec 7 2023, 16:22 · Config, UX
waldyrious committed rPc49eeb235ea0: Improve command line prompts in setup issue pages.
Improve command line prompts in setup issue pages
Dec 7 2023, 16:22

Dec 6 2023

waldyrious closed D25485: CSS adjustments to Conpherence.
Dec 6 2023, 15:36 · Conpherence
waldyrious committed rPe59702569f8e: CSS adjustments to Conpherence.
CSS adjustments to Conpherence
Dec 6 2023, 15:36
waldyrious added a comment to D25485: CSS adjustments to Conpherence.

Thanks both! I'll land this, then.

Dec 6 2023, 15:32 · Conpherence

Dec 3 2023

waldyrious added a comment to D25485: CSS adjustments to Conpherence.
In D25485#14022, @speck wrote:

I was thinking we might want to better enable multi-line messages and remove the Enter = submit for both desktop and mobile (on mobile making a send button like most other chat apps).

Dec 3 2023, 22:15 · Conpherence

Dec 2 2023

waldyrious added a comment to T15225: Conpherence: add a dedicated "Send" button (not just the Enter key).

It's also misleading that the text box is multiline (at least in desktop) which suggests that line breaks are expected, but pressing Enter instead sends the message.

Dec 2 2023, 10:42 · Conpherence, Mobile, User-valerio.bozzolan, UX
waldyrious added a project to D25485: CSS adjustments to Conpherence: Conpherence.
Dec 2 2023, 10:40 · Conpherence
waldyrious updated the summary of D25485: CSS adjustments to Conpherence.
Dec 2 2023, 10:38 · Conpherence
waldyrious updated the summary of D25485: CSS adjustments to Conpherence.
Dec 2 2023, 10:34 · Conpherence
valerio.bozzolan awarded D25485: CSS adjustments to Conpherence a Love token.
Dec 2 2023, 10:27 · Conpherence
waldyrious requested review of D25485: CSS adjustments to Conpherence.
Dec 2 2023, 10:25 · Conpherence

Nov 29 2023

waldyrious added a project to D25191: Auto-subscription: little less verbose: UX.
Nov 29 2023, 11:54 · UX

Nov 20 2023

waldyrious renamed Why Migrate from Phabricator to Phorge from Why Migrating from Phabricator to Phorge to Why Migrate from Phabricator to Phorge.
Nov 20 2023, 11:38

Nov 18 2023

waldyrious closed D25473: Change some instances of "phabricator" to "phorge".
Nov 18 2023, 22:14
waldyrious committed rPa741f5d65c10: Change some instances of "phabricator" to "phorge".
Change some instances of "phabricator" to "phorge"
Nov 18 2023, 22:14
waldyrious added inline comments to D25473: Change some instances of "phabricator" to "phorge".
Nov 18 2023, 08:59
waldyrious updated the diff for D25473: Change some instances of "phabricator" to "phorge".
  • Remove extra <tt> in bulk job dialog
Nov 18 2023, 08:57
waldyrious added a comment to D25473: Change some instances of "phabricator" to "phorge".

So this is the only blocking Test that is failing:

Visit /maniphest/, shift+click on at least 1 Task, click on Bulk Edit Selected, Continue, see the popup

Nov 18 2023, 08:55

Nov 14 2023

waldyrious updated the task description for T15644: Support backticks in inline and block code by wrapping with multiple backticks.
Nov 14 2023, 14:47 · Feature Requests, Remarkup
waldyrious updated the task description for T15290: vscode extension for working on phorge codebase.
Nov 14 2023, 14:44 · Phorge Development Tools, Phactory: Community Projects
waldyrious added projects to D25466: Improve command line prompts in setup issue pages: UX, Config.
Nov 14 2023, 14:40 · Config, UX
waldyrious updated the diff for D25473: Change some instances of "phabricator" to "phorge".
  • Use dynamically generated platform path where possible
Nov 14 2023, 14:37
waldyrious added inline comments to D25473: Change some instances of "phabricator" to "phorge".
Nov 14 2023, 14:28
waldyrious added a comment to D25466: Improve command line prompts in setup issue pages.

Btw, there are some similar commands in src/applications/config/check/PhabricatorManualActivitySetupCheck.php. Should I change them as well? How can I "break Phorge" to see this page rendered?

Nov 14 2023, 12:24 · Config, UX
waldyrious requested review of D25473: Change some instances of "phabricator" to "phorge".
Nov 14 2023, 12:12
waldyrious updated the test plan for D25466: Improve command line prompts in setup issue pages.
Nov 14 2023, 11:50 · Config, UX
waldyrious updated the diff for D25466: Improve command line prompts in setup issue pages.
  • Actually the path is not needed here.
Nov 14 2023, 11:47 · Config, UX
waldyrious updated the diff for D25466: Improve command line prompts in setup issue pages.
  • Fix missing arguments to hsprintf; re-add csprintf to string using the %R conversion
Nov 14 2023, 11:46 · Config, UX
waldyrious updated the diff for D25466: Improve command line prompts in setup issue pages.
  • Improve prompts: use hsprintf instead of cprintf, add missing <tt> markers, simplify syntax
Nov 14 2023, 11:40 · Config, UX
waldyrious attached a referenced file: F397870: image.png.
Nov 14 2023, 11:36 · Config, UX
waldyrious added a comment to D25466: Improve command line prompts in setup issue pages.

For future reference, I went digging for the difference between csprintf() and hsprintf(), and found the following:

Nov 14 2023, 11:36 · Config, UX

Nov 13 2023

waldyrious updated the diff for D25466: Improve command line prompts in setup issue pages.
  • Fix double prompt marker
Nov 13 2023, 23:30 · Config, UX
waldyrious added inline comments to D25466: Improve command line prompts in setup issue pages.
Nov 13 2023, 23:28 · Config, UX
waldyrious added a comment to D25466: Improve command line prompts in setup issue pages.

Nice catches, @valerio.bozzolan — will fix.

Nov 13 2023, 23:23 · Config, UX

Nov 12 2023

waldyrious closed D25465: Fix loop in contribution docs.
Nov 12 2023, 21:07
waldyrious committed rP296ce3956b81: Fix loop in contribution docs.
Fix loop in contribution docs
Nov 12 2023, 21:07
waldyrious updated the diff for D25465: Fix loop in contribution docs.
  • Wrap long line
Nov 12 2023, 20:55
waldyrious added inline comments to D25465: Fix loop in contribution docs.
Nov 12 2023, 20:52
waldyrious updated the diff for D25465: Fix loop in contribution docs.
  • Rephrase Next Steps entry
Nov 12 2023, 20:52

Nov 11 2023

waldyrious added inline comments to D25465: Fix loop in contribution docs.
Nov 11 2023, 23:58
waldyrious added a comment to D25466: Improve command line prompts in setup issue pages.

I am not sure about all these changes. In particular, the changes in PhabricatorSetupIssueUIExample.php and PhabricatorSetupIssueView.php probably warrant extra scrutiny.

Nov 11 2023, 13:08 · Config, UX
waldyrious updated the diff for D25466: Improve command line prompts in setup issue pages.
  • Update the resources map
Nov 11 2023, 12:57 · Config, UX
waldyrious updated the test plan for D25466: Improve command line prompts in setup issue pages.
Nov 11 2023, 12:56 · Config, UX
waldyrious updated the summary of D25466: Improve command line prompts in setup issue pages.
Nov 11 2023, 12:55 · Config, UX
waldyrious updated the test plan for D25466: Improve command line prompts in setup issue pages.
Nov 11 2023, 12:54 · Config, UX
waldyrious requested review of D25466: Improve command line prompts in setup issue pages.
Nov 11 2023, 12:50 · Config, UX
waldyrious updated the summary of D25465: Fix loop in contribution docs.
Nov 11 2023, 11:16
waldyrious requested review of D25465: Fix loop in contribution docs.
Nov 11 2023, 11:14

Nov 10 2023

waldyrious added a watcher for Remarkup: waldyrious.
Nov 10 2023, 09:17
waldyrious closed D25425: Remove mention of Phabricator in the Auth setup check.
Nov 10 2023, 09:13
waldyrious committed rP0729aa574bfd: Remove mention of Phabricator in the Auth setup check.
Remove mention of Phabricator in the Auth setup check
Nov 10 2023, 09:13
waldyrious closed D25458: Adjust message in timezone conflict form.
Nov 10 2023, 09:03
waldyrious committed rP8092d90c79fc: Adjust message in timezone conflict form.
Adjust message in timezone conflict form
Nov 10 2023, 09:03

Nov 9 2023

waldyrious created P25 arc land error.
Nov 9 2023, 22:55
waldyrious added a comment to D25425: Remove mention of Phabricator in the Auth setup check.

the prefix was added to have arcanist/phorge indication. So, if we use just $ it's better to remove it.

Nov 9 2023, 01:08
waldyrious updated the diff for D25458: Adjust message in timezone conflict form.
  • Adjust message per code review suggestion
Nov 9 2023, 00:52
waldyrious added inline comments to D25458: Adjust message in timezone conflict form.
Nov 9 2023, 00:49

Nov 8 2023

aklapper awarded D25458: Adjust message in timezone conflict form a Love token.
Nov 8 2023, 08:00

Nov 7 2023

waldyrious updated the diff for D25425: Remove mention of Phabricator in the Auth setup check.

Revert indentation changes

Nov 7 2023, 16:49
waldyrious requested review of D25458: Adjust message in timezone conflict form.
Nov 7 2023, 15:59

Sep 30 2023

waldyrious awarded T15535: Using Differential with plain Git, without requiring Arc a Love token.
Sep 30 2023, 14:12 · Feature Requests

Sep 24 2023

waldyrious added a comment to D25419: Fix the whitespace issue in the message "Access Denied: Restricted File".

Should I go ahead and submit a different patch? Or could I somehow contribute the edit to this patch?

Sep 24 2023, 09:14 · UX
waldyrious updated the title for P23 xhpast error from xhpast error (two commands and their output) to xhpast error.
Sep 24 2023, 09:11
waldyrious created P23 xhpast error.
Sep 24 2023, 09:08

Sep 23 2023

waldyrious added inline comments to D25425: Remove mention of Phabricator in the Auth setup check.
Sep 23 2023, 14:29
waldyrious added a comment to D25419: Fix the whitespace issue in the message "Access Denied: Restricted File".

The value of moreInfo here is a list (array) of 3 things, (https://we.phorge.it/source/phorge/browse/master/src/applications/policy/filter/PhabricatorPolicyFilter.php;4f845d8f8c77$702) - $head, $more and $exceptions, and I'm guessing from context that the appendList() creates one <ul> for the list and one <li> for each item in the list - so $exceptions at this point is a single thing.

Sep 23 2023, 13:56 · UX

Sep 22 2023

waldyrious added a comment to T15270: "Access Denied: Restricted File" strings concatenated without whitespace.

For others reading this thread: there's some discussion going on in the thread of the patch linked above, D25419.

Sep 22 2023, 22:26 · UX, Good Starter Task, Files
waldyrious updated the task description for T15644: Support backticks in inline and block code by wrapping with multiple backticks.
Sep 22 2023, 22:22 · Feature Requests, Remarkup
waldyrious created T15644: Support backticks in inline and block code by wrapping with multiple backticks.
Sep 22 2023, 22:17 · Feature Requests, Remarkup
waldyrious added a comment to T15643: Support marking text with <ins> in Remarkup.

Note: the <ins> tag is typically rendered as underlined text, so this would be very similar to the <u> formatting that is produced with __foobar__foobar. In fact, it might be worth repurposing that rule to produce <ins> instead, since ~~foobar~~ actually creates a semantic <del> tag rather than the presentational equivalent <s> (strikethrough) tag.

Sep 22 2023, 21:58 · Feature Requests, Remarkup
waldyrious created T15643: Support marking text with <ins> in Remarkup.
Sep 22 2023, 21:47 · Feature Requests, Remarkup
waldyrious added a comment to T15245: Continue bulleted/numbered list during new line.

Ugh. I added this to the UX project but forgot to remove the test content from the comment box, so my changes ended up coupled with a comment that said "- List Item". I tried to delete the comment but now it looks weird like some sort of redacted content :( anway, though I'd leave the note here in case anyone is confused with the deleted comment.

Sep 22 2023, 21:36 · UX, Feature Requests, Remarkup
waldyrious added a project to T15245: Continue bulleted/numbered list during new line: UX.
Sep 22 2023, 21:34 · UX, Feature Requests, Remarkup
waldyrious awarded T15245: Continue bulleted/numbered list during new line a Like token.
Sep 22 2023, 21:33 · UX, Feature Requests, Remarkup
waldyrious added a comment to T15225: Conpherence: add a dedicated "Send" button (not just the Enter key).

It's also misleading that the text box is multiline (at least in desktop) which suggests that line breaks are expected, but pressing Enter instead sends the message. I was caught off-guard by this at least once. So perhaps the text entry box should be made single-line by default (as already happens if the screen is narrow enough) and expand as needed if line breaks are added.

Sep 22 2023, 21:29 · Conpherence, Mobile, User-valerio.bozzolan, UX
waldyrious added a comment to D25419: Fix the whitespace issue in the message "Access Denied: Restricted File".

@valerio.bozzolan I actually think the right place to look at the usage of getSpecialRules() might be here: https://we.phorge.it/source/phorge/browse/master/src/applications/policy/filter/PhabricatorPolicyFilter.php;4f845d8f8c77$693-719

Sep 22 2023, 21:25 · UX
waldyrious awarded T15270: "Access Denied: Restricted File" strings concatenated without whitespace a Like token.
Sep 22 2023, 20:38 · UX, Good Starter Task, Files
waldyrious added a watcher for GitHub: waldyrious.
Sep 22 2023, 20:37
waldyrious awarded T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge a Like token.
Sep 22 2023, 20:35 · Discussion Needed, Affects-Wikimedia
waldyrious added a watcher for Affects-Wikimedia: waldyrious.
Sep 22 2023, 20:34
waldyrious added a comment to T15510: Make email clear about "Someone accepted revision" vs "Revision is ready to land".

By the way, is there a task or project about UI text improvements that this task could be made part of? I am looking e.g. at the button in this very comment box saying "Set Sail for Adventure", which, while amusing, is also prone to cause confusion.

Sep 22 2023, 20:30 · UX, Differential
waldyrious added a comment to T15510: Make email clear about "Someone accepted revision" vs "Revision is ready to land".

How about something like "Endorse"? That might remove the connotations of speaking for the project position that something like "approve" or "accept" may imply.

Sep 22 2023, 20:28 · UX, Differential
waldyrious awarded T15510: Make email clear about "Someone accepted revision" vs "Revision is ready to land" a Like token.
Sep 22 2023, 20:23 · UX, Differential

Sep 20 2023

waldyrious accepted D25066: Workboard: Milestone Name easily editable (instead of surfing 3 pages).

Tested locally, works as advertised.

Sep 20 2023, 11:32

Aug 31 2023

waldyrious accepted D25413: Show a link to the Phorge homepage.

LGTM! :D

Aug 31 2023, 20:32

Aug 30 2023

waldyrious added a comment to D25413: Show a link to the Phorge homepage.

Yeah, that's nice! Though I'd replace the ! at the end with a :, and would remove the horizontal ruler (while keeping the new paragraph for the we.phorge.it link). This way it is clear that the last line is a continuation of the previous one; otherwise, it may not be immediately clear how one is supposed to "join the community".

Aug 30 2023, 18:46