Page MenuHomePhorge
Feed All Stories

Apr 23 2025

aklapper committed rPe31c3041faec: PHPDoc: Replace invalid "obj" with "object".
Apr 23 2025, 14:37
20after4 awarded rARC4db5dc25e4e8: PHPDoc: Replace invalid "obj" with "object" a Mountain of Wealth token.
Apr 23 2025, 14:37
aklapper closed D25951: PHPDoc: Replace invalid "obj" with "object".
Apr 23 2025, 14:36
aklapper committed rARC4db5dc25e4e8: PHPDoc: Replace invalid "obj" with "object".
Apr 23 2025, 14:36
20after4 closed T15961: Should we adopt modern PHP type hints in Phorge source code? as Resolved.
Apr 23 2025, 14:34Phorge Development Tools, Discussion Needed
valerio.bozzolan moved T16042: Embedded videos are disproportionately huge from Backlog to Feature Requests on the Remarkup board.

P.S. I wonder... what happens if we expose the width/height here. But probably just touching that would be enough. Still, patch welcome 馃憤

Apr 23 2025, 13:45User-valerio.bozzolan, Feature Requests, Remarkup
valerio.bozzolan added projects to T16042: Embedded videos are disproportionately huge: Feature Requests, User-valerio.bozzolan.

Thanks. Yes. I can reproduce. Relevant documentation:

Apr 23 2025, 13:40User-valerio.bozzolan, Feature Requests, Remarkup
Daimona created T16042: Embedded videos are disproportionately huge.
Apr 23 2025, 13:28User-valerio.bozzolan, Feature Requests, Remarkup
valerio.bozzolan added a comment to T15961: Should we adopt modern PHP type hints in Phorge source code?.

Thaanks @20after4 - I would say: be bold and mark as resolved to get eternal glory 馃憤 half year of discussion is probably enough and everybody seems happy about this.

Apr 23 2025, 13:20Phorge Development Tools, Discussion Needed
Daimona awarded T15048: Allow awarding Tokens to individual Comments a Love token.
Apr 23 2025, 13:09Comments
Daimona awarded T15202: Show confirmation dialog also when closing tab if content changed a Yellow Medal token.
Apr 23 2025, 13:07Wikimedia Hackathon 2025, Maniphest, User-valerio.bozzolan, UX
valerio.bozzolan accepted D25953: PHPDoc: Replace invalid "key" and "value" types.

yesyes

Apr 23 2025, 13:05
valerio.bozzolan accepted D25951: PHPDoc: Replace invalid "obj" with "object".

yesyes

Apr 23 2025, 13:04
valerio.bozzolan accepted D25952: PHPDoc: Replace invalid "obj" with "object".

yesyes

Apr 23 2025, 13:03
valerio.bozzolan accepted D25954: PHPDoc: Correct marker in one class header.

yesyes

Apr 23 2025, 13:03
valerio.bozzolan accepted D25958: PHPDoc: Fix @return string for methods which can also return null.

yesyes

Apr 23 2025, 13:02
valerio.bozzolan added a comment to D25772: Projects: improve quality of destroy workflow.

Hi @mainframe98 - I still see your block. Do you like the new documentation now? 馃憤

Apr 23 2025, 12:57Projects
valerio.bozzolan added a member for Trusted Contributors: Daimona.
Apr 23 2025, 12:38
valerio.bozzolan updated the task description for T16041: Harbormaster Build Plan: improve input "Depends On".
Apr 23 2025, 12:16User-valerio.bozzolan, UX, Feature Requests, Almanac/Drydock/Harbormaster
valerio.bozzolan changed the visibility for F3675059: Harbormaster Build Plan - Depends On field - highlight meme.jpg.
Apr 23 2025, 12:15
valerio.bozzolan added a cover image to T16041: Harbormaster Build Plan: improve input "Depends On".
Apr 23 2025, 12:15User-valerio.bozzolan, UX, Feature Requests, Almanac/Drydock/Harbormaster
valerio.bozzolan created T16041: Harbormaster Build Plan: improve input "Depends On".
Apr 23 2025, 12:11User-valerio.bozzolan, UX, Feature Requests, Almanac/Drydock/Harbormaster
valerio.bozzolan added inline comments to D25968: Mail Notifications: Do not CC disabled user accounts.
Apr 23 2025, 07:12
20after4 updated the answer wiki for Q175: Instant messaging not working, disconnected.
Apr 23 2025, 06:33
20after4 added a comment to Q175: Instant messaging not working, disconnected.
Apr 23 2025, 06:32
valerio.bozzolan updated the answer wiki for Q175: Instant messaging not working, disconnected.
Apr 23 2025, 06:10

Apr 22 2025

connorgurney added a project to T15018: Make Harbormaster more generally usable and extendable: Connor Gurney.
Apr 22 2025, 23:46Connor Gurney, Almanac/Drydock/Harbormaster
connorgurney updated the answer wiki for Q175: Instant messaging not working, disconnected.
Apr 22 2025, 23:35
connorgurney created Connor Gurney.
Apr 22 2025, 23:34
connorgurney added a comment to T16040: Regression: Sending a message in Conpherence rooms opens dialog to edit room.

This project is now abandonware without you. 馃槅

Apr 22 2025, 15:31UX, Bug Reports, Aphlict, Conpherence
valerio.bozzolan updated the task description for T15513: Cannot edit Conpherence rooms on mobile.
Apr 22 2025, 15:30User-Cigaryno, Mobile, Conpherence, Bug Reports
valerio.bozzolan added a comment to T16040: Regression: Sending a message in Conpherence rooms opens dialog to edit room.

Gents, you鈥檙e both nothing short of geniuses

Apr 22 2025, 15:20UX, Bug Reports, Aphlict, Conpherence
connorgurney added a comment to T16040: Regression: Sending a message in Conpherence rooms opens dialog to edit room.

Gents, you鈥檙e both nothing short of geniuses鈥攆ixed before I鈥檇 even blinked! Thanks. Will look at fixing it permanently in T15513.

Apr 22 2025, 14:16UX, Bug Reports, Aphlict, Conpherence
aklapper placed T15513: Cannot edit Conpherence rooms on mobile up for grabs.

Fix was reverted for now as it had bad side effects.

Apr 22 2025, 13:17User-Cigaryno, Mobile, Conpherence, Bug Reports
aklapper reopened T15513: Cannot edit Conpherence rooms on mobile as Open by committing rPcadc00d744eb: Revert "Fix editing Conpherence rooms on mobile".
Apr 22 2025, 13:16User-Cigaryno, Mobile, Conpherence, Bug Reports
aklapper closed T16040: Regression: Sending a message in Conpherence rooms opens dialog to edit room as Resolved by committing rPcadc00d744eb: Revert "Fix editing Conpherence rooms on mobile".
Apr 22 2025, 13:16UX, Bug Reports, Aphlict, Conpherence
aklapper closed D25969: Revert "Fix editing Conpherence rooms on mobile".
Apr 22 2025, 13:16
aklapper added a reverting change for D25879: Fix editing Conpherence rooms on mobile: rPcadc00d744eb: Revert "Fix editing Conpherence rooms on mobile".
Apr 22 2025, 13:16
aklapper committed rPcadc00d744eb: Revert "Fix editing Conpherence rooms on mobile".
Apr 22 2025, 13:16
aklapper added a reverting change for rPfd6118bfa601: Fix editing Conpherence rooms on mobile: rPcadc00d744eb: Revert "Fix editing Conpherence rooms on mobile".
Apr 22 2025, 13:16
valerio.bozzolan accepted D25969: Revert "Fix editing Conpherence rooms on mobile".

Oh boy. Thanks

Apr 22 2025, 12:57
valerio.bozzolan updated the test plan for D25969: Revert "Fix editing Conpherence rooms on mobile".
Apr 22 2025, 12:57
aklapper requested review of D25969: Revert "Fix editing Conpherence rooms on mobile".
Apr 22 2025, 12:55
aklapper added a reverting change for D25879: Fix editing Conpherence rooms on mobile: D25969: Revert "Fix editing Conpherence rooms on mobile".
Apr 22 2025, 12:55
aklapper added a revision to T15513: Cannot edit Conpherence rooms on mobile: D25969: Revert "Fix editing Conpherence rooms on mobile".
Apr 22 2025, 12:55User-Cigaryno, Mobile, Conpherence, Bug Reports
aklapper added a revision to T16040: Regression: Sending a message in Conpherence rooms opens dialog to edit room: D25969: Revert "Fix editing Conpherence rooms on mobile".
Apr 22 2025, 12:55UX, Bug Reports, Aphlict, Conpherence
aklapper added a reverting change for rPfd6118bfa601: Fix editing Conpherence rooms on mobile: D25969: Revert "Fix editing Conpherence rooms on mobile".
Apr 22 2025, 12:55
aklapper renamed T16040: Regression: Sending a message in Conpherence rooms opens dialog to edit room from Fix bug with inability to take actions in Conpherence rooms as dialog to edit room appears instead to Regression: Sending a message in Conpherence rooms opens dialog to edit room.
Apr 22 2025, 12:55UX, Bug Reports, Aphlict, Conpherence
aklapper added a comment to T16040: Regression: Sending a message in Conpherence rooms opens dialog to edit room.

I can reproduce, looks like the change in src/applications/conpherence/controller/ConpherenceViewController.php is the culprit.
No clue what's a correct fix, thus proposing to revert the entire commit.

Apr 22 2025, 12:54UX, Bug Reports, Aphlict, Conpherence
valerio.bozzolan awarded Q177: Should it be easier for non-community-members to submit security reports? a Like token.
Apr 22 2025, 12:53Security
valerio.bozzolan added a comment to T16040: Regression: Sending a message in Conpherence rooms opens dialog to edit room.

Eventually please try reverting this change in your local copy:

Apr 22 2025, 12:32UX, Bug Reports, Aphlict, Conpherence
valerio.bozzolan added a comment to T16040: Regression: Sending a message in Conpherence rooms opens dialog to edit room.

Tip: activate DarkConsole and check requests there 馃憤

Apr 22 2025, 12:29UX, Bug Reports, Aphlict, Conpherence
connorgurney added a comment to Q178: What version of Phorge are we currently running on the community instance? (Answer 222).

Thanks! Appreciate the answer.

Apr 22 2025, 11:24
20after4 awarded Q177: Should it be easier for non-community-members to submit security reports? a Like token.
Apr 22 2025, 10:16Security
avivey added a comment to Q178: What version of Phorge are we currently running on the community instance? (Answer 222).

That's almost a year old. Time to update.

Apr 22 2025, 10:15
avivey closed Q178: What version of Phorge are we currently running on the community instance? as resolved.
Apr 22 2025, 10:14Blessed Roots
avivey added Q178: What version of Phorge are we currently running on the community instance? (Answer 222).
Apr 22 2025, 10:14
aklapper added a comment to Q178: What version of Phorge are we currently running on the community instance? (Answer 221).

Automagically deploying the latest unexpectedly faulty commit may make this instance unusable, thus likely not latest stable.

Apr 22 2025, 09:56
bekay added Q178: What version of Phorge are we currently running on the community instance? (Answer 221).
Apr 22 2025, 08:14
aklapper renamed T15824: Deprecation notice at PhabricatorEditorURIEngine.php:283 when no RepositorySlug set from Deprecation notice at PhabricatorEditorURIEngine.php:283 to Deprecation notice at PhabricatorEditorURIEngine.php:283 when no RepositorySlug set.
Apr 22 2025, 08:10PHP 8 support, Deprecation Notice
aklapper renamed T15829: Deprecation notice @ PhabricatorStandardPageView.php:630 (missing User-Agent HTTP Header) from Deprecation notice @ PhabricatorStandardPageView.php:630 to Deprecation notice @ PhabricatorStandardPageView.php:630 (missing User-Agent HTTP Header).
Apr 22 2025, 08:09PHP 8 support, Deprecation Notice
valerio.bozzolan lowered the priority of T15323: Add support for embedding Videos from Wikimedia Commons into Remarkup from Low to Wishlist.

Thanks. I also encourage in not following the mentioned implementation, and not only because they have problems with deleted files (interesting) but also because that solution is verticalized on Wikimedia Commons, and nowadays a "modern" embedder system should probably just use the OEmbed protocol that is quite flexible and would support out of the box an incredible amount of websites, potentially including Wikimedia Commons, with relatively few amount of code, than supporting every single website in the universe.

Apr 22 2025, 07:04Feature Requests, Remarkup, Affects-Wikimedia
connorgurney renamed T16040: Regression: Sending a message in Conpherence rooms opens dialog to edit room from Fix bug with inability to take actions in Conpherence rooms as modal to edit room appears instead to Fix bug with inability to take actions in Conpherence rooms as dialog to edit room appears instead.
Apr 22 2025, 01:31UX, Bug Reports, Aphlict, Conpherence
connorgurney added a comment to T16040: Regression: Sending a message in Conpherence rooms opens dialog to edit room.

From checking the network requests when I load an unrelated page and the dialog appears, I can see a POST request to /conpherence/edit/1/ which returns the dialog. I've attached both the request and the response, with light redactions, to P48 and P49.

Apr 22 2025, 01:30UX, Bug Reports, Aphlict, Conpherence
connorgurney created P49 HTTP response for dialog to edit Conpherence room in T16040.
Apr 22 2025, 01:29UX, Bug Reports, Aphlict, Conpherence
connorgurney created P48 HTTP request for modal to edit Conpherence room in T16040.
Apr 22 2025, 01:27UX, Bug Reports, Aphlict, Conpherence
connorgurney updated the question details for Q178: What version of Phorge are we currently running on the community instance?.
Apr 22 2025, 01:07Blessed Roots
connorgurney updated the task description for T16040: Regression: Sending a message in Conpherence rooms opens dialog to edit room.
Apr 22 2025, 01:07UX, Bug Reports, Aphlict, Conpherence
connorgurney claimed T16040: Regression: Sending a message in Conpherence rooms opens dialog to edit room.
Apr 22 2025, 01:06UX, Bug Reports, Aphlict, Conpherence
connorgurney created T16040: Regression: Sending a message in Conpherence rooms opens dialog to edit room.
Apr 22 2025, 01:05UX, Bug Reports, Aphlict, Conpherence
connorgurney updated the question details for Q178: What version of Phorge are we currently running on the community instance?.
Apr 22 2025, 00:55Blessed Roots
connorgurney asked Q178: What version of Phorge are we currently running on the community instance?.
Apr 22 2025, 00:55Blessed Roots

Apr 21 2025

connorgurney renamed T15989: `arc` commands: Constant E_STRICT is deprecated (with PHP 8.4) from `arc unit`: Constant E_STRICT is deprecated (with PHP 8.4) to `arc` commands: Constant E_STRICT is deprecated (with PHP 8.4).
Apr 21 2025, 23:50Deprecation Notice, PHP 8 support, Bug Reports
connorgurney added a comment to T15989: `arc` commands: Constant E_STRICT is deprecated (with PHP 8.4).

Can confirm that this appears on all commands rather than just unit, so have renamed the task accordingly.

Apr 21 2025, 23:50Deprecation Notice, PHP 8 support, Bug Reports
pppery added a project to T16031: Phriction: Invalid position actions sidebar when large image on top: Phriction.
Apr 21 2025, 22:40Phriction
pppery added a project to T16036: Feature Request: Add a Copy-to-Clipboard Button to code blocks: Remarkup.
Apr 21 2025, 22:38Remarkup
pppery added a project to T16037: Bump ws npm package for Aphlict: Aphlict.
Apr 21 2025, 22:37Security, Aphlict
pppery added a project to T16033: "To:" and "CC:" Recipient Hint footers in mail notifications list disabled user accounts: Mail.
Apr 21 2025, 22:37Mail
pppery added a member for Trusted Contributors: A_smart_kitten.
Apr 21 2025, 22:36
aklapper added a comment to D25968: Mail Notifications: Do not CC disabled user accounts.

I guess I should add a big This is untested banner here

Apr 21 2025, 19:59
aklapper updated the diff for D25968: Mail Notifications: Do not CC disabled user accounts.

Don't check twice for account status; already covered by query parameter

Apr 21 2025, 19:57
aklapper updated the diff for D25968: Mail Notifications: Do not CC disabled user accounts.

Clean my local dir from other experiments

Apr 21 2025, 19:55
aklapper requested review of D25968: Mail Notifications: Do not CC disabled user accounts.
Apr 21 2025, 19:51
aklapper added a revision to T16033: "To:" and "CC:" Recipient Hint footers in mail notifications list disabled user accounts: D25968: Mail Notifications: Do not CC disabled user accounts.
Apr 21 2025, 19:51Mail
connorgurney added a comment to T16039: Show image preview thumbnails on your Authored Files.

Triaged this as normal as I don鈥檛 think it鈥檚 anything urgent, but I personally love it - very helpful when you have lots of files! LGTM in principle.

Apr 21 2025, 14:47Feature Requests
connorgurney triaged T16039: Show image preview thumbnails on your Authored Files as Normal priority.
Apr 21 2025, 14:46Feature Requests
aklapper added a comment to T15056: Improve Dark Mode.

image.png (453脳298 px, 29 KB)

Apr 21 2025, 11:59User-Cigaryno, User-valerio.bozzolan, Accessibility, User-Bukkit
aklapper created T16039: Show image preview thumbnails on your Authored Files.
Apr 21 2025, 09:55Feature Requests
danielyepezgarces added a comment to T15056: Improve Dark Mode.

T391929 In that task on Wikimedia Phabricator, I had put some issues

image.png (453脳298 px, 29 KB)
image.png (264脳226 px, 13 KB)

Apr 21 2025, 01:15User-Cigaryno, User-valerio.bozzolan, Accessibility, User-Bukkit

Apr 20 2025

connorgurney added a comment to T15961: Should we adopt modern PHP type hints in Phorge source code?.

Very helpful - thanks!

Apr 20 2025, 16:39Phorge Development Tools, Discussion Needed
20after4 added a comment to T15961: Should we adopt modern PHP type hints in Phorge source code?.

I have already spent some time implementing types for a few of the widely used utility functions in rARC src/utils/utils.php (like id(), mpull(), newv(), etc..). I will make an effort to get it in shape and submit a diff for review in the near future.

Apr 20 2025, 16:20Phorge Development Tools, Discussion Needed
connorgurney attached a referenced file: F3604928: Screen Recording 2025-04-20 at 14.56.01.mov.
Apr 20 2025, 15:56
connorgurney added Q138: SAML 2.0 support (Answer 220).
Apr 20 2025, 15:55
connorgurney added Q177: Should it be easier for non-community-members to submit security reports? (Answer 219).
Apr 20 2025, 15:33
chris added a member for Trusted Contributors: connorgurney.
Apr 20 2025, 15:00
connorgurney added a comment to T15961: Should we adopt modern PHP type hints in Phorge source code?.

I see no reason not to pursue this. Does anyone else?

Apr 20 2025, 13:14Phorge Development Tools, Discussion Needed
connorgurney added a comment to Q175: Instant messaging not working, disconnected.

This has now been fixed by rPcadc00d744eb which reverts rPfd6118bfa601.

Apr 20 2025, 13:11

Apr 19 2025

xtex updated the task description for T16038: Add an endpoint for plain-text ssh keys.
Apr 19 2025, 14:08Auth, Phorge
xtex updated the task description for T16038: Add an endpoint for plain-text ssh keys.
Apr 19 2025, 00:35Auth, Phorge
xtex created T16038: Add an endpoint for plain-text ssh keys.
Apr 19 2025, 00:32Auth, Phorge