Tools make no mistakes.

Okay, got to wait until D25885 is merged first

Okay, got to wait until D25885 is merged first

Let's try again without celerity noise

I wonder what's wrong with my CSS/JS, sigh

As I uploaded a new diff now how do I request a new review / reset the existing one "Changes Requested"?
"Foist Upon", or which vaguely named oh so "funny" option from the "Add Action..." dropdown which makes non-native speakers feel stupid and be scared to choose the wrong option? Oh UX and usability...

having a portal with something useful (e.g. a Dashboard): shows the Dashboard

Remove first person voice in a few areas. And a bit of swearing that slipped through from my notes.

Run ./bin/celerity map

Rename function to override from parent class, as proposed by Valerio

Right, PhabricatorDashboardPortalProfileMenuEngine extends PhabricatorProfileMenuEngine so we can override newNoContentView()... that probably makes most sense, thanks

You have to check out an old version of the translations repo. You wrote the steps to reproduce at T15811, and they still reproduce without this patch and don't with it.

I'd love to see better steps to reproduce something somewhere. :-/ I cannot even find e.p.p. or epp. somewhere in the Finnish translations anymore...

I expanded the test plan a bit, still if there is more to add please also expand. This seems to work for me (phamous last words)

Fix unaligned elements by changing margin-left: -200px to -200px for div.phui-document-content and for full-size images

git rebase master

./bin/celerity map as this touches a JS file

@mturdus: Could you land this one please, or would you like any help? Thanks!

In D25859#23607, @aklapper wrote:

I took the liberty to edit the commit message a bit to make reproduction easier (handy URIs to test, plus include the error message which allows easier search).

@valerio.bozzolan: Would you like to give this a (hopefully) final review? TIA!

Setting Request Changes per the small review comments so far (as I am looking at https://we.phorge.it/differential/query/all/ and it helps to see correct statuses)

Thanks for the patch! I can confirm that after applying the patch, on PHP 8.3 I can successful create the initiative http://phorge.localhost/I4 (and I get an unrelated PHP 8.1 deprecation warning about strlen(): Passing null to parameter #1 in src/applications/fund/xaction/FundInitiativeDescriptionTransaction.php:19)

This is impressive, thanks for writing this up! I don't have enough expertise to comment on the "Edit Phases", however all in all this looks super helpful for technical understanding!

Confirming that this works as expected. I took the liberty to expand the commit message to also include the current error message.

With D25878 applied, dialog for folks who can use Herald:

I've deployed it (https://www.phorge.it/)

Knowing rHP will be replaced by R10, I will submit a patch to close this task.

You're fast. lol I approve because life is too short.

null as fast as possible

I'd like people to clone from GH less for the bandwidth and more for the availability - GH is more likely to be up then us.
Technically I guess GH might have an issue with that, but they probably won't notice anyway.

(Maybe also moving in line 316, before phutil_utf8_strtolower() and the regexes)

Errm yes, now for real

Short-circuit null check, as rightfully proposed by Valerio

With this I have a regression in /w/. Do you have too?

No, because people do not read. The "read-only mirror" Wikimedia and GNOME code repos on GitHub regularly receive pull requests because people do not read anything.

In D25874#23455, @aklapper wrote:

I'm a bit worried that people will create Pull Requests on Github after downloading from Github...
Apart from download speed, are there other reasons why to recommend an external service?

I'm a bit worried that people will create Pull Requests on Github after downloading from Github...
Apart from download speed, are there other reasons why to recommend an external service?