Do the easier and more obvious thing that Valerio proposed

Argh, right... That's why I love reviews! :D Thus also check for null.

In D25872#23861, @nib wrote:

@aklapper Would it make sense to move the branch-naming lines into a function in class ArcanistGitWorkEngine, since it the branch-naming is git-specific? E.g.

public function buildBranchName($task_ref) {
  $task_name = $task_ref->getName();
  // regex, preg_replace, trim, etc
  return $branch_name;
}

@aklapper Would it make sense to move the branch-naming lines into a function in class ArcanistGitWorkEngine, since it the branch-naming is git-specific? E.g.

Hopefully the latest change will work for you. Now it checks existing git branches matching "T12345*" and if any exist, it will git checkout the first one, else it will create it from the task name.
So that should allow you to change the task title, and to use arc work T12345 as many times as you want without error.

• Fix indents, adds emoji support, improve REGEX
• Detect existing branch for task

• Handles existing branches
• Fixes indents, adds emoji support, improves REGEX

Fixes error when invoking arc work 2nd time on task id

I don't know if anybody is supposed to run

Alright, even after calling ->withEpochInRange(null, null) this very code change (comparing null with null) works fine without a problem, so I'd not add that additional null check

Oh wait I totally misunderstood you, sigh

Uh, nice thought! Phorge accepts and handles correctly one or two parameters being null which I think is fine as-is, so I'd only check for switched parameters created by confused developers here.

Small question. Is it supposed to be used with null+null?

Maybe also just declaring $path = '' as default in 209

Ooops, indeed. Thanks for finding that. Abandoning in favor of D25869.

In D25363#18825, @aklapper wrote:

• Resulting E13 still shows "Private User 1" to "Private User 5" with no user matching - I don't think that is expected but I'm not sure we want to care as that is no regression?

I've tested this and I'm impressed. You probably have changed my life.

• Fixes indents, adds emoji support, improves REGEX

For consistency, I'm wondering whether to

• rename src/applications/people/menuitem/PhabricatorPeopleTasksProfileMenuItem.php to src/applications/people/menuitem/PhabricatorPeopleTasksAssignedProfileMenuItem.php,
• rename src/applications/people/controller/PhabricatorPeopleProfileTasksController.php to src/applications/people/controller/PhabricatorPeopleProfileTasksAssignedController.php,
• update const ITEM_TASKS = 'people.tasks' to const ITEM_TASKS_ASSIGNED = 'people.tasks.assigned;,
• update 'tasks/(?P<id>[1-9]\d*)/' =>'PhabricatorPeopleProfileTasksController' to 'tasks-assigned/(?P<id>[1-9]\d*)/' =>'PhabricatorPeopleProfileTasksAssignedController'

as there is more than one "task" thingie now?

In T15726#15399, @aklapper wrote:

Fund: Going to http://phorge.localhost/fund/create/ and creating a New Initiative anyway yields

EXCEPTION: (RuntimeException) Undefined array key "totalAsCurrency" at [<arcanist>/src/error/PhutilErrorHandler.php:273]

Gotcha. Any opinion on this?

Maybe duplicate patch, look for same title (I'm on mobile now)

This would absolutely be useful in both the personal and professional Phorge instances I admin :)

Yes, please!

In D25864#23737, @valerio.bozzolan wrote:

Question: in an ideal world would you love even more the same button, that "just" prefills the textarea?

@deric you should land this revision, right?
If you're having troubles, ask on Z1 for help or ask somebody else to land.

Eh, let's make this exit(0) as that's more consistent with existing calls in the Arcanist codebase

Thanks. I can confirm with PHP 8.4.4 after upgrading one of my machines.

Probably same game as T15679 somewhere in src/applications/phriction/controller/PhrictionMoveController.php

In T15990#20841, @aklapper wrote:

Which PHP version do you use?

Note that (clone $foo)->bar() is still invalid so you need to use id(clone $foo)->bar().

Finally something that can be tested using arc anoid - I guess?

Test plan works! Thanks :3

grep -r " id(" --include=*.php . | wc -l gives a whopping 11220 results.
Would we accept a patch if I cooked up one? :)

I fail to reproduce with PHP 8.3 with the given steps: ../arcanist/bin/arc diff --create --help prints the help as expected, with no error.
Which PHP version do you use?

Hi @nib - still thanks and you are welcome in updating this patch using something like this:

last cosmetic change on a title with extra "==="

Question: in an ideal world would you love even more the same button, that "just" prefills the textarea? That could be also probably done server-side, without JavaScript. That would help T15991 even more I think.

git rebase master

add missing comma

implement tips, simplify (thanks)

With full respect of Badges, I don't see how a business can build an empire on this Badges menu entry. Anyway, if your business feel tampered by having this moved down by some pixels, please propose a patch to introduce a better menu management for this, like project menu that is more flexible :3

Insert a tear to play again :3