Hi @jmeador would you appreciate an help to update this?

Double-slam-accept

Since init_metrics() is supposed to be never called, maybe we can continue to do not define it 🤔

Any additional tips for the test plan? Maybe hacker @20after4

Thanks! If you remember which parts of the interface you've already tested, feel free to mention in the Test Plan, so I can maybe help in testing other parts

Fix lint

In D25618#20068, @pppery wrote:

I think the behavior of not setting the timezone is probably correct, actually. GetFormattedDateFromParts below already constructs a date object again with the timezone set. So I think the timezone offset is being applied twice here.

(From reading the code, I don't have a means to test this)

And the date is read from the database so I don't think it can be malformed.

Interestingly, PhutilClassMapQuery supports a ->setFilterMethod('something'), but it seems over-complicated to me, since it's supposed to call $query->something() as filter using mfilter($query, 'something'). But, to do that in this way, we may want to add something in the parent class PhabricatorApplicationTransactionQuery - but this seems not needed at the moment and, moreover, I don't like its backend mfilter()...

Suggested meme for closing: "yesyes"

In T15100#18699, @aklapper wrote:

I'm not skilled enough to look into the bigger picture, however maybe the Edit Column dialog could have a third field apart from Name and Point Limit to also have Task Limit (or Card Limit?). Point Limit and Task Limit then must be mutually exclusive (do not allow to set both for a column, or even...board?), somehow.