Page MenuHomePhorge

Hovercards: Avoid "Undefined index: objectPHID" when passing bogus data
ClosedPublic

Authored by aklapper on Dec 5 2024, 22:38.
Tags
None
Referenced Files
F2880613: D25849.1737080403.diff
Thu, Jan 16, 02:20
F2875350: D25849.1736978919.diff
Tue, Jan 14, 22:08
F2875349: D25849.1736978917.diff
Tue, Jan 14, 22:08
F2875348: D25849.1736978915.diff
Tue, Jan 14, 22:08
F2875155: D25849.1736972307.diff
Tue, Jan 14, 20:18
F2875069: D25849.1736970054.diff
Tue, Jan 14, 19:40
F2866316: D25849.1736627082.diff
Fri, Jan 10, 20:24
F2866314: D25849.1736627046.diff
Fri, Jan 10, 20:24

Details

Summary

Do not throw an exception when passing bogus parameters to hovercards but properly handle the missing array index by setting $object_phid to null.
In consequence, see a proper hovercard correctly displaying Unknown Object (????) instead of an exception.

Closes T15969

Test Plan

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

aklapper requested review of this revision.Dec 5 2024, 22:38

Thaaanks - If I'm not wrong we can = idx($card, 'objectPHID');

This revision is now accepted and ready to land.Dec 5 2024, 22:57

Right... one day I may get used to all those Phorge shortcuts, thanks