Page MenuHomePhorge

Unit test PhabricatorAuthInviteTestCase::testDuplicateInvite fails
Closed, ResolvedPublic

Description

Running arc unit --everything on a PHP 8.3 system, I get this failure:

   PASS   1.4s   PhabricatorAuthInviteTestCase::testDuplicateInvite
[2024-12-05 17:17:51] ERROR 8192: Implicit conversion from float 126.05500888824463 to int loses precision at [/var/www/html/phorge/arcanist/src/unit/renderer/ArcanistUnitConsoleRenderer.php:86]
arcanist(head=master, ref.master=29ca3df1122b), phorge(head=master, ref.master=48fd3f1c40de)
  #0 ArcanistUnitConsoleRenderer::formatTime(double) called at [<arcanist>/src/unit/renderer/ArcanistUnitConsoleRenderer.php:73]
  #1 ArcanistUnitConsoleRenderer::formatTestDuration(double) called at [<arcanist>/src/unit/renderer/ArcanistUnitConsoleRenderer.php:10]
  #2 ArcanistUnitConsoleRenderer::renderUnitResult(ArcanistUnitTestResult) called at [<arcanist>/src/unit/engine/phutil/PhutilTestCase.php:601]
  #3 PhutilTestCase::resultTest(string, string) called at [<arcanist>/src/unit/engine/phutil/PhutilTestCase.php:571]
  #4 PhutilTestCase::passTest(string) called at [<arcanist>/src/unit/engine/phutil/PhutilTestCase.php:640]
  #5 PhutilTestCase::run() called at [<arcanist>/src/unit/engine/PhutilUnitTestEngine.php:69]
  #6 PhutilUnitTestEngine::run() called at [<arcanist>/src/unit/engine/ArcanistConfigurationDrivenUnitTestEngine.php:148]
  #7 ArcanistConfigurationDrivenUnitTestEngine::run() called at [<arcanist>/src/workflow/ArcanistUnitWorkflow.php:170]
  #8 ArcanistUnitWorkflow::run() called at [<arcanist>/scripts/arcanist.php:427]

Per https://php.watch/versions/8.1/deprecate-implicit-conversion-incompatible-float-string we need to explicitly cast via (int).

Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.