Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15595: PHP 8.2 "strlen() null exception" when using the top bar search tool

Commits

rPeb2be08f9f0e: Fix PHP 8.1/8.2 "strlen(null)" exception in SearchController

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

EXCEPTION: (RuntimeException) strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [<arcanist>/src/error/PhutilErrorHandler.php:261];
PHP message: arcanist(head=master, ref.master=6e4947b55f09), phorge(head=master, ref.master=7bebfa289aa1);
PHP message: #0 <#2> PhutilErrorHandler::handleError(integer, string, string, integer) called at [<phorge>/src/applications/search/controller/PhabricatorSearchController.php:16];

Fix T15595

Test Plan

Search something using the main search bar. It should return something (or not) instead to throwing a RuntimeException.

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bob created this revision.Aug 8 2023, 08:41

Owners added a reviewer: O1: Blessed Committers.Aug 8 2023, 08:41

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptAug 8 2023, 08:41

bob requested review of this revision.Aug 8 2023, 08:41

Harbormaster completed remote builds in B734: Diff 1214.Aug 8 2023, 08:42

bob mentioned this in Q70: PHP 8.2 bug report "strlen() null exception" when using the top bar search tool (Answer 95).Aug 8 2023, 08:43

valerio.bozzolan awarded a token.Aug 8 2023, 08:52

bob updated this revision to Diff 1215.Aug 9 2023, 15:22

This comment was removed by bob.

Harbormaster completed remote builds in B735: Diff 1215.Aug 9 2023, 15:22

bob updated this revision to Diff 1216.Aug 9 2023, 15:33

bob updated this revision to Diff 1217.Aug 9 2023, 15:38

Sorry for the noise on this diff, I did something wrong during another diff creation procedure (I'm not an arcanist pro since I don't use it in my professional workflow).

Thanks bob! Ready to land

I tested this putting a phplog() in line 15 and using various search pages and I can confirm that the test plan is correct, and this only affects the main search bar, to me.

The only involved values are NULL or a string, and any other thing will trigger our violent screaming system crashing the planet, and we like that.

sgtm

This revision is now accepted and ready to land.Aug 10 2023, 07:32

Great news, thanks for your review valerio !

Closed by commit rPeb2be08f9f0e: Fix PHP 8.1/8.2 "strlen(null)" exception in SearchController. · Explain WhyAug 10 2023, 15:42

This revision was automatically updated to reflect the committed changes.

bob added a commit: rPeb2be08f9f0e: Fix PHP 8.1/8.2 "strlen(null)" exception in SearchController.

Fix PHP 8.1/8.2 "strlen(null)" exception in SearchController
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 1223

src/applications/search/controller/PhabricatorSearchController.php

Fix PHP 8.1/8.2 "strlen(null)" exception in SearchControllerClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 1223

src/applications/search/controller/PhabricatorSearchController.php

Fix PHP 8.1/8.2 "strlen(null)" exception in SearchController
ClosedPublic
Actions

Revision Contents
Changeset List