I'm pretty fine with DCO (which I already do every commit via the git commit -s command) — but I'd rather not sign a CLA. (I’m pretty undecided if I will sign phorge's CLA, but phorge is not commercial entity seeking to mongodb/terraform/elasticsearch-ize the software (read: make a profit from open source, then turn it into All Rights Reserved) so I might do so… after all these incidents I'm rather wary of it.)

Garr, I did not branch.

@20after4: Willing to share some code at some point that folks can poke or play with? :) TIA!

Thanks asd

Valerio may have a point here :D

I'm stupid and should have really checked the commit history first. Sorry!

Uh thanks, I had no idea where the upstream is, good to know because there are a few more issues. :)

shot at line 1162

Thanks :3 Hoping to be useful I will amend with a minimal sed -i 's/QRbitrtream/QRbitstream/' externals/phpqrcode/phpqrcode.php

I tested this with the following snippet:

Thanks :3 It makes sense, and I've also tested that snippet in PHP 5.5 and PHP 8.1 obtaining same results (premising that each() is not available anymore in PHP 8 as already clarified)

It was probably confused with the internal API executeRemovePath

Uh? It seems in use to me, in legacy lines 142, 145, 154, 155, etc.

Uh! I like this.

Probably OK now

Hmm, I also found this mentioned in https://secure.phabricator.com/T12404#256288 proposing a slightly different approach.

Indentation is awesome

Improvicate some things that valerio mentioned. (I prefer "Average" to "Normal" though; I consider "normal" a problematic term in this context.)

It's line 1162. Sorry for the line-ending collision noise, ./bin/arc diff did not want to accept my --ignore-cr-at-eol.