Thanks again for this patch that highlighted the valley and the mountain in a very clear way.

In D25608#17388, @avivey wrote:

This is probably the right fix (or maybe moving shouldAllowPublic() to the base PhabricatorFactController).

This is probably the right fix (or maybe moving shouldAllowPublic() to the base PhabricatorFactController).

After a small database inspection, it seems that uploading the picture causes:

I'm currently stuck on this since I'm trying to refactor the functions to support an indications about "I work for everybody" and "I work for only logged-in users" to be able to distinguish the case "The token exists" VS "The token exists but it's not visible" VS "The token does not exist"

Thanks to @waldyrious for the change. Tested. It works.

Thanks for the recommendation, Andre! I conferred with @valerio.bozzolan and he agrees, too. I have updated the patch.

• Use phutil_implode_html() instead of implode()

(Per my last comment)

I can reproduce but the title is so generic that makes this not actionable.

I guess that would imply editing 15-20 *ConduitAPIMethod.php files which currently

$limit = $request->getValue('limit');
if (!$limit) {
  $limit = $this->getDefaultLimit();
}

and add something like

if (!is_int($limit) && !ctype_digit($limit)) {
  throw new Exception(pht('Field "limit" must be an integer value.'));
}

? Hmm.

That's because we applied D25415

Cannot reproduce anymore / fixed?

Lol. I don't know what we should do here. Feel free to wontfix. Probably this is the solution to an unclear issue.

In D25619#17360, @speck wrote:

Ah, yes thank you for the video. I should have clarified but was asking for screenies of the result after this change. The changes look reasonable but I’m not a regular css user

Ah, yes thank you for the video. I should have clarified but was asking for screenies of the result after this change. The changes look reasonable but I’m not a regular css user

@speck here you can see the described overflowing:

Test for feed: https://we.phorge.it/source/phorge/browse/master/src/view/layout/AphrontSideNavFilterView.php

All described here with screenshot (and now video): T15809

screenies?

Should the conduit handler also check this and throw an exception? Doing so will send back a more informative error to the caller. I did some of this in https://secure.phabricator.com/D21872

Haven't tested yet, I was just trying to document the patch behavior.

Just a question. Does it work for you? Since locally, {#FA8072} still does not work for me.

Thanks!

Add return value (though it seems to make no difference)

Root problem is the https://we.phorge.it/source/phorge/browse/master/src/view/layout/AphrontSideNavFilterView.php with its styles: https://we.phorge.it/source/phorge/browse/master/webroot/rsrc/css/phui/phui-basic-nav-view.css

Yeah, I believe the most important adaptation is the //File a Bug Report// section saying that until you are confirmed as a "trusted contributor", you need to report bugs in the form of a Ponder question.

To implement this, you may want to start from this 🌈

(Oh sorry avivey, I have not noticed your priority action - I agree)

I do not (yet?) understand the use case of this task.

Indeed reported from a Wikimedia user about Wikimedia Phabricator.

I have a nice working version here, which renders the diagram with the drawio viewer javascript component:

• Fixes regression from missing html element

Anyway, even with this fix, for some reasons I can't still use this feature with a comment like {#0000ff} in my local installation 🤔 I'm confused since the unit test works.