Page MenuHomePhorge
Feed All Stories

Fri, Feb 9

valerio.bozzolan added a comment to T15673: Phorge participation at FOSDEM 2024.

TRUST ME - YOU DON'T WANT TO LISTEN MY ENGLISH :D :D

Fri, Feb 9, 10:59 · Blessed Communicators, Phorge
tanasi added Q108: Phorge and Mermaid Js (Answer 138).
Fri, Feb 9, 09:38
avivey closed T15659: Transaction log entries for policy of manually created Diff lack label in Feed (which triggers a PHP 8.1 exception) as Resolved by committing rPf81e821abf2b: Mark manually created Diffs as new objects to fix empty Feed transaction entries.
Fri, Feb 9, 09:19
avivey closed D25517: Mark manually created Diffs as new objects to fix empty Feed transaction entries.
Fri, Feb 9, 09:19
avivey committed rPf81e821abf2b: Mark manually created Diffs as new objects to fix empty Feed transaction entries.
Mark manually created Diffs as new objects to fix empty Feed transaction entries
Fri, Feb 9, 09:19
avivey added a comment to T15673: Phorge participation at FOSDEM 2024.

Nice! Is there a recording of the talk?

Fri, Feb 9, 08:50 · Blessed Communicators, Phorge
20after4 added a comment to T15673: Phorge participation at FOSDEM 2024.

Nice, you touched on most of the advantages of Phorge. It really does have some strong competitive advantages.

Fri, Feb 9, 08:41 · Blessed Communicators, Phorge
avivey added Q108: Phorge and Mermaid Js (Answer 137).
Fri, Feb 9, 08:38
20after4 added a comment to T15630: Fix Fonts.

From my perspective, on Linux, Phorge already supports configurable fonts - that is, none of the specific typefaces mentioned in the phorge css actually work, so it falls back to whatever I set as the default document font in Gnome.

Fri, Feb 9, 08:25
20after4 added a comment to T15630: Fix Fonts.

CSS is rather flexible now; a larger font scale can be specified for displays above a certain horizontal resolution or display width/effective character width, nowadays.
Atkinson looks poor at the font size specified, you're right about that @bekay.
I feel like it might need to break out into another task item, but perhaps CSS modernization is imo a good step towards making Phorge more compatible and capable, on screens both small and large.

Fri, Feb 9, 08:23
avivey added a comment to T15630: Fix Fonts.

As far as fonts are concerned, while we should decide on a new default font, should this be a configurable? Should we make an item (in Config for defaults, and in Settings for users' choice) to change the UI font on an installation?

Fri, Feb 9, 08:22
revi added a comment to T15630: Fix Fonts.

As far as fonts are concerned, while we should decide on a new default font, should this be a configurable? Should we make an item (in Config for defaults, and in Settings for users' choice) to change the UI font on an installation?

Fri, Feb 9, 08:12
revi updated revi.
Fri, Feb 9, 08:10
sirocyl added a comment to T15630: Fix Fonts.

CSS is rather flexible now; a larger font scale can be specified for displays above a certain horizontal resolution or display width/effective character width, nowadays.
Atkinson looks poor at the font size specified, you're right about that @bekay.
I feel like it might need to break out into another task item, but perhaps CSS modernization is imo a good step towards making Phorge more compatible and capable, on screens both small and large.

Fri, Feb 9, 05:33
speck added a comment to Q101: Cannot land a diff - LOGIN REQUIRED (I am logged in).

I haven’t run this specific issue but I have seen other oddities when using my installed arc within the arc or phorge repos. I’m unable to get it to work unless I use the arc that exists along side that phorge repo. That might be similar here.

Fri, Feb 9, 03:15
speck added a comment to T15673: Phorge participation at FOSDEM 2024.

Hahaha I’m just now seeing this. Thank you for putting together the presentation and giving the talk. I enjoy seeing your excitement!

Fri, Feb 9, 03:07 · Blessed Communicators, Phorge
speck added a comment to T15630: Fix Fonts.

I configure my browsers to increase the default font size because my eyes can’t handle the small fonts. Most pages tend to size appropriately but there are some oddities, including Phorge. I’ll grab some screen caps when I’m back on workstation.

Fri, Feb 9, 02:42

Thu, Feb 8

tanasi asked Q108: Phorge and Mermaid Js.
Thu, Feb 8, 21:30
bekay added a comment to T15630: Fix Fonts.

I am honestly surprised by the notion, the user base of phorge is still using old, small or low resolution screens. I always thought this project was catered towards tech-savvy devs and/or corporations and will be used in contexts where a FullHD screen is the default case. Maybe we should sharpen our target audience 😅

Thu, Feb 8, 16:28
aklapper added a comment to T15630: Fix Fonts.

I am honestly happy that you have the privilege to afford getting bigger screens. Unfortunately not everyone has. The point I'm trying to make is: There may be valid + good reasons to increase font sizes, absolutely. However, "go with the time" and "times have changed" phrases are neither valid reasons nor argumentations. :)

Thu, Feb 8, 16:03
bekay added a comment to T15630: Fix Fonts.
In T15630#15561, @bekay wrote:

Times have changed and we all have very big screens.

Absolutely not. Maybe in some richer countries to some extent, but not on my mobile phone. (And even if that was true, scaling exists for a reason.)

Thu, Feb 8, 14:02
aklapper added a comment to T15630: Fix Fonts.
In T15630#15561, @bekay wrote:

Times have changed and we all have very big screens.

Thu, Feb 8, 12:09
valerio.bozzolan closed T15673: Phorge participation at FOSDEM 2024 as Resolved.

Thanks for all the tips <3 <3

Thu, Feb 8, 09:09 · Blessed Communicators, Phorge
bekay attached a referenced file: F1348413: image.png.
Thu, Feb 8, 08:26
bekay added a comment to T15630: Fix Fonts.

And on another note: Times have changed and we all have very big screens. I think we should increase the default font size of 13px to 14px. It is about time...

Thu, Feb 8, 08:14
bekay attached a referenced file: F1348375: image.png.
Thu, Feb 8, 08:08
bekay added a comment to T15630: Fix Fonts.

Of these, I like 1 and 3 (Noto and Inter) better. How does Atkinson look? (I haven't gotten around to changing the font on my end yet, heh)

Thu, Feb 8, 08:08
bekay attached a referenced file: F1348365: Atkinson-Hyperlegible.png.
Thu, Feb 8, 08:01
valerio.bozzolan awarded T15733: IDN not in a punycode format is not recognized as a link a Doubloon token.
Thu, Feb 8, 07:58 · Remarkup, Bug Reports
sirocyl added a comment to T15630: Fix Fonts.

Of these, I like 1 and 3 better. How does Atkinson look? (I haven't gotten around to changing the font on my end yet, heh)

Thu, Feb 8, 00:07

Wed, Feb 7

bekay added a comment to T15630: Fix Fonts.

Here you can see the fonts with Phorge itself. For me the clear winner is Noto Sans. It can add some real modern style to the site.

Wed, Feb 7, 17:33
bekay added a comment to T15630: Fix Fonts.

I like the first three the most.

Wed, Feb 7, 16:56
bekay added a comment to T15630: Fix Fonts.

Maybe I should create a slowvote poll to reach a decision?

Wed, Feb 7, 15:31
sirocyl added a comment to T15630: Fix Fonts.

Regardless of the choice made here; I'm likely going to maintain a patch on my instance that uses Inter for headings and UI elements, and Atkinson Hyperlegible for long-form text prose content.

Wed, Feb 7, 13:28
revi updated the answer wiki for Q107: Phorge does not recognize IDN not in punycode format.
Wed, Feb 7, 11:05
revi attached a referenced file: F1263882: image.png.
Wed, Feb 7, 11:03 · Remarkup, Bug Reports
revi created T15733: IDN not in a punycode format is not recognized as a link.
Wed, Feb 7, 11:03 · Remarkup, Bug Reports
revi updated the question details for Q107: Phorge does not recognize IDN not in punycode format.
Wed, Feb 7, 10:57
valerio.bozzolan added a comment to Q107: Phorge does not recognize IDN not in punycode format.

Thanks for this! BTW you are now in the family of Trusted Contributors - feel free to escalate as a Task under Bug Reports at least I think and maybe Remarkup I think.

Wed, Feb 7, 08:38
valerio.bozzolan added a member for Trusted Contributors: revi.
Wed, Feb 7, 08:34
valerio.bozzolan added a member for Trusted Contributors: Lectrician1.
Wed, Feb 7, 08:29

Tue, Feb 6

valerio.bozzolan edited the content of Next Up.
Tue, Feb 6, 14:59
Lectrician1 added a comment to T15011: Build a Phorge Developer Environment.

I've used phorge-devcontainer as well and it works great!

Tue, Feb 6, 14:26 · Extension Development
aklapper accepted D25517: Mark manually created Diffs as new objects to fix empty Feed transaction entries.
Tue, Feb 6, 12:31
aklapper foisted D25517: Mark manually created Diffs as new objects to fix empty Feed transaction entries upon avivey.

Testing if "Foist Upon" does what I hope it does

Tue, Feb 6, 12:31
aklapper added a comment to D25517: Mark manually created Diffs as new objects to fix empty Feed transaction entries.

@avivey Much cleaner and also works as expected (just tested). Thanks for finding that better approach! Now how can I approve your patch as I'm still set as original author, sigh?

Tue, Feb 6, 12:30
speck closed D25534: T15064: Several arcanist PHP 8.1 compat issues on Windows.
Tue, Feb 6, 11:56
speck committed rARC8ef1ead6aca0: T15064: Several arcanist PHP 8.1 compat issues on Windows.
T15064: Several arcanist PHP 8.1 compat issues on Windows
Tue, Feb 6, 11:56
speck added a comment to D25534: T15064: Several arcanist PHP 8.1 compat issues on Windows.

Both of these failures are edge cases so it does seem likely we wouldn't have found them as quickly. I do still wonder how many Windows users we have.

Tue, Feb 6, 11:54
aklapper added inline comments to D25526: Avoid exception in revision timeline when left diff does not exist.
Tue, Feb 6, 10:45
avivey accepted D25534: T15064: Several arcanist PHP 8.1 compat issues on Windows.

To be fair, it's possible that most of the arc features work for Windows users that don't use PHP. Or at least, arc diff might work for some setup of lint/unit configuration.

Tue, Feb 6, 09:23
avivey awarded D25533: Deprecate Fund and Phortune prototype applications a Yellow Medal token.
Tue, Feb 6, 09:18
aklapper closed D25533: Deprecate Fund and Phortune prototype applications.
Tue, Feb 6, 08:16
aklapper committed rP01b5bf9ea102: Deprecate Fund and Phortune prototype applications.
Deprecate Fund and Phortune prototype applications
Tue, Feb 6, 08:16
speck updated the summary of D25534: T15064: Several arcanist PHP 8.1 compat issues on Windows.
Tue, Feb 6, 03:42
speck added a revision to T15064: Make Phorge compatible with PHP 8.1/8.2/8.3: D25534: T15064: Several arcanist PHP 8.1 compat issues on Windows.
Tue, Feb 6, 03:42 · PHP 8 support
speck updated the summary of D25535: T15011: Update support for XHPast on Windows.
Tue, Feb 6, 03:41
speck added a revision to T15011: Build a Phorge Developer Environment: D25535: T15011: Update support for XHPast on Windows.
Tue, Feb 6, 03:41 · Extension Development
speck added a comment to D25535: T15011: Update support for XHPast on Windows.

The ArcanistBundleTestCase failures are due to diff binary not being present on Windows systems. The tests could be rewritten to utilize git diff instead but would take some effort.

Tue, Feb 6, 03:37
speck updated the diff for D25535: T15011: Update support for XHPast on Windows.

Fix some lints about line length

Tue, Feb 6, 03:13
speck updated the diff for D25535: T15011: Update support for XHPast on Windows.

Fix use of ExecFuture to pass a scalar string as first argument instead of variable.

Tue, Feb 6, 03:10
speck requested review of D25535: T15011: Update support for XHPast on Windows.
Tue, Feb 6, 03:06
speck edited P29 xhpast-make.bat.
Tue, Feb 6, 02:28
20after4 added a comment to T15670: Disallow webcrawlers to index Diffusion repository commits.

When I was at Wikimedia I remember a lot of issues from search robots endlessly indexing dynamic pages.

Tue, Feb 6, 02:26 · Discussion Needed
speck added a comment to T15011: Build a Phorge Developer Environment.

I managed to compile xhpast on windows using llvm installed via Scoop. I also have Visual Studio C++ 19 installed which may be required (I saw some suspicious output that indicated that some include files were being pulled from that install somehow).

Tue, Feb 6, 02:17 · Extension Development
speck created P30 xhpast-winbisonflex.bat.
Tue, Feb 6, 02:16
speck created P29 xhpast-make.bat.
Tue, Feb 6, 02:16
speck created P28 unistd.h.
Tue, Feb 6, 02:12
speck added a comment to D25534: T15064: Several arcanist PHP 8.1 compat issues on Windows.

I wonder how many Windows users we have. The xhpast linter does not work, and the unit test failures listed here are pre-existing and occur without these changes.

Tue, Feb 6, 00:42
speck requested review of D25534: T15064: Several arcanist PHP 8.1 compat issues on Windows.
Tue, Feb 6, 00:38

Mon, Feb 5

speck accepted D25533: Deprecate Fund and Phortune prototype applications.

Almost seems a little too easy

Mon, Feb 5, 22:58
aklapper closed T15714: Validate PhabricatorSearchTextField value as Resolved by committing rPe3714c86a7d5: Validate PhabricatorSearchTextField value not to be an array.
Mon, Feb 5, 21:42
aklapper closed D25519: Validate PhabricatorSearchTextField value not to be an array.
Mon, Feb 5, 21:42
aklapper committed rPe3714c86a7d5: Validate PhabricatorSearchTextField value not to be an array.
Validate PhabricatorSearchTextField value not to be an array
Mon, Feb 5, 21:42
aklapper requested review of D25533: Deprecate Fund and Phortune prototype applications.
Mon, Feb 5, 21:39
aklapper added a comment to T15726: Remove dysfunctional Fund and Phortune prototype applications.

I'm not sure from the description if it's only broken on php 8. We also have PayPal integration)

Mon, Feb 5, 21:28
avivey closed D25532: unbreak celerity/map.
Mon, Feb 5, 18:08
avivey committed rP9c9fbc3d0484: unbreak celerity/map.
unbreak celerity/map
Mon, Feb 5, 18:08
aklapper accepted D25532: unbreak celerity/map.

Also my fault for obviously not testing /all/ steps in D25530

Mon, Feb 5, 17:58
avivey requested verification of rPd9919ddb0667: Revert "Added cross-platform default fonts".

D25532 should fix this...

Mon, Feb 5, 17:25
avivey updated subscribers of D25532: unbreak celerity/map.

I broke it at D25530; Thanks @philj0st

Mon, Feb 5, 17:24
avivey requested review of D25532: unbreak celerity/map.
Mon, Feb 5, 17:24
avivey added a comment to D25530: Revert "Added cross-platform default fonts".

Sorry, I just assumed arc land will catch it...

Mon, Feb 5, 17:21
valerio.bozzolan added a member for Trusted Contributors: philj0st.
Mon, Feb 5, 16:47
valerio.bozzolan raised a concern with rPd9919ddb0667: Revert "Added cross-platform default fonts".
Mon, Feb 5, 16:46
philj0st added a comment to D25530: Revert "Added cross-platform default fonts".

This seems to have generated and committed a merge conflict into resources/celerity/map.php
I get the following error when trying to open Phorge:

Mon, Feb 5, 16:00
aklapper closed T15602: PHP 8.1 "json_decode(null)" exception editing a form when custom field of type Users exists, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3, as Resolved.
Mon, Feb 5, 15:09 · PHP 8 support
aklapper closed T15602: PHP 8.1 "json_decode(null)" exception editing a form when custom field of type Users exists as Resolved by committing rPbb23e86dafc6: Fix PHP 8.1 "json_decode(null)" exception editing a form when custom field of….
Mon, Feb 5, 15:09 · PHP 8 support
aklapper closed D25390: Fix PHP 8.1 "json_decode(null)" exception editing a form when custom field of type Users exists.
Mon, Feb 5, 15:09
aklapper committed rPbb23e86dafc6: Fix PHP 8.1 "json_decode(null)" exception editing a form when custom field of….
Fix PHP 8.1 "json_decode(null)" exception editing a form when custom field of…
Mon, Feb 5, 15:09
aklapper closed D25524: Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string.
Mon, Feb 5, 13:11
aklapper committed rP25aebab655fd: Make misc get*ApplicationClass[Name]() calls return ::class constant instead of….
Make misc get*ApplicationClass[Name]() calls return ::class constant instead of…
Mon, Feb 5, 13:11
avivey added a comment to T15670: Disallow webcrawlers to index Diffusion repository commits.

In case of what?

Mon, Feb 5, 08:54 · Discussion Needed
valerio.bozzolan added a comment to T15670: Disallow webcrawlers to index Diffusion repository commits.

OK. Then we can add a Task about how to easily configure robot changes without forking, in case.

Mon, Feb 5, 08:52 · Discussion Needed
avivey created T15732: Query Panel's "View All" should remove the Page Limit.
Mon, Feb 5, 08:04 · Dashboards
avivey added a comment to T15670: Disallow webcrawlers to index Diffusion repository commits.

Thinking more, I think we'd like to allow the robots to index latest version of the code - these days the big boys know how to handle that. Stopping them from crawling older versions is still important.

Mon, Feb 5, 07:47 · Discussion Needed

Sun, Feb 4

avivey edited the content of Next Up.
Sun, Feb 4, 21:22
avivey closed D25530: Revert "Added cross-platform default fonts".
Sun, Feb 4, 21:15
avivey added a reverting change for D25021: Added cross-platform default fonts: rPd9919ddb0667: Revert "Added cross-platform default fonts".
Sun, Feb 4, 21:15
avivey added a reverting change for rPf8ffa393c442: Added cross-platform default fonts: rPd9919ddb0667: Revert "Added cross-platform default fonts".
Sun, Feb 4, 21:15