Page MenuHomePhorge
Differential D25710

[STUB] Fix missing file attachment in Conpherence
AbandonedPublicDraft
Actions

Authored by valerio.bozzolan on Jul 1 2024, 12:07.
Tags
None
Referenced Files
F4021346: D25710.1746667637.diff
Wed, May 7, 01:27
F4015431: D25710.1746641081.diff
Tue, May 6, 18:04
F4011599: D25710.1746626206.diff
Tue, May 6, 13:56
F4011598: D25710.1746626205.diff
Tue, May 6, 13:56
F4011596: D25710.1746626204.diff
Tue, May 6, 13:56
F3984370: D25710.1746570828.diff
Mon, May 5, 22:33
F3982710: D25710.1746558187.diff
Mon, May 5, 19:03
F3973474: D25710.1746530189.diff
Mon, May 5, 11:16
View All 66 Files
Subscribers
Cigaryno
Matthew
tobiaswiese
valerio.bozzolan

Details

Reviewers
None
Group Reviewers
O1: Blessed Committers
Summary

Please ignore this change.

See this instead:

D25709: Fix missing file attachment in Conpherence

Test Plan
  1. open a Conpherence chat or create a new one
  2. drag and drop file in it and send the message
  3. verify file is attached to the chat

Diff Detail

Repository
rP Phorge
Branch
arcpatch-D25705
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1400
Build 1400: arc lint + arc unit

Event Timeline

valerio.bozzolan created this revision.Jul 1 2024, 12:07
valerio.bozzolan held this revision as a draft.
Harbormaster completed remote builds in B1398: Diff 2187.Jul 1 2024, 12:07
valerio.bozzolan changed the visibility from "Public (No Login Required)" to "No One".Jul 1 2024, 12:14
valerio.bozzolan edited the summary of this revision. (Show Details)
valerio.bozzolan removed a task: T15106: "Upload file" in remarkup text fields should attach by default .
valerio.bozzolan updated this revision to Diff 2188.Jul 1 2024, 12:16

restore original change

Harbormaster completed remote builds in B1399: Diff 2188.Jul 1 2024, 12:16
valerio.bozzolan updated this revision to Diff 2189.Jul 1 2024, 12:17

apply proposed change

Harbormaster completed remote builds in B1400: Diff 2189.Jul 1 2024, 12:17
valerio.bozzolan edited the summary of this revision. (Show Details)Jul 1 2024, 12:17
valerio.bozzolan changed the visibility from "No One" to "Public (No Login Required)".
valerio.bozzolan added inline comments.Jul 1 2024, 12:30
src/applications/transactions/constants/PhabricatorTransactions.php
50

Maybe a better name is findOneByType()

valerio.bozzolan mentioned this in D25709: Fix missing file attachment in Conpherence.Jul 1 2024, 12:30
valerio.bozzolan abandoned this revision.Jul 2 2024, 09:12

Revision Contents
Changeset List

PathSizePackages
src/
applications/
conpherence/
controller/
24 linesO1: Blessed Committers
transactions/
constants/
15 linesO1: Blessed Committers

Diff 2189

View Options

src/applications/conpherence/controller/ConpherenceUpdateController.php

Loading...
View Options

src/applications/transactions/constants/PhabricatorTransactions.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0