Page MenuHomePhorge

Do not consider emails and custom protocols as internal links
Open, LowPublic

Description

Interestingly,

This feature introduced a minor Remarkup render regression (if it could be considered so), since we do not put anymore target="_blank" as default for <a href="mailto:"> links... and this was an historical unit test, so, probably desired to have "external" links for mails.

The regression appeared very probably after this change:

rP328aee033fbd: isSelfURI: fix anchors and relative URIs (that are "self" indeed)

D25555: isSelfURI: fix anchors and relative URIs (that are "self" indeed)

So now, mailto:alincoln@example.com is always considered an internal link. It should be considered external.

Steps to reproduce

In Remarkup field, write this, and inspect element:

[[ mailto:info@asd.com]]

info@asd.com

What happens:

<a href="mailto:info@asd.com" class="remarkup-link" rel="noreferrer">info@asd.com</a>

What should happen instead accordingly to old unit tests:

<a href="mailto:info@asd.com" class="remarkup-link" target="_blank" rel="noreferrer">info@asd.com</a>

Revisions and Commits