Double-accept. This means you unlocked a rare pterodactyl1!1

Documentation is arrsum

Added minor tip.

Odd, I can't quite figure out how this would interfere with //Optional list<string>.//

I love that Phorge has this "Unbreak Now" btw

I'm somehow even more inclined to propose to base this feature on a new custom parser, like cowsay {{{ asd }}}

T15802: Regression: HTML entities rendered as plain text in config option descriptions

I've used git bisect and this regression was introuced after 4d12d014fd9ddc423ecbc6a61a92217d5aff19a4

Thanks everyone for the feedback! Looks like my initial assumptions are already uncommon, so I'm going to decline this ticket for the time being.
The counterproposal makes more sense to me on an 'upstream' level, indeed.

Abandoning per feedback in T15780 (note to myself: may want to consider deploying this in downstream)

Move additional check after existing checks

I would probably put this check after the New username is required. and also after the username validation, but that is still OK

If you followed the test plan and if this works, thanks

In D25601#17036, @valerio.bozzolan wrote:

Maybe better to expand the test plan to check user creation as well

You can set "visibility" for each URI already.

Example: an organization can have 100+ hosted repositories, both Subversion and git, and the highly-trusted-staff can be allowed to push directly in these hosted repositories, for example because they just rely on heavy post-commit review with Audit. And, they can rely on Differential just to share stubs. The pre-commit review with Differential has little to do with Diffusion here.

I visually mark this as "some discussion needed" in T15780

Premising that I quite understand the difference between Differential and Diffusion, I don't get why Differential should impact Diffusion here.

I cannot reproduce the above arc unit issues, locally.

• add hardening suggested by dear avivey
• add unit test for the new low-level function and its crash

Minor clarification.

It works. Thanks!!!

Garrrr, I am very sorry, I was locally experimenting with something else in master branch beforehand obviously, and while I did git stash that one file I created continued to exist in the tree when I branched to work on the dashboard exception - my fault.

Yeah, thad makes sense, I guess.

In D25548#17006, @valerio.bozzolan wrote:

I see "Unknown object" if the Diff repository is unset. Is that known?

• check for non-null repository in Revision
• rebase

I agree that an additional status is needed for closing when creating a task. Current statuses are not obvious. "Closed, Graduated" is good to fast decision.

Suddenly, yesterday I was also talking in one of the kanban communities and I had to tell them that Phorge is a fork of the Phabricator, and not some kind of independent thing without a background. People don't quite understand this.

I probably missed the train, so… can you add the docs for this? :-P

Sorry, doing my best trying to navigate both this site and Phabricator but it's a bit of an acquired taste thus far,

Pending that small inline, lgtm.

I was just surprised that they weren't here, considering that they are used very successfully on Wikimedia. Do you think they are not needed here?

Maybe better to expand the test plan to check user creation as well

Ah, probably after WMF disabled some applications, some crawlers started crashing these. Understood.

I pretended to be a webcrawlerLooking into our downstream error logs. Some crawlers seem very creative for reasons I do not know.

@avivey: still red flag?

How have you discovered this problem?

Probably we need some help to understand the semantic difference between these two:

I'm on latest master, and I'm still not able to try this 🤔 No errors. Just plaintext remarkup. Test case:

I see "Unknown object" if the Diff repository is unset. Is that known?

Tested before and after, I love this! Thanks!

• Run arc liberate from my clean working copy that has not ManiphestDefaultPriorityEditCapability (?)
• Minor fix indentation of a comment in PhabricatorDashboardQueryPanelType.php:81

Can reproduce. Tested. Thanks :)