All of this should maybe go under "applyExternalEffects()"

In this way, do we skip that column creating a column shift?

Whops, typo "Seperate" in the title - sorry for not noticing

Congratulations to both bekay and avivey. Minimum change, maximum result.

beautified even more - all logic inside the Transaction itself

I can reproduce this, on an hosted Subversion repository.

If Phorge adds this feature, it is a good opportunity to be nice to thousands of people who use GitLab and GitHub, to unify with their syntax. Visible here:

I've added additional context since interestingly this feature is available since 2017 in GitLab :O wow

1. Are we interested in #fff?

Looking at the mentioned question, it seems a NULL pointer arrives as first argument in phutil_encode_log(). Fortunately that function is used by only 3 places:

(Whops! wrong summary)

Plenty of creative scope for a follow-up Diff - T15766

I agree and I'm quite sure that just parts is missing

About your Remarkup unit tests, try to rebase. Maybe related to D25559.

Small recap:

swap cases - thanks @speck - please double-accept if this is what was suggested :D

simplified logic - thanks @speck

Another good simple candidate GDPR-friendly:

I flag this as resolved since Code Differences between Phabricator and Phorge solves the problem at the moment. Also because there are no changes in upstream since 2023.

Premising that we may want to rollback 328aee033fbd, probably this line is broken:

Ouch. Probably partially my fault. Feel free to escalate this as Task under Bug Reports - close this as obsolete then

Interesting. This cannot be reproduced here in this website https://we.phorge.it? isn't it? I think no

(Please edit file Visibility to make them Public :D It's another bug ihih - thanks! <3)

remove unrelated stuff

Please also include your exact search. I think you are searching by https://foo and that is unfortunately not possible without "doing this"

Ouch

In D25118#14541, @speck wrote:

I forgot I had this requesting changes. Any idea of the performance hit in markup rendering now that PhutilURI is constructed for every link? I think its constructor does a fair amount.

minor optimization and unit tests are still happy

But in any case, it may have sense to keep a generic index on (dst, type, src) (or maybe just dst, type) in that specific order, since the UNIQUE KEY was probably a "micro-optimization" to achieve such index for queries operating on dst, or also dst and type, but all without src. This is just an opinion from an alien. Better to wait for more answers.

Your email address(es) set by you for your user account in the Phorge Project

That is private data. Nobody can access it.

add inline documentation because we can

Let's split the problems:

There is still that minor inline comment here, maybe interesting

lol

I'm quite sure the problem is limited on repeated code blocks.

Can reproduce

Apparently PhutilSortVector.php is somehow recent, 2016, without any comment about that strpos("\0", $value) that is probably not correct

I also don't understand strpos("\0", $value) since the documentation says that the second argument is the needle

remove unuseful line - thanks

OK OK. So what else? Maybe this (mention from https://secure.phabricator.com/p/epriestley/):

No brushing teeth three times a day? However it looks good to me 👍