Unrelated troubleshooting but what about this?

What about landing this?

improve PHPDoc thanks to amybones

P.S. why is your local unit test failing?

What could go wrong

I'm happy because when a coworker creates a new sub-project "Nonsense Sub", now you can just destroy it (the project, not the coworker lol) and everything is rollbacked as before successfully.

Added a "Limitations" section to clarify what this patch is not about, and clarifying why direct Milestones must be removed (so you don't need to read all the subtasks)

If somebody can share the resulting query, to compare it A/B, that would be super

I think the description of this task should be "It's too much difficult to understand what that red thing is about" or something similar

I very much like the new tip,

It seems that Diviner still runs. Well done both for double-checking.

(about my last phrase I just mean we can have everywhere protected function runWorkflow() and we can avoid to introduce the argument - so for example we could rollback the file PhageExecWorkflow.php 🤯 🤯 🤯 lol )

(You are soo fast woow)

More docs yuum

In D26040#27816, @aklapper wrote:

Keeping it protected will throw Protected method PhageExecWorkflow::runWorkflow() overriding public method ArcanistWorkflow::runWorkflow() should also be public.

(This seems nice) Small question: Does it still work for you keeping the method as protected instead of public?

ooooor this, feel free to do whatever bro

The patch is already approved but maybe it's nice to bring more attention to extension developers

Fingers crossed.

Not really what we expected, but nice try

Can't wait to enjoy the production Grafana CPU graph of Wikimedia Phabricator after this change

In D26032#27621, @aklapper wrote:

Feed before applying the patch (T3922) and after applying the patch (T3923):

add more and more PHPDoc, and fix typos - thanks

If I guess correctly, isNewObject is automatically guessed correctly, so, the root problem is probably here:

Can you discover what's happening here? In theory the editor should detect isNewObject.

You grep like a rockstar

Unlocking patch

Flagging as "andre is merging stuff https://we.phorge.it/D26007#26996"

Very good job as usual 👍

Nice. I'm 99% sure about the test plan, please see https://we.phorge.it/T16068#22703 before landing to adjust it, eventually.

Questions about the steps:

• fix last typo

• @return list<PhabricatorDestructionEngineExtension>

• fix typos
• add PHPDoc @return

Thanks! Additionally, it seems it's not possible to use these through {icon NAME} since it only supports font awesome AFAIK

Seems very useful thanks, I would like to find small extra time to expand the test plan a bit more and run these extra tests, since this sounds very "core"

Is getDisplayIconColor() related to these? (spoiler: probably it's not)

Yet another one strlen(null)...

Love this. Feel free to evaluate the addition of thus, dramatically increasing your corporate security (at the price of slowing you down even more). as stated here lol https://we.phorge.it/D26028#27452 or whatever small thing could help to better visualize this alien behavior that is very peculiar of Phorge (that is, as already said, not intuitive).

Should we also add some PHPDoc @deprecate (or whatever its name) to most CalendarColors?

Maybe better to just expand dialog, so, less code to maintain (?)

(I just mean the feature comes from Phabricator, not from Phorge; sorry I always pick random words to express myself)

Awesome. Optional bonus point, since this legacy feature thing is indeed veeeery confusing and very-Phorgi, maybe we may want to add a "Why" Phorge decided this, and highlight potential pitfalls.

Seems nice. Maybe we can generalize the text a bit to avoid "both" (since you can have multiple of them).

fix PHPDoc - thanks andre