Page MenuHomePhorge
Differential D25995

Remove orphan CSS selectors in PHUIFormView
ClosedPublic
Actions

Authored by aklapper on Wed, May 7, 17:00.

Details

Reviewers
valerio.bozzolan
Group Reviewers
O1: Blessed Committers
Commits
rP5e64a0a81903: Remove orphan CSS selectors in PHUIFormView
Summary

Extra children checks:

Test Plan

Grep the code for each CSS selector (grep --exclude="*.css" -R 'some-search-string' .), also do partial searches, get no results.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

aklapper created this revision.Wed, May 7, 17:00
Owners added a reviewer: O1: Blessed Committers.Wed, May 7, 17:00
Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptWed, May 7, 17:00
aklapper requested review of this revision.Wed, May 7, 17:00
Harbormaster completed remote builds in B1948: Diff 3001.Wed, May 7, 17:00
valerio.bozzolan accepted this revision.Thu, May 22, 12:47

Very good job as usual 👍

I update the description just to be in order with the shown changes, and splitting the important checks (e.g. parent selectors) from the extra ones (e.g. child selectors).

webroot/rsrc/css/phui/phui-form-view.css
101–104

✅

184–194

✅

204–207

✅

247–255

✅

279–282

✅

288–298

✅

This revision is now accepted and ready to land.Thu, May 22, 12:47
valerio.bozzolan edited the summary of this revision. (Show Details)Thu, May 22, 12:47
aklapper updated this revision to Diff 3092.Thu, May 22, 16:34

git rebase master

Harbormaster completed remote builds in B2010: Diff 3092.Thu, May 22, 16:35
Closed by commit rP5e64a0a81903: Remove orphan CSS selectors in PHUIFormView. · Explain WhyFri, May 23, 00:08
This revision was automatically updated to reflect the committed changes.
aklapper added a commit: rP5e64a0a81903: Remove orphan CSS selectors in PHUIFormView.

Revision Contents
Changeset List

PathSizePackages
resources/
celerity/
O1: Blessed Committers
webroot/
rsrc/
css/
phui/
43 linesO1: Blessed Committers

Diff 3093

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/phui/phui-form-view.css

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0