Page MenuHomePhorge
Feed Advanced Search

Apr 22 2025

aklapper added a comment to T16040: Regression: Sending a message in Conpherence rooms opens dialog to edit room.

I can reproduce, looks like the change in src/applications/conpherence/controller/ConpherenceViewController.php is the culprit.
No clue what's a correct fix, thus proposing to revert the entire commit.

Apr 22 2025, 12:54 · UX, Bug Reports, Aphlict, Conpherence
aklapper added a comment to Q178: What version of Phorge are we currently running on the community instance? (Answer 221).

Automagically deploying the latest unexpectedly faulty commit may make this instance unusable, thus likely not latest stable.

Apr 22 2025, 09:56
aklapper renamed T15824: Deprecation notice at PhabricatorEditorURIEngine.php:283 when no RepositorySlug set from Deprecation notice at PhabricatorEditorURIEngine.php:283 to Deprecation notice at PhabricatorEditorURIEngine.php:283 when no RepositorySlug set.
Apr 22 2025, 08:10 · PHP 8 support, Deprecation Notice
aklapper renamed T15829: Deprecation notice @ PhabricatorStandardPageView.php:630 (missing User-Agent HTTP Header) from Deprecation notice @ PhabricatorStandardPageView.php:630 to Deprecation notice @ PhabricatorStandardPageView.php:630 (missing User-Agent HTTP Header).
Apr 22 2025, 08:09 · PHP 8 support, Deprecation Notice

Apr 21 2025

aklapper added a comment to D25968: Mail Notifications: Do not CC disabled user accounts.

I guess I should add a big This is untested banner here

Apr 21 2025, 19:59
aklapper updated the diff for D25968: Mail Notifications: Do not CC disabled user accounts.

Don't check twice for account status; already covered by query parameter

Apr 21 2025, 19:57
aklapper updated the diff for D25968: Mail Notifications: Do not CC disabled user accounts.

Clean my local dir from other experiments

Apr 21 2025, 19:55
aklapper requested review of D25968: Mail Notifications: Do not CC disabled user accounts.
Apr 21 2025, 19:51
aklapper added a revision to T16033: "To:" and "CC:" Recipient Hint footers in mail notifications list disabled user accounts: D25968: Mail Notifications: Do not CC disabled user accounts.
Apr 21 2025, 19:51 · Mail
aklapper added a comment to T15056: Improve Dark Mode.

image.png (453×298 px, 29 KB)

Apr 21 2025, 11:59 · User-Cigaryno, User-valerio.bozzolan, Accessibility, User-Bukkit
aklapper created T16039: Show image preview thumbnails on your Authored Files.
Apr 21 2025, 09:55 · Feature Requests

Apr 17 2025

aklapper resigned from D25966: Add a Copy-to-Clipboard Button to code blocks.
Apr 17 2025, 06:43

Apr 16 2025

aklapper requested changes to D25966: Add a Copy-to-Clipboard Button to code blocks.
Apr 16 2025, 20:02
aklapper updated the task description for T16037: Bump ws npm package for Aphlict.
Apr 16 2025, 17:21 · Security, Aphlict
aklapper added a revision to T16037: Bump ws npm package for Aphlict: D25967: Aphlict: Bump NodeJS package ws from 7.5.0 to 7.5.10.
Apr 16 2025, 17:15 · Security, Aphlict
aklapper requested review of D25967: Aphlict: Bump NodeJS package ws from 7.5.0 to 7.5.10.
Apr 16 2025, 17:15
aklapper updated the task description for T16037: Bump ws npm package for Aphlict.
Apr 16 2025, 17:11 · Security, Aphlict
aklapper updated the task description for T16037: Bump ws npm package for Aphlict.
Apr 16 2025, 17:03 · Security, Aphlict
aklapper created T16037: Bump ws npm package for Aphlict.
Apr 16 2025, 17:03 · Security, Aphlict
aklapper added a comment to T16035: Update embedded copy of Font Awesome 4.7.0.

This might be a bad idea after looking up more docs:

Apr 16 2025, 13:13
aklapper added inline comments to D25966: Add a Copy-to-Clipboard Button to code blocks.
Apr 16 2025, 13:11
aklapper created T16035: Update embedded copy of Font Awesome 4.7.0.
Apr 16 2025, 09:25
aklapper updated the test plan for D25965: Disable opening of hovercard if trigger node is inside hovercard.
Apr 16 2025, 09:13
aklapper retitled D25965: Disable opening of hovercard if trigger node is inside hovercard from Disables opening of hovercard if trigger node is inside hovercard
Apr 16 2025, 09:13
aklapper accepted D25965: Disable opening of hovercard if trigger node is inside hovercard.

Uh nice, thank you! This seems to work as expected:

Screenshot From 2025-04-16 11-10-04.png (289×916 px, 66 KB)

Apr 16 2025, 09:13
aklapper updated the summary of D25965: Disable opening of hovercard if trigger node is inside hovercard.
Apr 16 2025, 07:42
aklapper edited the content of Next Up.
Apr 16 2025, 07:29

Apr 15 2025

aklapper edited the content of Next Up.
Apr 15 2025, 15:04
aklapper created T16033: "To:" and "CC:" Recipient Hint footers in mail notifications list disabled user accounts.
Apr 15 2025, 06:24 · Mail

Apr 14 2025

aklapper closed T16032: DiffusionCommitQuery passes duplicate CommitterIdentity values to PhabricatorRepositoryIdentityQuery as Resolved by committing rP7a29a6d15278: Pass unique CommitterIdentity values to PhabricatorRepositoryIdentityQuery.
Apr 14 2025, 20:21
aklapper closed D25964: Pass unique CommitterIdentity values to PhabricatorRepositoryIdentityQuery.
Apr 14 2025, 20:21
aklapper committed rP7a29a6d15278: Pass unique CommitterIdentity values to PhabricatorRepositoryIdentityQuery.
Apr 14 2025, 20:21
aklapper requested review of D25964: Pass unique CommitterIdentity values to PhabricatorRepositoryIdentityQuery.
Apr 14 2025, 12:18
aklapper added a revision to T16032: DiffusionCommitQuery passes duplicate CommitterIdentity values to PhabricatorRepositoryIdentityQuery: D25964: Pass unique CommitterIdentity values to PhabricatorRepositoryIdentityQuery.
Apr 14 2025, 12:18
aklapper created T16032: DiffusionCommitQuery passes duplicate CommitterIdentity values to PhabricatorRepositoryIdentityQuery.
Apr 14 2025, 12:13
aklapper edited the content of Next Up.
Apr 14 2025, 10:14
aklapper updated the summary of D25957: Replace usages of PhutilProxyException.
Apr 14 2025, 07:15
aklapper accepted D25957: Replace usages of PhutilProxyException.

Thanks! Accepting per testing in D25956#25577

Apr 14 2025, 07:15

Apr 13 2025

aklapper closed T16030: Expose time with File upload date as Resolved by committing rPafd21b827434: Expose time with File upload date.
Apr 13 2025, 21:57
aklapper closed D25961: Expose time with File upload date.
Apr 13 2025, 21:57
aklapper committed rPafd21b827434: Expose time with File upload date.
Apr 13 2025, 21:57

Apr 12 2025

aklapper closed D25942: Herald Transcripts: Use μs instead of us for microseconds.
Apr 12 2025, 23:24
aklapper committed rP08637ce082d0: Herald Transcripts: Use μs instead of us for microseconds.
Apr 12 2025, 23:24
aklapper added a revision to T16030: Expose time with File upload date: D25961: Expose time with File upload date.
Apr 12 2025, 22:58
aklapper requested review of D25961: Expose time with File upload date.
Apr 12 2025, 22:58
aklapper created T16030: Expose time with File upload date.
Apr 12 2025, 22:55
aklapper closed D25880: Replace some AphrontView::setUser() calls with AphrontView::setViewer().
Apr 12 2025, 22:46
aklapper committed rP4d98c0a45586: Replace some AphrontView::setUser() calls with AphrontView::setViewer().
Apr 12 2025, 22:46
aklapper updated the summary of D25957: Replace usages of PhutilProxyException.
Apr 12 2025, 20:52
aklapper accepted D25900: Remove the onboard "mailKey" from Paste.

I had to go dig for this, but from what I understand of looking at PhabricatorMetaMTAMailProperties, which is the class now responsible for this functionality, creating a mail key only happens when its loadMailKey method is called. That method is only called when email functionality engaged.

Apr 12 2025, 20:46
aklapper updated the summary of D25956: Replace usages of PhutilProxyException.
Apr 12 2025, 20:46
aklapper accepted D25956: Replace usages of PhutilProxyException.

Thanks! Small nitpick: I'd probably change @deprecated call Exception::getPrevious directly. to @deprecated Call Exception::getPrevious() directly.

Apr 12 2025, 20:45
aklapper added a comment to D25900: Remove the onboard "mailKey" from Paste.

What is (or rather was, I guess) that mailKey thingie good for? Or more relevant, I assume it's intentional after performing the Test Plan steps above that creating a new Paste does not create a new row in phabricator_metamta.metamta_mailproperties?
Apart from that, seems to work as expected. :) Thanks!

Apr 12 2025, 11:06
aklapper updated the test plan for D25900: Remove the onboard "mailKey" from Paste.
Apr 12 2025, 11:01

Apr 11 2025

aklapper requested review of D25958: PHPDoc: Fix @return string for methods which can also return null.
Apr 11 2025, 09:51
aklapper edited the content of Next Up.
Apr 11 2025, 08:55
aklapper closed T15985: Fix UX regression in Phame as Resolved by committing rP12991c0d377a: Fix overlapping elements in Phame for >1791px width.
Apr 11 2025, 08:54 · Phame, Bug Reports, UX
aklapper closed T15985: Fix UX regression in Phame, a subtask of T15920: Make table of contents visible when using wide screens, as Resolved.
Apr 11 2025, 08:54 · UX, Feature Requests
aklapper closed D25873: Fix overlapping elements in Phame for >1791px width.
Apr 11 2025, 08:54
aklapper committed rP12991c0d377a: Fix overlapping elements in Phame for >1791px width.
Apr 11 2025, 08:54
aklapper updated the diff for D25873: Fix overlapping elements in Phame for >1791px width.

git rebase master

Apr 11 2025, 08:53
aklapper updated the diff for D25955: Unhandled Exception: Add last call to error message.

Strip proceeding slash of path; wrap error message in quotation marks

Apr 11 2025, 07:02

Apr 10 2025

aklapper updated the diff for D25955: Unhandled Exception: Add last call to error message.

Only expose last call location if phabricator.developer-mode is set

Apr 10 2025, 11:21
aklapper updated the diff for D25955: Unhandled Exception: Add last call to error message.

Thanks! Indeed I should have tested this more.

Apr 10 2025, 11:17
valerio.bozzolan awarded T16027: People Search: Allow querying by project membership a Like token.
Apr 10 2025, 10:15 · Feature Requests
aklapper created T16027: People Search: Allow querying by project membership.
Apr 10 2025, 09:41 · Feature Requests
aklapper updated the task description for T16026: Provide a standard custom "Due Date" / Deadline field for tasks.
Apr 10 2025, 09:07 · Feature Requests
aklapper created T16026: Provide a standard custom "Due Date" / Deadline field for tasks.
Apr 10 2025, 09:06 · Feature Requests
aklapper added a project to T15846: Show previous value in transaction title when removing points or a custom field value set at task initialization: Affects-Wikimedia.
Apr 10 2025, 08:31 · Affects-Wikimedia

Apr 9 2025

aklapper renamed T15904: Tech Debt: Replace calls to PhutilProxyException with PhutilErrorHandler from Replace calls to PhutilProxyException with PhutilErrorHandler to Tech Debt: Replace calls to PhutilProxyException with PhutilErrorHandler.
Apr 9 2025, 10:34
aklapper removed a parent task for T15354: Exception when trying to create Pholio mock without name: T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4.
Apr 9 2025, 08:38
aklapper removed a subtask for T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4: T15354: Exception when trying to create Pholio mock without name.
Apr 9 2025, 08:38 · PHP 8 support

Apr 8 2025

aklapper requested review of D25955: Unhandled Exception: Add last call to error message.
Apr 8 2025, 18:24
aklapper added a revision to T15689: built in exception display is missing top line: D25955: Unhandled Exception: Add last call to error message.
Apr 8 2025, 18:24 · Wikimedia Hackathon 2025, Phorge Development Tools
aklapper edited the content of Next Up.
Apr 8 2025, 17:17
aklapper requested review of D25954: PHPDoc: Correct marker in one class header.
Apr 8 2025, 16:07
aklapper requested review of D25953: PHPDoc: Replace invalid "key" and "value" types.
Apr 8 2025, 15:49
aklapper requested review of D25952: PHPDoc: Replace invalid "obj" with "object".
Apr 8 2025, 15:44
aklapper requested review of D25951: PHPDoc: Replace invalid "obj" with "object".
Apr 8 2025, 15:36
aklapper closed D25937: PHPDoc: Make some parameter types match type in signatures.
Apr 8 2025, 09:00
aklapper committed rP75d8c84c1372: PHPDoc: Make some parameter types match type in signatures.
Apr 8 2025, 09:00
aklapper closed D25941: PhabricatorCustomField: Fix a typo in PHPDoc.
Apr 8 2025, 09:00
aklapper committed rPbf39f021d626: PhabricatorCustomField: Fix a typo in PHPDoc.
Apr 8 2025, 09:00
aklapper closed T15992: PHP 8.1 "strlen(null)" exception adding an MFA provider, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Apr 8 2025, 08:59 · PHP 8 support
aklapper closed T15992: PHP 8.1 "strlen(null)" exception adding an MFA provider as Resolved by committing rPef3e0a75f62e: Fix PHP 8.1 "strlen(null)" exception in Feed setting up MFA.
Apr 8 2025, 08:59 · Auth, PHP 8 support
aklapper closed D25867: Fix PHP 8.1 "strlen(null)" exception in Feed setting up MFA.
Apr 8 2025, 08:59
aklapper committed rPef3e0a75f62e: Fix PHP 8.1 "strlen(null)" exception in Feed setting up MFA.
Apr 8 2025, 08:59

Apr 7 2025

aklapper closed T16025: Tech Debt: Complete session digest migration from SHA1 to SHA256 as Resolved by committing rP964b1d4b3dca: Complete session digest migration from SHA1 to SHA256.
Apr 7 2025, 21:46
aklapper closed D25949: Complete session digest migration from SHA1 to SHA256.
Apr 7 2025, 21:46
aklapper committed rP964b1d4b3dca: Complete session digest migration from SHA1 to SHA256.
Apr 7 2025, 21:46
aklapper accepted D25256: Fix PHP 8.1 "strlen(null)" exception on auth email message body when PhabricatorAuthMessage is unset.

@mturdus: Could you land this one please, or would you like any help? Thanks!

Apr 7 2025, 21:23 · PHP 8 support
aklapper accepted D25946: Remove support for PHP mysql extension.
  • Apply this patch on a Fedora 42 system with PHP 8.4.5. php -m listed mysqli, mysqlnd, pdo_mysql etc.
  • Uninstall php-mysqlnd package. After reboot, php -m does not list those three modules anymore, and Phorge complains Required PHP extensions are not installed: mysqli as expected.
  • Install package again, Phorge works: "Unresolved setup issues" still lists the same MySQL related stuff as before; /config/clusters/databases shows entry as usual; successfully filed a Maniphest task.
  • Open /etc/php.ini and set mysqli.allow_local_infile = On. Restart Apache HTTPD. "Unresolved setup issues" in Phorge shows Unsafe "MySQL "local_infile" Setting Enabled as expected.
Apr 7 2025, 21:13
aklapper updated the test plan for D25950: Remove PHP APC support and APC references.
Apr 7 2025, 20:47
aklapper updated the test plan for D25949: Complete session digest migration from SHA1 to SHA256.
Apr 7 2025, 20:43
aklapper updated the summary of D25942: Herald Transcripts: Use μs instead of us for microseconds.
Apr 7 2025, 20:15
aklapper closed D25933: Remove several unused private functions.
Apr 7 2025, 20:14
aklapper committed rPd5ade92fd0d4: Remove several unused private functions.
Apr 7 2025, 20:14
aklapper edited the content of Next Up.
Apr 7 2025, 20:13
aklapper closed D25947: Remove setup check for safe_mode removed in PHP 5.4.
Apr 7 2025, 20:12
aklapper committed rP969904e7fa3f: Remove setup check for safe_mode removed in PHP 5.4.
Apr 7 2025, 20:12