run unit test

Adding @aklapper as subscriber in this security issue since I trust this user (unclear if this should be flagged as security thought, feel free to open)

This seems to impact mail deliverability to @icloud.com addresses too.

Please "remind" me about this ticket as often as possible, so I will fix it. I have everything I need to actually fix this, except the willpower.

We should maybe rewrite a bit the proposed solution, since ideally it's possible to use upstream.phorge.dev but it should be at least reachable to pass some anti-spam checkers I guess. At the moment it isn't:

@mturdus: Thanks! LGTM

@valerio.bozzolan: Feel free to give this revised version another review :)

Big thanks for digging deep into that regex (on which I gave up).

Thanks. Confirming that this works as expected (after manually changing test_accents.mbox to make the arc unit output fail)

In D25844#22553, @valerio.bozzolan wrote:

I hope you won't send me a lawyer

do you really think I could afford one

@3tayesh Please don't do that again.

git rebase origin/master

lol @taavi I've stolen some of your "ä" for the example file test_accents.mbox, I hope you won't send me a lawyer

I tried to prepare a unit test but it's not working. But yes it seems to work thanks

(Sorry I cannot test now) Does the test plan work with just this?

Nice question avivey. We could always disable this but maybe "newcomer admins" may not try to click it, so with more confusion from the other (Dark) Side.

Since the button doesn't do anything in any case except say why it doesn't do anything, it might always be disabled? Do we have any other similar buttons?
I'm never sure if users discover that disabled buttons are actually clickable (and try to explain why they're disabled). It's a UI feature I really like, but I don't think I've seen it anywhere else.

Is the extension still maintained? While there is no extension store yet, it's possible to host repositories here. https://we.phorge.it/w/docs/extensions/phactory/

Add the newlline

this unfortunately caused T15963: LDAP over TLS is broken :/

(I still need to understand the old intentions on the old regex, and the new one, but it seems much magically readable, thanks)

Double slam accept

Simplify return of validateRealName() as proposed by Valerio

BTW I think the page is reached by a crawler that is visiting a branch root on a specific commit:

Wow. Assuming the line is the one with phutil_nonempty_string($branch), why branch "main" is considered a number?

sgtm. Thanks :) just that comment

Thanks for catching that! Amend in new PhutilNumber()

Finally got a reproducer URI in downstream:

• Broken: https://phabricator.wikimedia.org/diffusion/OSWB/branches/main/.gitignore;5a588bf0ee10546ddb9d0872d1be1bf48b3f3c07 (branches in URI).
• Works: https://phabricator.wikimedia.org/diffusion/OSWB/browse/main/.gitignore;5a588bf0ee10546ddb9d0872d1be1bf48b3f3c07 (browse in URI).