In D25577#16640, @mturdus wrote:

Now it's working!

Now it's working!

done...

Premising I've already seen this syntax in Java but not in PHP, I'm happy that now your IDE says something useful. Maybe a better title is "Improve PHPDoc of id()".

Yeah, probably. I'll try to do it tonight.

@mturdus right, I don't have the whole picture of this little bit wild codebase 😁 Thanks for the pointer. As far as I can see, this image and the DOMContentLoaded event handler serves no purpose anymore. All is working without it. I have renamed the main js and some functions in it for clarity. Would love if you could give it a try.

• Renames behavior and some functions and gets rid of unnecessary image proxy

This is the console log I got when running in Firefox:

Navigated to http://phorge.blackbird.turdus.local/diagram/
diagram-extension behavior called with config: 
Object { loadJsExtensionArgs: (4) […], toolbarCss: "http://phorge.blackbird.turdus.local/res/diagram-resources/35ad6f49/iframe-toolbtn.css", toolbarJs: "http://phorge.blackbird.turdus.local/res/diagram-resources/26d75a35/iframe-toolbtn.js" }
​
loadJsExtensionArgs: Array(4) [ "", "", "", … ]
​​
0: ""
​​
1: ""
​​
2: ""
​​
3: ""
​​
length: 4
​​
<prototype>: Array []
​
toolbarCss: "http://phorge.blackbird.turdus.local/res/diagram-resources/35ad6f49/iframe-toolbtn.css"
​
toolbarJs: "http://phorge.blackbird.turdus.local/res/diagram-resources/26d75a35/iframe-toolbtn.js"
​
<prototype>: Object { … }
phorge_extension.js:8:11
loadJsExtension called with args: <empty string> <empty string> <empty string> <empty string> phorge_extension.js:95:13

Can this (I mean rPb445e1d80df9 )be backported into stable?

Fixed by R5:91dd43de7dee: T15781: arc liberate throws exception

In D25576#16603, @avivey wrote:

Unless we can come up with a better/more common notation to show this information, I'm +1 on this - I like static type information, and this one looks fine to me.
I'm not familiar with many PHP tools - is there another notation somewhere?

@mturdus I have added some console logs in the js code (so patch and purge the caches on <phorge-base>config/cache/!)

• Caches draw.io assets, uses base64 method of diagram and adds some console logs for js debugging

Maybe put the warning above the box, so it catches all actions, not just comments?

In D25546#16489, @valerio.bozzolan wrote:

Maybe we can add our dependency:

(new PhabricatorApplicationTransactionCommentView())
  ->setEngine($engine)
  ->render();

Firefox does work for me. Does Chrome work for you?

Unless we can come up with a better/more common notation to show this information, I'm +1 on this - I like static type information, and this one looks fine to me.
I'm not familiar with many PHP tools - is there another notation somewhere?

I'm on branch arcpatch-D25577 now but I still have an empty screen.

In D25576#16575, @speck wrote:

I don’t believe this style of doc annotation is used elsewhere. What’s the purpose of this?

@mturdus You don't have to download the diff, you can do an arc patch D25577 (and you should, because I have changed something again). Mh, but I don't know why it should not work.... 🤔

• Dumps base64 image data directly while remarkup rendering and adds js/css files for remarkup object rule

@mturdus Is the phorge_extension.js file loaded?

I might be doing something wrong.
When I open Diagrams, I see an empty screen with only the application's title "Diagram" and its corresponding icon on top

Write Phorge application extension which uses backticked strings containing spaces.

@mturdus Just test this if you like. I think this is a first step in the right direction: D25577

Well I have worked the entire day on this (and I see your mentioned issues)... main problem is: extension is not working with security.alternate-file-domain. That I have fixed at least for the creation/editing of diagrams. I have changed pretty much and would love to send a diff.

The reason why I did not put all the draw.io js and css files in the repo is because

1. draw.io is a very large repo

and 2) the draw.io people commit a lot (as in more than once a week).

GitHub/Facebook is already supported as a Login/Registration providers.

I think the purpose is to tell the IDE that the function receives a type and returns that exact type.

I don’t believe this style of doc annotation is used elsewhere. What’s the purpose of this?

Seems good

(Working on fixing it...)

Did my previous comment sufficiently elaborate that this is not a change in behavior? If the comment did not, please speak up before I may merge this. :) Thanks!

(I took the liberty to link the specific change in Git in the commit message)

(Stupid question :D sorry - clear now)

In D25575#16550, @valerio.bozzolan wrote:

Where I can document myself about undefined_magic_text? Undetected with grep 🤔

In D25080#16549, @aklapper wrote:

I still think that the two Subscriber Rule value should be a list strings should for consistency be Add subscriber rule value should be a list respectively Remove subscriber rule value should be a list.

Where I can document myself about undefined_magic_text? Undetected with grep 🤔

That's due to https://git.kernel.org/pub/scm/git/git.git/commit/revision.c?id=71a1e94821666909b7b2bd62a36244c601f8430e

I still think that the two Subscriber Rule value should be a list strings should for consistency be Add subscriber rule value should be a list respectively Remove subscriber rule value should be a list.

I've created D25575 for this case, and filed T15783 for the broader issue.

fix red color for removal (like in PhabricatorProjectTriggerRemoveProjectsRule)

follow code review - thanks

Probably my somewhat 10 cents at a broader level;

In D25573#16505, @aklapper wrote:

Thanks! Definitely way more correct :) Feel free to arc land

UI wise this seems to work as expected, and I think there's no way to move stuff on a workboard via Conduit. Just needs some smaller string adjustments.

Small capitalization nitpick, seems all other options use sentence case instead of title case:

git rebase master

Make lint happy