Page MenuHomePhorge
Feed Advanced Search

Oct 3 2023

fgaz added a comment to Q77: Arcanist writes cache files to its source directory, and this prevents packaging.

Nix

Oct 3 2023, 14:17 · Arcanist
valerio.bozzolan added a comment to Q77: Arcanist writes cache files to its source directory, and this prevents packaging.

Just for my curiosity, what lovely package are you crafting? APT? snap? Thanks :)

Oct 3 2023, 14:15 · Arcanist
fgaz updated the question details for Q77: Arcanist writes cache files to its source directory, and this prevents packaging.
Oct 3 2023, 14:14 · Arcanist
fgaz asked Q77: Arcanist writes cache files to its source directory, and this prevents packaging.
Oct 3 2023, 14:13 · Arcanist

Aug 14 2023

bob closed T15599: PHP 8.2 "strlen(): Passing null to parameter #1 ($string) of type string is deprecated" in patch operation as Resolved by committing rARCdf6c315ace5f: Fix a PHP 8.1/8.2 deprecated use of strlen deprecated call with a NULL argument.
Aug 14 2023, 08:58 · PHP 8 support, Arcanist, User-valerio.bozzolan
bob closed T15599: PHP 8.2 "strlen(): Passing null to parameter #1 ($string) of type string is deprecated" in patch operation, a subtask of T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo), as Resolved.
Aug 14 2023, 08:58 · PHP 8 support, Arcanist, User-valerio.bozzolan

Aug 11 2023

valerio.bozzolan updated the task description for T15209: The Celerity unit tests are not automatically run when touching whatever CSS or JS file.
Aug 11 2023, 17:01 · Phorge Development Tools, Arcanist, User-valerio.bozzolan

Aug 10 2023

bob added a revision to T15599: PHP 8.2 "strlen(): Passing null to parameter #1 ($string) of type string is deprecated" in patch operation: D25383: Fix a PHP 8.1/8.2 deprecated use of strlen deprecated call with a NULL argument.
Aug 10 2023, 16:29 · PHP 8 support, Arcanist, User-valerio.bozzolan
bob created T15599: PHP 8.2 "strlen(): Passing null to parameter #1 ($string) of type string is deprecated" in patch operation.
Aug 10 2023, 16:17 · PHP 8 support, Arcanist, User-valerio.bozzolan

Jul 26 2023

valerio.bozzolan added a comment to T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..

Another problem dramatically frequent for newcomers (at least in my office).

Jul 26 2023, 08:27 · Discussion Needed, Arcanist

Jul 24 2023

avivey removed a project from T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues.: Phorge General/Unknown.
Jul 24 2023, 11:54 · Discussion Needed, Arcanist

Jul 18 2023

valerio.bozzolan closed T15239: phutil_nonempty_scalar() should never throw an exception with valid scalars (like booleans), a subtask of T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies, as Resolved.
Jul 18 2023, 10:41 · Documentation, PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan closed T15239: phutil_nonempty_scalar() should never throw an exception with valid scalars (like booleans) as Resolved by committing rARCb996b4799b02: phutil_nonempty_scalar(): don't throw when receiving a boolean scalar.
Jul 18 2023, 10:41 · User-valerio.bozzolan, Arcanist

Jul 11 2023

avivey added a comment to T15281: $HOME missing from commands issued by ExecFuture.

See https://we.phorge.it/T15533#11839 - the env-selecting code in ExecFuture has this logic:

Jul 11 2023, 18:42 · User-valerio.bozzolan, Arcanist

Jul 9 2023

matmarex added a revision to T15544: `arc lint` can't run `jshint` on Windows: D25341: Fix ArcanistExternalLinter on Windows.
Jul 9 2023, 22:55 · Arcanist
matmarex claimed T15544: `arc lint` can't run `jshint` on Windows.
Jul 9 2023, 22:53 · Arcanist
matmarex created T15544: `arc lint` can't run `jshint` on Windows.
Jul 9 2023, 22:38 · Arcanist

Jul 7 2023

valerio.bozzolan updated the task description for T15541: "arc browse <file>" does not support Subversion.
Jul 7 2023, 13:48 · User-valerio.bozzolan, Arcanist
valerio.bozzolan added a comment to T15541: "arc browse <file>" does not support Subversion.

Hi @speck are you still a Mercurial user? Does arc browse <file> work for you? Just for my curiosity

Jul 7 2023, 11:53 · User-valerio.bozzolan, Arcanist
valerio.bozzolan updated the task description for T15541: "arc browse <file>" does not support Subversion.
Jul 7 2023, 11:50 · User-valerio.bozzolan, Arcanist
valerio.bozzolan triaged T15541: "arc browse <file>" does not support Subversion as Low priority.
Jul 7 2023, 11:49 · User-valerio.bozzolan, Arcanist
szotsaki added a comment to T15533: Bug: Unhandled Exception ("Exception") - Diff Parse Exception: Expected '\ No newline at end of file'..

It is on Diffusion > My repository > Selected commit SHA diff page. E.g. https://<domain>/R1:abdcdefgh

Jul 7 2023, 07:47 · Localization, Bug Reports, Diffusion

Jul 6 2023

avivey added a comment to T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..

I've extracted T15535: Using Differential with plain Git, without requiring Arc for the git-push-for-revision.

Jul 6 2023, 13:29 · Discussion Needed, Arcanist
20after4 added a comment to T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..

Interesting.... Herald could probably start the flow, but there's still more parts needed (update vs create revision, extract summary and test plan)

Jul 6 2023, 13:14 · Discussion Needed, Arcanist
Sten added a comment to T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..

Has anyone experimented with using arcanist in a docker container? I see two people have published these on dockerhub:

Jul 6 2023, 10:00 · Discussion Needed, Arcanist
avivey added a comment to T15533: Bug: Unhandled Exception ("Exception") - Diff Parse Exception: Expected '\ No newline at end of file'..

Where exactly are you seeing this error? what page exactly?

Jul 6 2023, 06:47 · Localization, Bug Reports, Diffusion

Jul 5 2023

szotsaki created T15533: Bug: Unhandled Exception ("Exception") - Diff Parse Exception: Expected '\ No newline at end of file'..
Jul 5 2023, 21:27 · Localization, Bug Reports, Diffusion
avivey added a comment to T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..

Interesting.... Herald could probably start the flow, but there's still more parts needed (update vs create revision, extract summary and test plan), and it technically can't delete the branch (it can prevent it from being created, but that shows up as an error in the user-side).
But it should be able to at least trigger the flow and provide a URL for the user to click on.

Jul 5 2023, 20:26 · Discussion Needed, Arcanist
Ekubischta added a comment to T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..

Could this be solved with a Herald action?

Jul 5 2023, 19:28 · Discussion Needed, Arcanist
20after4 added a comment to T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..

I suspect there's also a problem of motivation: These things are lots of work, and the people who are capable of performing them - people who are comfortable with working with these tools - will not personally benefit from this stuff. The people who would benefit the most are people who are not involved in the project at all...

Jul 5 2023, 16:23 · Discussion Needed, Arcanist

Jul 4 2023

avivey added a comment to T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..

I think the current actionable steps we can take are:

Jul 4 2023, 18:10 · Discussion Needed, Arcanist
ton added a comment to T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..

I posted this in a separate thread, but it is definitely related: https://we.phorge.it/T15524

Jul 4 2023, 17:38 · Discussion Needed, Arcanist

Jul 3 2023

Cigaryno updated the task description for T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo).
Jul 3 2023, 19:46 · PHP 8 support, Arcanist, User-valerio.bozzolan
avivey added a project to T15209: The Celerity unit tests are not automatically run when touching whatever CSS or JS file: Phorge Development Tools.
Jul 3 2023, 18:16 · Phorge Development Tools, Arcanist, User-valerio.bozzolan
avivey added a project to T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues.: Discussion Needed.
Jul 3 2023, 18:13 · Discussion Needed, Arcanist
avivey raised the priority of T15209: The Celerity unit tests are not automatically run when touching whatever CSS or JS file from Normal to High.
Jul 3 2023, 08:43 · Phorge Development Tools, Arcanist, User-valerio.bozzolan
valerio.bozzolan updated the task description for T15209: The Celerity unit tests are not automatically run when touching whatever CSS or JS file.
Jul 3 2023, 08:26 · Phorge Development Tools, Arcanist, User-valerio.bozzolan
valerio.bozzolan renamed T15209: The Celerity unit tests are not automatically run when touching whatever CSS or JS file from The Celerity unit tests are not automatically run when touching a CSS file to The Celerity unit tests are not automatically run when touching whatever CSS or JS file.
Jul 3 2023, 08:25 · Phorge Development Tools, Arcanist, User-valerio.bozzolan

Jun 26 2023

aklapper closed T15335: PHP 8.1 null parameter exceptions block rendering the "Browse Projects" overlay dialog as Resolved.
Jun 26 2023, 10:44 · Arcanist, PHP 8 support

Jun 24 2023

avivey assigned T15485: error when running arc liberate after deleting a source file to goddenrich.
Jun 24 2023, 18:21 · Arcanist, Bug Reports
avivey added a comment to T15485: error when running arc liberate after deleting a source file.

I'm unable to reproduce:
I've deleted a file in arcanist library, and ran arc liberate. I got no error message and the __phutil_library_map__.php was updated correctly.

Jun 24 2023, 09:10 · Arcanist, Bug Reports

Jun 22 2023

ton updated the task description for T15364: arc land complaints summary by FreeBSD community.
Jun 22 2023, 15:03 · Arcanist, Differential, Affects-FreeBSD

Jun 19 2023

valerio.bozzolan added a project to T15485: error when running arc liberate after deleting a source file: Arcanist.
Jun 19 2023, 19:44 · Arcanist, Bug Reports
valerio.bozzolan added a revision to T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo): D25300: Fix strlen() being passed a null in ArcanistUnitConsoleRenderer.php.
Jun 19 2023, 08:39 · PHP 8 support, Arcanist, User-valerio.bozzolan

Jun 17 2023

valerio.bozzolan closed T15051: default.pem in Arcanist is out of date - maybe remove it completely? as Resolved.

I think we can consider this as resolved by our dear @jacques since I just tried and it finally works ✨

Jun 17 2023, 15:32 · Arcanist
valerio.bozzolan added a revision to T15051: default.pem in Arcanist is out of date - maybe remove it completely?: D25049: Update the extracted cURL SSL CA bundle.
Jun 17 2023, 15:26 · Arcanist

Jun 16 2023

valerio.bozzolan moved T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies from Backlog to 🔥 Trap on the User-valerio.bozzolan board.
Jun 16 2023, 21:38 · Documentation, PHP 8 support, Arcanist, User-valerio.bozzolan

Jun 12 2023

valerio.bozzolan moved T15281: $HOME missing from commands issued by ExecFuture from PingDeath 🌚 to 🔥 Trap on the User-valerio.bozzolan board.
Jun 12 2023, 13:06 · User-valerio.bozzolan, Arcanist
valerio.bozzolan placed T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies up for grabs.

I honestly have nothing more to be done here. I would like to set as resolved but there are sub-tasks opened

Jun 12 2023, 07:59 · Documentation, PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan updated the task description for T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies.
Jun 12 2023, 07:58 · Documentation, PHP 8 support, Arcanist, User-valerio.bozzolan
avivey triaged T15139: arc edit - util to complete the "edit" button as Wishlist priority.
Jun 12 2023, 07:37 · Arcanist

Jun 10 2023

aklapper closed T15331: PHP 8.1 "strlen(null)" exceptions block creating a project with an empty Description field as Resolved.
Jun 10 2023, 14:36 · Projects, Arcanist, PHP 8 support
avivey added a comment to T15281: $HOME missing from commands issued by ExecFuture.

In T12071, @epriestly mentions that individually selecting env-vars to copy "build[s] some resistance to "Shellshock" class vulnerabilities", which is kind of a compelling argument.

Jun 10 2023, 08:51 · User-valerio.bozzolan, Arcanist
avivey added a comment to T15281: $HOME missing from commands issued by ExecFuture.

Ok, looks like my personal install is missing $HOME as well, so I can probably try to reproduce.

Jun 10 2023, 08:46 · User-valerio.bozzolan, Arcanist

Jun 2 2023

aklapper closed T15346: PHP 8.1 exceptions in JsonLint block rendering Tab Panels in Dashboards as Resolved by committing rARCb325304b6e52: Fix PHP 8.1 null exceptions which block rendering tab panels on dashboards.
Jun 2 2023, 16:31 · Arcanist, PHP 8 support

Jun 1 2023

valerio.bozzolan closed T15368: PHP 8.1 fix PhutilUTF8StringTruncator::truncateString(NULL) called at [<arcanist>/src/ref/ArcanistRefView.php:103] as Resolved by committing rARC444bb60d4325: Fix PHP 8.1 "strlen(null)" exception from ArcanistRefView which blocks "arc….
Jun 1 2023, 16:20 · PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan closed T15368: PHP 8.1 fix PhutilUTF8StringTruncator::truncateString(NULL) called at [<arcanist>/src/ref/ArcanistRefView.php:103], a subtask of T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo), as Resolved.
Jun 1 2023, 16:20 · PHP 8 support, Arcanist, User-valerio.bozzolan

May 29 2023

valerio.bozzolan added a comment to T15188: arc lint: "Function utf8_decode() is deprecated" in PHP 8.2.
In T15188#9488, @speck wrote:

It looks like upstream just straight-up removed the call to utf8_decode() in the master branch: https://secure.phabricator.com/diffusion/ARC/browse/master/src/utils/utf8.php$290-292

May 29 2023, 13:31 · PHP 8 support, Arcanist, User-valerio.bozzolan
speck added a comment to T15188: arc lint: "Function utf8_decode() is deprecated" in PHP 8.2.

It looks like upstream just straight-up removed the call to utf8_decode() in the master branch: https://secure.phabricator.com/diffusion/ARC/browse/master/src/utils/utf8.php$290-292

May 29 2023, 13:29 · PHP 8 support, Arcanist, User-valerio.bozzolan
aklapper closed T15268: Typo in English string "Lock '%s is not locked by this process!" as Resolved by committing rARC18554ea76ceb: Correct spelling mistake in PhutilLock.
May 29 2023, 08:29 · Good Starter Task, Arcanist
valerio.bozzolan added a comment to T15268: Typo in English string "Lock '%s is not locked by this process!".

It would be helpful to have reproducing steps here, but probably this was never reproduced by the reporter, just found from TranslateWiki

May 29 2023, 05:58 · Good Starter Task, Arcanist

May 28 2023

aklapper added a revision to T15268: Typo in English string "Lock '%s is not locked by this process!": D25253: Correct spelling mistake in PhutilLock.
May 28 2023, 13:32 · Good Starter Task, Arcanist
aklapper added a revision to T15346: PHP 8.1 exceptions in JsonLint block rendering Tab Panels in Dashboards: D25250: Fix PHP 8.1 null exceptions which block rendering tab panels on dashboards.
May 28 2023, 13:02 · Arcanist, PHP 8 support
aklapper updated the task description for T15346: PHP 8.1 exceptions in JsonLint block rendering Tab Panels in Dashboards.
May 28 2023, 12:45 · Arcanist, PHP 8 support

May 27 2023

valerio.bozzolan closed Q57: PHP 8.1 "strlen(null)" exception when running "arc diff" with no active branch as resolved.
May 27 2023, 19:21 · Arcanist

May 25 2023

valerio.bozzolan updated the task description for T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies.
May 25 2023, 09:20 · Documentation, PHP 8 support, Arcanist, User-valerio.bozzolan

May 24 2023

Restricted Repository Identity closed T15412: PHP 8.1 "strlen(null)" exception when running "arc diff" with no active branch, a subtask of T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo), as Resolved.
May 24 2023, 19:06 · PHP 8 support, Arcanist, User-valerio.bozzolan

May 23 2023

valerio.bozzolan added a comment to Q57: PHP 8.1 "strlen(null)" exception when running "arc diff" with no active branch.

If you want additional glory, feel free to add an answer below, mentioning your task and your patch. Thanks again :) and feel free to land, since it's approved now (arc land).

May 23 2023, 20:22 · Arcanist
valerio.bozzolan added a subtask for T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo): T15412: PHP 8.1 "strlen(null)" exception when running "arc diff" with no active branch.
May 23 2023, 12:52 · PHP 8 support, Arcanist, User-valerio.bozzolan
jkimbo added a comment to Q57: PHP 8.1 "strlen(null)" exception when running "arc diff" with no active branch.

Created T15412 and D25237 to fix this issue.

May 23 2023, 12:46 · Arcanist
jkimbo added a comment to Q57: PHP 8.1 "strlen(null)" exception when running "arc diff" with no active branch.

Thanks!

May 23 2023, 12:38 · Arcanist
valerio.bozzolan moved T15281: $HOME missing from commands issued by ExecFuture from Backlog to PingDeath 🌚 on the User-valerio.bozzolan board.
May 23 2023, 09:52 · User-valerio.bozzolan, Arcanist
valerio.bozzolan added a comment to Q57: PHP 8.1 "strlen(null)" exception when running "arc diff" with no active branch.

Whooops, added! :)

May 23 2023, 08:52 · Arcanist
jkimbo added a comment to Q57: PHP 8.1 "strlen(null)" exception when running "arc diff" with no active branch.

@valerio.bozzolan have you added me to the Trusted Contributors group? I don't seem to have the permission to create any new tasks. Happy to create the task for this bug and the diff to fix it.

May 23 2023, 08:40 · Arcanist

May 22 2023

valerio.bozzolan added a comment to Q57: PHP 8.1 "strlen(null)" exception when running "arc diff" with no active branch.

Hi @jkimbo thank you for your bug report. Now you are a Trusted Contributors. Feel free to elevate this question as a Task under PHP 8 support

May 22 2023, 12:37 · Arcanist
jkimbo asked Q57: PHP 8.1 "strlen(null)" exception when running "arc diff" with no active branch.
May 22 2023, 10:40 · Arcanist
20after4 added a comment to T15364: arc land complaints summary by FreeBSD community.
In T15364#8952, @avivey wrote:

"tooling for chains of diffs" might need its own topic, with a design of the what the whole thing should look like in an ideal world, and how to get to it.
Even if not all of the stuff fits nicely into Phorge, there's probably a lot that can work, and some conduit methods can be added to implement the rest.

May 22 2023, 01:32 · Arcanist, Differential, Affects-FreeBSD

May 15 2023

avivey added a comment to T15364: arc land complaints summary by FreeBSD community.

"tooling for chains of diffs" might need its own topic, with a design of the what the whole thing should look like in an ideal world, and how to get to it.
Even if not all of the stuff fits nicely into Phorge, there's probably a lot that can work, and some conduit methods can be added to implement the rest.

May 15 2023, 20:07 · Arcanist, Differential, Affects-FreeBSD
ton added a comment to T15364: arc land complaints summary by FreeBSD community.

Chaining Diffs is something that we would like to use more often, and it is definitely not used enough today. FreeBSD is a large codebase and making any change that is bigger than trivial often involves touching multiple parts of the system, the most difficult kind of change is architectural changes. We are limited by our tooling to a certain degree:

  • Keeping everything in one Diff makes it very difficult to review as well as reach consensus, as there are often multiple responsible parties involved. It also violates the ethos of Phab/Phorge of having small atomic changes.
  • Breaking changes down in smaller chunks has lots of downsides too - it is very hard to track and changes often get lost in depths of Differential.
May 15 2023, 19:55 · Arcanist, Differential, Affects-FreeBSD
avivey added a comment to T15364: arc land complaints summary by FreeBSD community.

mmm... I've never really worked where many changes are made of lots of dependent revisions - it's possible I've never even seen a chain of 3 revisions in the same repo. So I'm not sure about workflows for this kind of scenarios.

May 15 2023, 19:43 · Arcanist, Differential, Affects-FreeBSD
bsdimp added a comment to T15364: arc land complaints summary by FreeBSD community.

Yea, today I have about 50 lines of shell scripting that gets the different bits of data from the condon API point and then bashes them into a nearly acceptable commit message....

May 15 2023, 19:37 · Arcanist, Differential, Affects-FreeBSD
avivey added a comment to T15364: arc land complaints summary by FreeBSD community.

Ok, so here's my thoughts on moving this forward:

May 15 2023, 06:56 · Arcanist, Differential, Affects-FreeBSD

May 10 2023

avivey closed T15241: arc tab-complete hangs on some flows as Invalid.

It hadn't happened in a while, so I guess it was something strange in my machine.

May 10 2023, 18:21 · Bug Reports, Arcanist

May 9 2023

ton updated subscribers of T15364: arc land complaints summary by FreeBSD community.
May 9 2023, 18:48 · Arcanist, Differential, Affects-FreeBSD
ton updated subscribers of T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..
May 9 2023, 18:47 · Discussion Needed, Arcanist
avivey removed a project from T15335: PHP 8.1 null parameter exceptions block rendering the "Browse Projects" overlay dialog: Phorge.
May 9 2023, 10:42 · Arcanist, PHP 8 support
valerio.bozzolan closed T15367: PHP 8.1 fix strpos(NULL, string) called at [<arcanist>/src/xsprintf/PhutilCommandString.php:98], a subtask of T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo), as Resolved.
May 9 2023, 06:29 · PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan closed T15367: PHP 8.1 fix strpos(NULL, string) called at [<arcanist>/src/xsprintf/PhutilCommandString.php:98] as Resolved by committing rARCc14785c3795c: Fix PHP 8.1 "strpos(null)" exception from PhutilCommandString which blocks arc….
May 9 2023, 06:29 · PHP 8 support, Arcanist, User-valerio.bozzolan

May 8 2023

valerio.bozzolan added a comment to T15239: phutil_nonempty_scalar() should never throw an exception with valid scalars (like booleans).

By the way the only usages are:

May 8 2023, 20:19 · User-valerio.bozzolan, Arcanist
20after4 added a comment to T15364: arc land complaints summary by FreeBSD community.

FWIW I think the test plan is configurable (that requirement can be disabled in phabricator's config server side which should remove it from commit messages in arc)

May 8 2023, 18:21 · Arcanist, Differential, Affects-FreeBSD
valerio.bozzolan placed T15367: PHP 8.1 fix strpos(NULL, string) called at [<arcanist>/src/xsprintf/PhutilCommandString.php:98] up for grabs.

Yeah no problem!

May 8 2023, 17:14 · PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan added a comment to T15368: PHP 8.1 fix PhutilUTF8StringTruncator::truncateString(NULL) called at [<arcanist>/src/ref/ArcanistRefView.php:103].

Hi @aklapper. Are you affected by this as well?

May 8 2023, 17:07 · PHP 8 support, Arcanist, User-valerio.bozzolan
ton reopened T15367: PHP 8.1 fix strpos(NULL, string) called at [<arcanist>/src/xsprintf/PhutilCommandString.php:98], a subtask of T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo), as Open.
May 8 2023, 17:07 · PHP 8 support, Arcanist, User-valerio.bozzolan
ton reopened T15367: PHP 8.1 fix strpos(NULL, string) called at [<arcanist>/src/xsprintf/PhutilCommandString.php:98] as "Open".

@valerio.bozzolan right, I forgot the important bit, sorry :D

May 8 2023, 17:07 · PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan added a comment to T15367: PHP 8.1 fix strpos(NULL, string) called at [<arcanist>/src/xsprintf/PhutilCommandString.php:98].

Note that probably @ton you have resolved, but anybody else nope :D The patch D25205 still needs review and land

May 8 2023, 17:06 · PHP 8 support, Arcanist, User-valerio.bozzolan
ton closed T15367: PHP 8.1 fix strpos(NULL, string) called at [<arcanist>/src/xsprintf/PhutilCommandString.php:98], a subtask of T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo), as Resolved.
May 8 2023, 17:06 · PHP 8 support, Arcanist, User-valerio.bozzolan
ton closed T15367: PHP 8.1 fix strpos(NULL, string) called at [<arcanist>/src/xsprintf/PhutilCommandString.php:98] as Resolved.
May 8 2023, 17:06 · PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan updated the task description for T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo).
May 8 2023, 17:04 · PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan added a revision to T15368: PHP 8.1 fix PhutilUTF8StringTruncator::truncateString(NULL) called at [<arcanist>/src/ref/ArcanistRefView.php:103]: D25206: Fix PHP 8.1 "strlen(null)" exception from ArcanistRefView which blocks "arc look remotes".
May 8 2023, 17:04 · PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan added a revision to T15367: PHP 8.1 fix strpos(NULL, string) called at [<arcanist>/src/xsprintf/PhutilCommandString.php:98]: D25205: Fix PHP 8.1 "strpos(null)" exception from PhutilCommandString which blocks arc patch.
May 8 2023, 16:53 · PHP 8 support, Arcanist, User-valerio.bozzolan