Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception from ArcanistRefView which blocks "arc look remotes"

Authored by valerio.bozzolan on May 8 2023, 17:04.
Referenced Files
Unknown Object (File)
Thu, Jun 13, 12:47
Unknown Object (File)
Wed, Jun 12, 20:15
Unknown Object (File)
Wed, Jun 12, 15:30
Unknown Object (File)
Wed, Jun 12, 10:47
Unknown Object (File)
Tue, Jun 11, 11:43
Unknown Object (File)
Sun, Jun 9, 20:06
Unknown Object (File)
Fri, May 31, 20:04
Unknown Object (File)
Thu, May 30, 11:36



This change fixes the command arc look remotes for PHP 8.1.

Without this change, the null value bubbles up to PhutilUTF8StringTruncator, reaching a strlen().

This control probably does not need to be done at this low level inside PhutilUTF8StringTruncator,
but it is right to be at this high level from the caller in ArcanistRefView.

Closes T15368

Test Plan
  • run "arc look remotes"
  • still works in "old PHP" like 7.4
  • start to work in recent PHP 8.1+

Diff Detail

rARC Arcanist
Lint Not Applicable
Tests Not Applicable

Event Timeline


↑ here the problematic area - this should not receive null

Hi @Matthew :D super-safe thing here. Do you love this?

I think @speck maybe has better approaches here (do you know arc look? it's lovely)

This revision is now accepted and ready to land.Jun 1 2023, 15:38