Page MenuHomePhorge
Feed All Stories

All Stories
Use Results
Edit Query

Aug 18 2023

valerio.bozzolan committed rP3cc5ee6a33df: Documentation: fix unexisting path sshd_config.phabricator.example.
Documentation: fix unexisting path sshd_config.phabricator.example
Aug 18 2023, 16:02
Sten closed T15617: arc patch fails when binary files are added/removed with PHP 8.1 strlen(null) as Resolved by committing rARC8b907d771661: Fix PHP 8.1 arc patch strlen(null) binary file error.
Aug 18 2023, 13:58 · PHP 8 support
Sten closed T15617: arc patch fails when binary files are added/removed with PHP 8.1 strlen(null), a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3, as Resolved.
Aug 18 2023, 13:58 · PHP 8 support
Sten closed D25409: Fix PHP 8.1 arc patch strlen(null) binary file error.
Aug 18 2023, 13:58
Sten committed rARC8b907d771661: Fix PHP 8.1 arc patch strlen(null) binary file error.
Fix PHP 8.1 arc patch strlen(null) binary file error
Aug 18 2023, 13:58
bob updated the test plan for D25400: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.
Aug 18 2023, 13:51
bob closed T15608: PHP 8.2 "strlen(): Passing null to parameter #1 ($string) of type string is deprecated" in subversion repository, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3, as Resolved.
Aug 18 2023, 13:50 · PHP 8 support
bob closed T15608: PHP 8.2 "strlen(): Passing null to parameter #1 ($string) of type string is deprecated" in subversion repository as Resolved by committing rP8876f75fbb99: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.
Aug 18 2023, 13:50 · PHP 8 support
bob closed D25398: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.
Aug 18 2023, 13:50
bob committed rP8876f75fbb99: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.
Fix a PHP 8.1 deprecated use of strlen with a NULL argument
Aug 18 2023, 13:50
avivey accepted D25398: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.
Aug 18 2023, 13:46
avivey accepted D25410: Documentation: fix unexisting path sshd_config.phabricator.example.
Aug 18 2023, 13:46
avivey accepted D25409: Fix PHP 8.1 arc patch strlen(null) binary file error.
Aug 18 2023, 13:36
Sten accepted D25398: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.

Looks good to me.

Aug 18 2023, 13:06
valerio.bozzolan retitled D25398: Fix a PHP 8.1 deprecated use of strlen with a NULL argument from Fix a PHP 8.1/8.2 deprecated use of strlen with a NULL argument
Aug 18 2023, 11:05
valerio.bozzolan added inline comments to D25410: Documentation: fix unexisting path sshd_config.phabricator.example.
Aug 18 2023, 11:03
valerio.bozzolan retitled D25410: Documentation: fix unexisting path sshd_config.phabricator.example from Documentation: fix unexisting path sshd_config.phabricator.example Since the example file was renamed, this change makes the documentation consistent with it. Also we added exactly one-space somewhere, to create a super-satisfying indentation in...
Aug 18 2023, 11:01
valerio.bozzolan requested review of D25410: Documentation: fix unexisting path sshd_config.phabricator.example.
Aug 18 2023, 11:00
valerio.bozzolan added a revision to T15006: Re-brand Phorge: D25410: Documentation: fix unexisting path sshd_config.phabricator.example.
Aug 18 2023, 11:00 · Phorge
bob added a comment to D25403: Improve CelerityDarkModePostprocessor shade colors.

Ouch ! Thanks for reporting ! I'll have a look on UI examples (these pages are really cool !) to improve the proposal !
BTW, I'll be away next week so... This will not move forward right now...

Aug 18 2023, 10:51
bob closed D25399: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.
Aug 18 2023, 10:48
bob closed T15609: PHP 8.1 "strlen(): Passing null to parameter #1 ($string) of type string is deprecated" in svn commit viewer, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3, as Resolved.
Aug 18 2023, 10:48 · PHP 8 support
bob closed T15609: PHP 8.1 "strlen(): Passing null to parameter #1 ($string) of type string is deprecated" in svn commit viewer as Resolved by committing rP6ec89e9f0866: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.
Aug 18 2023, 10:48 · PHP 8 support
bob committed rP6ec89e9f0866: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.
Fix a PHP 8.1 deprecated use of strlen with a NULL argument
Aug 18 2023, 10:48
bob added a comment to D25399: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.

Great, let's prepare for landing ! BTW, I like your images, espacially this one...

Aug 18 2023, 10:47
valerio.bozzolan accepted D25399: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.

Yeah anyway this looks great

Aug 18 2023, 10:35
Sten added a comment to D25409: Fix PHP 8.1 arc patch strlen(null) binary file error.
In D25409#11652, @avivey wrote:

I think phutil_nonempty_string fails faster then strlen (strlen allowing automatic conversion of string-like things to string and phutil_nonempty_string doesn't), but I'm a little confused right now...

Aug 18 2023, 10:12
Sten created Image Macro "technicallycorrect".
Aug 18 2023, 10:11
Sten updated the diff for D25409: Fix PHP 8.1 arc patch strlen(null) binary file error.

Switch to using phutil_nonempty_string

Aug 18 2023, 10:06
valerio.bozzolan accepted D25387: Error handling: send Deprecation messages as explicit Event.

SUPER NICE \o/ THANKS

Aug 18 2023, 09:58
valerio.bozzolan accepted D25386: log deprecation events in Dark Console.

Tested with and without D25387.

Aug 18 2023, 09:47
valerio.bozzolan added inline comments to D25305: Workboard: have thin scrollbars.
Aug 18 2023, 09:35
avivey added a comment to D25409: Fix PHP 8.1 arc patch strlen(null) binary file error.

I think phutil_nonempty_string fails faster then strlen (strlen allowing automatic conversion of string-like things to string and phutil_nonempty_string doesn't), but I'm a little confused right now...

Aug 18 2023, 09:32
Sten updated the task description for T15617: arc patch fails when binary files are added/removed with PHP 8.1 strlen(null).
Aug 18 2023, 09:21 · PHP 8 support
Sten added a comment to D25409: Fix PHP 8.1 arc patch strlen(null) binary file error.
In D25409#11648, @avivey wrote:

phutil_nonempty_string is basically the exact same thing, but with stricter type control

Aug 18 2023, 09:19
Sten added a comment to D25409: Fix PHP 8.1 arc patch strlen(null) binary file error.
Aug 18 2023, 09:14
aklapper created T15619: Calendar: Impossible to import .ics file (Phorge checks for a non-existing remote URI).
Aug 18 2023, 09:13 · Affects-Wikimedia, Bug Reports, Calendar
avivey added a comment to D25409: Fix PHP 8.1 arc patch strlen(null) binary file error.

phutil_nonempty_string is basically the exact same thing, but with stricter type control

Aug 18 2023, 09:10
Sten updated the summary of D25409: Fix PHP 8.1 arc patch strlen(null) binary file error.
Aug 18 2023, 09:09
Sten added a revision to T15617: arc patch fails when binary files are added/removed with PHP 8.1 strlen(null): D25409: Fix PHP 8.1 arc patch strlen(null) binary file error.
Aug 18 2023, 09:09 · PHP 8 support
avivey added a project to T15618: Lots of "Unknown Object"s referenced from revisions: Differential.
Aug 18 2023, 09:07 · Differential, Bug Reports
avivey created T15618: Lots of "Unknown Object"s referenced from revisions.
Aug 18 2023, 09:07 · Differential, Bug Reports
Sten added inline comments to D25409: Fix PHP 8.1 arc patch strlen(null) binary file error.
Aug 18 2023, 09:05
Sten requested review of D25409: Fix PHP 8.1 arc patch strlen(null) binary file error.
Aug 18 2023, 09:02
avivey closed D25343: Rebrand: Add "path" entries to PlatformSymbols.
Aug 18 2023, 09:00
avivey committed rPad0052fcd643: Rebrand: Add "path" entries to PlatformSymbols.
Rebrand: Add "path" entries to PlatformSymbols
Aug 18 2023, 09:00
Sten claimed T15617: arc patch fails when binary files are added/removed with PHP 8.1 strlen(null).
Aug 18 2023, 08:58 · PHP 8 support
Sten created T15617: arc patch fails when binary files are added/removed with PHP 8.1 strlen(null).
Aug 18 2023, 08:58 · PHP 8 support
valerio.bozzolan requested review of D25408: Fix Exception in Chat room when you are not a Participant.
Aug 18 2023, 08:55
valerio.bozzolan added a revision to T15497: Exception when viewing incoming Chat room messages, when not in Participants: D25408: Fix Exception in Chat room when you are not a Participant.
Aug 18 2023, 08:55 · Conpherence
valerio.bozzolan renamed T15497: Exception when viewing incoming Chat room messages, when not in Participants from Exception when opening room to Exception when viewing incoming Chat room messages, when not in Participants.
Aug 18 2023, 08:52 · Conpherence
valerio.bozzolan updated subscribers of T15497: Exception when viewing incoming Chat room messages, when not in Participants.

This happened some minutes ago to our friend @waldyrious and I was able to reproduce it on my local computer. I've attached my reproducing instructions.

Aug 18 2023, 08:50 · Conpherence
valerio.bozzolan triaged T15497: Exception when viewing incoming Chat room messages, when not in Participants as Normal priority.
Aug 18 2023, 08:48 · Conpherence
valerio.bozzolan added a comment to D25343: Rebrand: Add "path" entries to PlatformSymbols.

Maybe to be it consistent with "super-rebranded-product/" :D I don't know

Aug 18 2023, 08:46
avivey added a comment to D25343: Rebrand: Add "path" entries to PlatformSymbols.

I don't understand why the pht was there - it's a "path", why would it be translated?

Aug 18 2023, 08:45
waldyrious changed the visibility for F336320: Screenshot from 2023-08-18 16-05-43.png.
Aug 18 2023, 08:10
valerio.bozzolan updated the test plan for D25079: Trigger: Add Sound "Coin".
Aug 18 2023, 07:58
valerio.bozzolan added a comment to T15616: PHP 8.1 "strlen(null)" exception when setting up Phorge locally.

Yeah fixed in D25104

Aug 18 2023, 07:51 · PHP 8 support
valerio.bozzolan updated the diff for D25079: Trigger: Add Sound "Coin".

I've just:

Aug 18 2023, 07:51
aklapper closed T15614: PHP 8.1 "strlen(null)" exception creating a Phriction doc without slug in Conduit, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3, as Resolved.
Aug 18 2023, 07:50 · PHP 8 support
aklapper closed T15614: PHP 8.1 "strlen(null)" exception creating a Phriction doc without slug in Conduit as Resolved by committing rP7c58ea140374: Fix PHP 8.1 "strlen(null)" exception creating a Phriction doc without slug in….
Aug 18 2023, 07:50 · PHP 8 support
aklapper closed D25406: Fix PHP 8.1 "strlen(null)" exception creating a Phriction doc without slug in Conduit.
Aug 18 2023, 07:50
aklapper committed rP7c58ea140374: Fix PHP 8.1 "strlen(null)" exception creating a Phriction doc without slug in….
Fix PHP 8.1 "strlen(null)" exception creating a Phriction doc without slug in…
Aug 18 2023, 07:50
waldyrious closed T15616: PHP 8.1 "strlen(null)" exception when setting up Phorge locally, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3, as Resolved.
Aug 18 2023, 07:50 · PHP 8 support
waldyrious closed T15616: PHP 8.1 "strlen(null)" exception when setting up Phorge locally as Resolved.

Oops, sorry, I was not on master. I was actually testing out D25079. This is already fixed on master, by @valerio.bozzolan.

Aug 18 2023, 07:50 · PHP 8 support
aklapper closed T15613: PHP 8.1 "strlen(null)" exception creating a Paste without content in Conduit, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3, as Resolved.
Aug 18 2023, 07:48 · PHP 8 support
aklapper closed T15613: PHP 8.1 "strlen(null)" exception creating a Paste without content in Conduit as Resolved by committing rPd84dbf8e27ba: Fix PHP 8.1 "strlen(null)" exception creating a Paste without content in….
Aug 18 2023, 07:48 · PHP 8 support
aklapper closed D25405: Fix PHP 8.1 "strlen(null)" exception creating a Paste without content in Conduit paste.create.
Aug 18 2023, 07:48
aklapper committed rPd84dbf8e27ba: Fix PHP 8.1 "strlen(null)" exception creating a Paste without content in….
Fix PHP 8.1 "strlen(null)" exception creating a Paste without content in…
Aug 18 2023, 07:48
valerio.bozzolan awarded T15616: PHP 8.1 "strlen(null)" exception when setting up Phorge locally a Cup of Joe token.
Aug 18 2023, 07:44 · PHP 8 support
waldyrious created T15616: PHP 8.1 "strlen(null)" exception when setting up Phorge locally.
Aug 18 2023, 07:44 · PHP 8 support
valerio.bozzolan renamed T15609: PHP 8.1 "strlen(): Passing null to parameter #1 ($string) of type string is deprecated" in svn commit viewer from PHP 8.2 "strlen(): Passing null to parameter #1 ($string) of type string is deprecated" in svn commit viewer to PHP 8.1 "strlen(): Passing null to parameter #1 ($string) of type string is deprecated" in svn commit viewer.
Aug 18 2023, 07:41 · PHP 8 support
valerio.bozzolan updated the test plan for D25079: Trigger: Add Sound "Coin".
Aug 18 2023, 07:38
valerio.bozzolan added a member for Trusted Contributors: waldyrious.
Aug 18 2023, 07:32
valerio.bozzolan updated the diff for D25305: Workboard: have thin scrollbars.

git rebase master

Aug 18 2023, 07:21
bob closed T15605: PHP 8.1 "strlen(null)" exception when deploying a new instance of Phorge, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3, as Resolved.
Aug 18 2023, 07:20 · PHP 8 support
bob closed T15605: PHP 8.1 "strlen(null)" exception when deploying a new instance of Phorge as Resolved by committing rP0ef08baf6452: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.
Aug 18 2023, 07:20 · PHP 8 support
bob closed D25394: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.
Aug 18 2023, 07:20
bob committed rP0ef08baf6452: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.
Fix a PHP 8.1 deprecated use of strlen with a NULL argument
Aug 18 2023, 07:20
bob closed D25401: Fix a PHP 8.1/8.2 deprecated use of strlen a NULL argument.
Aug 18 2023, 07:20
bob committed rP7f46a252f21e: Fix a PHP 8.1/8.2 deprecated use of strlen a NULL argument.
Fix a PHP 8.1/8.2 deprecated use of strlen a NULL argument
Aug 18 2023, 07:20
valerio.bozzolan requested changes to D25403: Improve CelerityDarkModePostprocessor shade colors.

Let's visually mark this as needing still some work

Aug 18 2023, 07:18
valerio.bozzolan accepted D25401: Fix a PHP 8.1/8.2 deprecated use of strlen a NULL argument.

Thanks bob! You are a good minion. As discussed previously, this is used only in one point and without any argument:

Aug 18 2023, 07:16
bob added a comment to D25394: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.

Great news ! I'll land it right now !

Aug 18 2023, 07:16
valerio.bozzolan accepted D25394: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.

I've tested this in place with my eyes on a friend's laptop with PHP 8.1 in the very same problem

Aug 18 2023, 06:26
valerio.bozzolan added a comment to D25403: Improve CelerityDarkModePostprocessor shade colors.

Nice job, my little and cute bob.. OH NO! a super-important regression! all of you minions will be fired soon!1!

Aug 18 2023, 04:43
valerio.bozzolan updated the name of F336217: Overcard Maniphest regress.png from "image.png" to "Overcard Maniphest regress.png".
Aug 18 2023, 04:43
valerio.bozzolan updated the test plan for D25403: Improve CelerityDarkModePostprocessor shade colors.
Aug 18 2023, 04:40
valerio.bozzolan accepted D25405: Fix PHP 8.1 "strlen(null)" exception creating a Paste without content in Conduit paste.create.

OK I've found that this is about the legacy Conduit entry point for Paste.

Aug 18 2023, 02:59
valerio.bozzolan retitled D25405: Fix PHP 8.1 "strlen(null)" exception creating a Paste without content in Conduit paste.create from Fix PHP 8.1 "strlen(null)" exception creating a Paste without content in Conduit
Aug 18 2023, 02:51
valerio.bozzolan added a comment to D25405: Fix PHP 8.1 "strlen(null)" exception creating a Paste without content in Conduit paste.create.

I'm not able to trigger that part of the code.

Aug 18 2023, 02:49
valerio.bozzolan created P21 Command-Line Input.
Aug 18 2023, 02:42
valerio.bozzolan created P20 Command-Line Input.
Aug 18 2023, 02:39
valerio.bozzolan accepted D25406: Fix PHP 8.1 "strlen(null)" exception creating a Phriction doc without slug in Conduit.

Tested with and without a value, thaaanks \o/

Aug 18 2023, 02:11
valerio.bozzolan closed T15615: Mobile: Differential lines should not be wrapped as Resolved by committing rP761134a1a9fe: Line counters: do not wrap when over 999 on mobile.
Aug 18 2023, 01:54 · UX, Differential
valerio.bozzolan closed D25407: Line counters: do not wrap when over 999 on mobile.
Aug 18 2023, 01:54
valerio.bozzolan committed rP761134a1a9fe: Line counters: do not wrap when over 999 on mobile.
Line counters: do not wrap when over 999 on mobile
Aug 18 2023, 01:54

Aug 17 2023

avivey accepted D25407: Line counters: do not wrap when over 999 on mobile.
Aug 17 2023, 18:30
valerio.bozzolan requested review of D25407: Line counters: do not wrap when over 999 on mobile.
Aug 17 2023, 16:36
valerio.bozzolan added a revision to T15615: Mobile: Differential lines should not be wrapped: D25407: Line counters: do not wrap when over 999 on mobile.
Aug 17 2023, 16:36 · UX, Differential
First
Prev
Next
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0