Page MenuHomePhorge
Feed Advanced Search

May 4 2023

aklapper closed T15338: PHP 8.1 "preg_match()" exception when pasting malformed Raw Diff into "Create Diff" as Resolved by committing rARC084303cd5f27: Fix PHP 8.1 "preg_match()" exception when pasting malformed Raw Diff into….
May 4 2023, 08:56 · Arcanist, PHP 8 support

May 3 2023

aklapper added a revision to T15338: PHP 8.1 "preg_match()" exception when pasting malformed Raw Diff into "Create Diff": D25183: Fix PHP 8.1 "preg_match()" exception when pasting malformed Raw Diff into "Create Diff".
May 3 2023, 19:51 · Arcanist, PHP 8 support
aklapper created T15338: PHP 8.1 "preg_match()" exception when pasting malformed Raw Diff into "Create Diff".
May 3 2023, 19:50 · Arcanist, PHP 8 support
aklapper added a revision to T15331: PHP 8.1 "strlen(null)" exceptions block creating a project with an empty Description field: D25176: Fix PHP 8.1 "strlen(null)" exception which blocks creating a project with an empty Description field.
May 3 2023, 17:03 · Projects, Arcanist, PHP 8 support
aklapper added a revision to T15335: PHP 8.1 null parameter exceptions block rendering the "Browse Projects" overlay dialog: D25180: Do not pass a null string to mb_convert_case() for PHP 8.1 compatibility.
May 3 2023, 14:08 · Arcanist, PHP 8 support
aklapper added a revision to T15335: PHP 8.1 null parameter exceptions block rendering the "Browse Projects" overlay dialog: D25179: Fix PHP 8.1 null parameter exceptions which block rendering the "Browse Projects" overlay dialog.
May 3 2023, 14:02 · Arcanist, PHP 8 support
aklapper created T15335: PHP 8.1 null parameter exceptions block rendering the "Browse Projects" overlay dialog.
May 3 2023, 13:59 · Arcanist, PHP 8 support
chrisnovakovic closed T15333: patch workflow can't download revisions/diffs from Differential if anonymous access is forbidden as Resolved by committing rARC12484acfc8cb: Handle ERR-INVALID-AUTH responses from Conduit in patch workflow.
May 3 2023, 13:49 · Arcanist

May 2 2023

chrisnovakovic added a revision to T15333: patch workflow can't download revisions/diffs from Differential if anonymous access is forbidden: D25178: Handle ERR-INVALID-AUTH responses from Conduit in patch workflow.
May 2 2023, 21:18 · Arcanist
chrisnovakovic claimed T15333: patch workflow can't download revisions/diffs from Differential if anonymous access is forbidden.
May 2 2023, 21:18 · Arcanist
chrisnovakovic created T15333: patch workflow can't download revisions/diffs from Differential if anonymous access is forbidden.
May 2 2023, 21:17 · Arcanist
valerio.bozzolan added a revision to T15331: PHP 8.1 "strlen(null)" exceptions block creating a project with an empty Description field: D25177: Fix PHP 8.1 "strlen(null)" exception which blocks creating a project with an empty Description field.
May 2 2023, 20:42 · Projects, Arcanist, PHP 8 support
aklapper created T15331: PHP 8.1 "strlen(null)" exceptions block creating a project with an empty Description field.
May 2 2023, 19:19 · Projects, Arcanist, PHP 8 support

May 1 2023

valerio.bozzolan removed a subtask for T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo): T15198: PHP 8.2 deprecations fix strategies.
May 1 2023, 15:08 · PHP 8 support, Arcanist, User-valerio.bozzolan
aklapper updated the task description for T15263: PHP 8.1 "rawurlencode(null)" exception in phutil_escape_uri.
May 1 2023, 13:59 · PHP 8 support, Arcanist
aklapper added a revision to T15263: PHP 8.1 "rawurlencode(null)" exception in phutil_escape_uri: D25164: Fix PHP 8.1 "rawurlencode(null)" exception which blocks rendering a project page.
May 1 2023, 13:28 · PHP 8 support, Arcanist

Apr 30 2023

valerio.bozzolan added a comment to T15281: $HOME missing from commands issued by ExecFuture.
In T15281#7096, @speck wrote:

Could you check the server configuration of php.ini for the value of variable_orders? This open task on phab suggests that on servers it should enforce including E causing phab's environment to be passed to sub-commands, but does not want to mess with it on users' machines.

https://secure.phabricator.com/T12071

Apr 30 2023, 22:49 · User-valerio.bozzolan, Arcanist
valerio.bozzolan renamed T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo) from Fix Arcanist in PHP 8.2 (testing the Phorge repo) to Fix Arcanist in PHP 8.1+ (testing the Phorge repo).
Apr 30 2023, 20:40 · PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan added a subtask for T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo): T15263: PHP 8.1 "rawurlencode(null)" exception in phutil_escape_uri.
Apr 30 2023, 20:40 · PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan added a parent task for T15263: PHP 8.1 "rawurlencode(null)" exception in phutil_escape_uri: T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo).
Apr 30 2023, 20:40 · PHP 8 support, Arcanist
valerio.bozzolan added a project to T15263: PHP 8.1 "rawurlencode(null)" exception in phutil_escape_uri: PHP 8 support.
Apr 30 2023, 20:40 · PHP 8 support, Arcanist

Apr 29 2023

valerio.bozzolan added a revision to T15281: $HOME missing from commands issued by ExecFuture: D25149: Config page: add $HOME to allow a gitconfig and help on "dubious ownership".
Apr 29 2023, 23:45 · User-valerio.bozzolan, Arcanist
valerio.bozzolan edited parent tasks for T15281: $HOME missing from commands issued by ExecFuture, added: T15299: Config page runs git commands that should have an HOME to open gitconfig correctly; removed: T15282: Fix/avoid/simplify similar fatal: detected dubious ownership in repository at '/var/www/phorge'.
Apr 29 2023, 23:32 · User-valerio.bozzolan, Arcanist
valerio.bozzolan updated the task description for T15281: $HOME missing from commands issued by ExecFuture.
Apr 29 2023, 22:54 · User-valerio.bozzolan, Arcanist
valerio.bozzolan updated the task description for T15281: $HOME missing from commands issued by ExecFuture.
Apr 29 2023, 20:26 · User-valerio.bozzolan, Arcanist
speck added a comment to T15281: $HOME missing from commands issued by ExecFuture.

Could you check the server configuration of php.ini for the value of variable_orders? This open task on phab suggests that on servers it should enforce including E causing phab's environment to be passed to sub-commands, but does not want to mess with it on users' machines.

Apr 29 2023, 13:58 · User-valerio.bozzolan, Arcanist

Apr 28 2023

valerio.bozzolan moved T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo) from Backlog to Epic on the PHP 8 support board.
Apr 28 2023, 19:24 · PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan moved T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies from Backlog to Epic on the PHP 8 support board.
Apr 28 2023, 19:20 · Documentation, PHP 8 support, Arcanist, User-valerio.bozzolan

Apr 27 2023

valerio.bozzolan added a parent task for T15281: $HOME missing from commands issued by ExecFuture: T15282: Fix/avoid/simplify similar fatal: detected dubious ownership in repository at '/var/www/phorge'.
Apr 27 2023, 08:02 · User-valerio.bozzolan, Arcanist
valerio.bozzolan triaged T15281: $HOME missing from commands issued by ExecFuture as Normal priority.
Apr 27 2023, 07:55 · User-valerio.bozzolan, Arcanist

Apr 26 2023

aklapper renamed T15239: phutil_nonempty_scalar() should never throw an exception with valid scalars (like booleans) from phutil_nonempty_scalar() shoud never throw an exception with valid scalars (like booleans) to phutil_nonempty_scalar() should never throw an exception with valid scalars (like booleans).
Apr 26 2023, 09:55 · User-valerio.bozzolan, Arcanist
avivey closed T15124: arc-browse is broken here as Invalid.

I can no longer reproduce this, so I'm guessing it was something bad in my setup.

Apr 26 2023, 09:03 · Arcanist, phorge.it install

Apr 25 2023

aklapper closed T15260: PHP 8.1 "strlen(null)" exception in PhutilOpaqueEnvelope.php as Resolved by committing rARC82d1abd4edd1: Fix PHP 8.1 "strlen(null)" exception in PhutilOpaqueEnvelope.php.
Apr 25 2023, 13:40 · Arcanist
aklapper created T15268: Typo in English string "Lock '%s is not locked by this process!".
Apr 25 2023, 09:43 · Good Starter Task, Arcanist

Apr 21 2023

aklapper updated the task description for T15263: PHP 8.1 "rawurlencode(null)" exception in phutil_escape_uri.
Apr 21 2023, 19:53 · PHP 8 support, Arcanist
aklapper created T15263: PHP 8.1 "rawurlencode(null)" exception in phutil_escape_uri.
Apr 21 2023, 19:51 · PHP 8 support, Arcanist
aklapper added a revision to T15260: PHP 8.1 "strlen(null)" exception in PhutilOpaqueEnvelope.php : D25129: Fix PHP 8.1 "strlen(null)" exception in PhutilOpaqueEnvelope.php.
Apr 21 2023, 17:35 · Arcanist
aklapper created T15260: PHP 8.1 "strlen(null)" exception in PhutilOpaqueEnvelope.php .
Apr 21 2023, 17:32 · Arcanist

Apr 20 2023

valerio.bozzolan added a comment to T15259: arc patch broken on php 8.2 when certificate is uninstalled.

Dear @goddenrich you are now mentioned in the Change Log > 2023 Week 2 :) Thanks again

Apr 20 2023, 16:08 · PHP 8 support, Arcanist
valerio.bozzolan renamed T15259: arc patch broken on php 8.2 when certificate is uninstalled from arc patch broken on php 8.2 to arc patch broken on php 8.2 when certificate is uninstalled.
Apr 20 2023, 16:06 · PHP 8 support, Arcanist
valerio.bozzolan added a comment to T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo).

Wow. Probably this can be considered resolved.

Apr 20 2023, 11:35 · PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan updated the task description for T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo).
Apr 20 2023, 11:35 · PHP 8 support, Arcanist, User-valerio.bozzolan
goddenrich closed T15259: arc patch broken on php 8.2 when certificate is uninstalled, a subtask of T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo), as Resolved.
Apr 20 2023, 10:18 · PHP 8 support, Arcanist, User-valerio.bozzolan
goddenrich closed T15259: arc patch broken on php 8.2 when certificate is uninstalled as Resolved by committing rARCca5f5cd1522c: Fix idx default empty string in ArcanistWorkflow.
Apr 20 2023, 10:18 · PHP 8 support, Arcanist

Apr 19 2023

valerio.bozzolan updated the task description for T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo).
Apr 19 2023, 21:08 · PHP 8 support, Arcanist, User-valerio.bozzolan
goddenrich added a revision to T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies: D25128: Fix idx default empty string in ArcanistWorkflow.
Apr 19 2023, 17:12 · Documentation, PHP 8 support, Arcanist, User-valerio.bozzolan
goddenrich added a revision to T15259: arc patch broken on php 8.2 when certificate is uninstalled: D25128: Fix idx default empty string in ArcanistWorkflow.
Apr 19 2023, 17:09 · PHP 8 support, Arcanist
goddenrich added a subtask for T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo): T15259: arc patch broken on php 8.2 when certificate is uninstalled.
Apr 19 2023, 17:06 · PHP 8 support, Arcanist, User-valerio.bozzolan
goddenrich added a parent task for T15259: arc patch broken on php 8.2 when certificate is uninstalled: T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo).
Apr 19 2023, 17:06 · PHP 8 support, Arcanist
goddenrich created T15259: arc patch broken on php 8.2 when certificate is uninstalled.
Apr 19 2023, 17:05 · PHP 8 support, Arcanist
goddenrich closed T15257: arc lint broken on php 8.2, a subtask of T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo), as Resolved.
Apr 19 2023, 16:21 · PHP 8 support, Arcanist, User-valerio.bozzolan
goddenrich closed T15257: arc lint broken on php 8.2 as Resolved by committing rARC75af13abe917: Fix early exit from getMatchSeverity on null severity.
Apr 19 2023, 16:21 · PHP 8 support, Arcanist
valerio.bozzolan added a revision to T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies: D25126: Fix early exit from getMatchSeverity on null severity.
Apr 19 2023, 15:11 · Documentation, PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan triaged T15257: arc lint broken on php 8.2 as Normal priority.
Apr 19 2023, 11:04 · PHP 8 support, Arcanist

Apr 18 2023

goddenrich added a revision to T15257: arc lint broken on php 8.2: D25126: Fix early exit from getMatchSeverity on null severity.
Apr 18 2023, 18:02 · PHP 8 support, Arcanist
valerio.bozzolan added a comment to T15257: arc lint broken on php 8.2.

I think that @goddenrich is executing a lint on a personal private project, so it's not easy for you to share the project itself, to reproduce this quickly. Isn't it?

Apr 18 2023, 15:35 · PHP 8 support, Arcanist
avivey updated the task description for T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo).
Apr 18 2023, 15:27 · PHP 8 support, Arcanist, User-valerio.bozzolan
avivey created T15257: arc lint broken on php 8.2.
Apr 18 2023, 15:26 · PHP 8 support, Arcanist
20after4 added a comment to T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..

@ton welcome, glad to have your input here.

Apr 18 2023, 05:45 · Discussion Needed, Arcanist

Apr 15 2023

valerio.bozzolan moved T15239: phutil_nonempty_scalar() should never throw an exception with valid scalars (like booleans) from Backlog to PingDeath 🌚 on the User-valerio.bozzolan board.
Apr 15 2023, 20:53 · User-valerio.bozzolan, Arcanist

Apr 14 2023

valerio.bozzolan added a project to T15239: phutil_nonempty_scalar() should never throw an exception with valid scalars (like booleans): User-valerio.bozzolan.
Apr 14 2023, 20:21 · User-valerio.bozzolan, Arcanist
valerio.bozzolan added a project to T15253: Commit hook is sometime broken: InvalidArgumentException: User-valerio.bozzolan.
Apr 14 2023, 20:21 · User-valerio.bozzolan, Bug Reports, Arcanist
valerio.bozzolan closed T15254: Fix arc patch in PHP 8.2: "preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated", a subtask of T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo), as Resolved.
Apr 14 2023, 20:13 · PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan closed T15254: Fix arc patch in PHP 8.2: "preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated" as Resolved by committing rARCf4a639944de4: Fix a PHP 8.1 issue related to preg_match() and null subject.
Apr 14 2023, 20:13 · PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan closed T15253: Commit hook is sometime broken: InvalidArgumentException as Resolved by committing rPa5c93dea568b: Fix InvalidArgumentException on commit hook.
Apr 14 2023, 20:09 · User-valerio.bozzolan, Bug Reports, Arcanist
valerio.bozzolan removed a parent task for T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies: T15226: Fix Diviner creation in PHP 8.1: strlen(): passing null to parameter #1 is deprecated - DivinerGenerateWorkflow.php:197.
Apr 14 2023, 15:19 · Documentation, PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan added a parent task for T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies: T15255: Fix Diviner generation in PHP 8.
Apr 14 2023, 15:18 · Documentation, PHP 8 support, Arcanist, User-valerio.bozzolan
ton updated subscribers of T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..
Apr 14 2023, 14:47 · Discussion Needed, Arcanist
valerio.bozzolan moved T15254: Fix arc patch in PHP 8.2: "preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated" from Backlog to PingDeath 🌚 on the User-valerio.bozzolan board.
Apr 14 2023, 14:13 · PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan added a revision to T15254: Fix arc patch in PHP 8.2: "preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated": D25123: Fix a PHP 8.1 issue related to preg_match() and null subject.
Apr 14 2023, 14:10 · PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan updated the task description for T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo).
Apr 14 2023, 14:09 · PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan triaged T15254: Fix arc patch in PHP 8.2: "preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated" as High priority.
Apr 14 2023, 14:09 · PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan added a revision to T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo): D25123: Fix a PHP 8.1 issue related to preg_match() and null subject.
Apr 14 2023, 14:02 · PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan renamed T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies from PHP 8.1: strlen() does not accept NULL anymore - understand fix strategies to PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies.
Apr 14 2023, 13:54 · Documentation, PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan updated the task description for T15253: Commit hook is sometime broken: InvalidArgumentException.
Apr 14 2023, 12:50 · User-valerio.bozzolan, Bug Reports, Arcanist
valerio.bozzolan added a revision to T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies: D25122: Fix InvalidArgumentException on commit hook.
Apr 14 2023, 12:50 · Documentation, PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan added a comment to T15253: Commit hook is sometime broken: InvalidArgumentException.

Let's put another red warning in T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies

Apr 14 2023, 12:50 · User-valerio.bozzolan, Bug Reports, Arcanist
valerio.bozzolan updated the task description for T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies.
Apr 14 2023, 12:49 · Documentation, PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan added a revision to T15253: Commit hook is sometime broken: InvalidArgumentException: D25122: Fix InvalidArgumentException on commit hook.
Apr 14 2023, 12:42 · User-valerio.bozzolan, Bug Reports, Arcanist
valerio.bozzolan triaged T15253: Commit hook is sometime broken: InvalidArgumentException as Unbreak Now! priority.
Apr 14 2023, 12:42 · User-valerio.bozzolan, Bug Reports, Arcanist
ton added a comment to T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..

Having been invited to chime in from Q46 I will leave my 2 cents here:

Apr 14 2023, 00:48 · Discussion Needed, Arcanist

Apr 12 2023

Cigaryno added a project to T15244: Arcanist is broken on Subversion when moving a file: Bug Reports.
Apr 12 2023, 16:16 · Bug Reports, Arcanist
avivey added a comment to T15244: Arcanist is broken on Subversion when moving a file.

At least using svn 1.13.0, adding --show-inherited-props to the command doesn't print an error and exits with status 0 from the propget command, but I'm not sure what it actually does.

Apr 12 2023, 11:42 · Bug Reports, Arcanist
valerio.bozzolan added a comment to T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..

Indeed. Thanks for cleaning. Having said that "Moving a file" is not a "specific" use-case for Subversion users. That kind of bug is an indicator that probably shows to us that this component is essentially not usable by a majority of Subversion* cases.

Apr 12 2023, 10:32 · Discussion Needed, Arcanist
avivey removed a parent task for T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo): T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..
Apr 12 2023, 10:28 · PHP 8 support, Arcanist, User-valerio.bozzolan
avivey removed a parent task for T15244: Arcanist is broken on Subversion when moving a file: T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..
Apr 12 2023, 10:28 · Bug Reports, Arcanist
avivey removed subtasks for T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues.: T15244: Arcanist is broken on Subversion when moving a file, T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo), T15174: Phorge←GitHub: create a bot that imports "Pull requests".
Apr 12 2023, 10:28 · Discussion Needed, Arcanist
avivey added a comment to T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..

@valerio.bozzolan - marking all bugs in Arcanist as subtasks of this task is not helpful. This task is about discussing users not being happy about arcanist; No specific bug or specific broken use-case is actually relevant to having users not want to use it, because in almost all cases users either refuse to even try it (so they are not effected the bug).
Bugs that are found and are causing any discomfort are fixed.

Apr 12 2023, 10:28 · Discussion Needed, Arcanist
valerio.bozzolan added a comment to T15244: Arcanist is broken on Subversion when moving a file.

I put this into a subtask of T15096 since it's obvious to me that, without fixing this problem, users simply cannot use Arcanist with Subversion. We cannot just propose to end-users to do not rename a file.

Apr 12 2023, 09:10 · Bug Reports, Arcanist
valerio.bozzolan triaged T15244: Arcanist is broken on Subversion when moving a file as High priority.
Apr 12 2023, 09:09 · Bug Reports, Arcanist

Apr 8 2023

Cigaryno added a project to T15241: arc tab-complete hangs on some flows: Bug Reports.
Apr 8 2023, 12:06 · Bug Reports, Arcanist
Sten added a comment to T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..

Honestly the effort to set up arcanist isn't huge (the flow for setting up your CLI cert couldn't be more perfect and user friendly IMO) and it's all worth it because of the productivity gained by automatic lint fixes, easy patch submission and code review checkouts (arc patch is awesome!)

Apr 8 2023, 10:33 · Discussion Needed, Arcanist
avivey claimed T15241: arc tab-complete hangs on some flows.
Apr 8 2023, 07:37 · Bug Reports, Arcanist

Apr 7 2023

valerio.bozzolan added a comment to T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies.

Basically phutil_nonempty_scalar() cannot be used since, instead of returning false when receiving false, it explodes.

Apr 7 2023, 16:46 · Documentation, PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan added a parent task for T15239: phutil_nonempty_scalar() should never throw an exception with valid scalars (like booleans): T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies.
Apr 7 2023, 16:45 · User-valerio.bozzolan, Arcanist
valerio.bozzolan added a subtask for T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies: T15239: phutil_nonempty_scalar() should never throw an exception with valid scalars (like booleans).
Apr 7 2023, 16:45 · Documentation, PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan updated the task description for T15239: phutil_nonempty_scalar() should never throw an exception with valid scalars (like booleans).
Apr 7 2023, 16:45 · User-valerio.bozzolan, Arcanist
valerio.bozzolan added a comment to T15239: phutil_nonempty_scalar() should never throw an exception with valid scalars (like booleans).

I've also a strong opinion about phutil_nonempty_stringlike() that should also not throw an exception on true, but it should consider true as a valid nonempty stringlike since it returns the string 1. And, it should consider false as an empty stringlike.

Apr 7 2023, 16:42 · User-valerio.bozzolan, Arcanist
valerio.bozzolan added a revision to T15239: phutil_nonempty_scalar() should never throw an exception with valid scalars (like booleans): D25117: phutil_nonempty_scalar(): don't throw when receiving a boolean scalar.
Apr 7 2023, 16:26 · User-valerio.bozzolan, Arcanist
valerio.bozzolan updated the task description for T15239: phutil_nonempty_scalar() should never throw an exception with valid scalars (like booleans).
Apr 7 2023, 16:22 · User-valerio.bozzolan, Arcanist