In T15281#7096, @speck wrote:Could you check the server configuration of php.ini for the value of variable_orders? This open task on phab suggests that on servers it should enforce including E causing phab's environment to be passed to sub-commands, but does not want to mess with it on users' machines.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
May 4 2023
May 4 2023
May 3 2023
May 3 2023
May 2 2023
May 2 2023
May 1 2023
May 1 2023
aklapper updated the task description for T15263: PHP 8.1 "rawurlencode(null)" exception in phutil_escape_uri.
Apr 30 2023
Apr 30 2023
valerio.bozzolan renamed T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo) from Fix Arcanist in PHP 8.2 (testing the Phorge repo) to Fix Arcanist in PHP 8.1+ (testing the Phorge repo).
Apr 29 2023
Apr 29 2023
valerio.bozzolan edited parent tasks for T15281: $HOME missing from commands issued by ExecFuture, added: T15299: Config page runs git commands that should have an HOME to open gitconfig correctly; removed: T15282: Fix/avoid/simplify similar fatal: detected dubious ownership in repository at '/var/www/phorge'.
valerio.bozzolan updated the task description for T15281: $HOME missing from commands issued by ExecFuture.
valerio.bozzolan updated the task description for T15281: $HOME missing from commands issued by ExecFuture.
Could you check the server configuration of php.ini for the value of variable_orders? This open task on phab suggests that on servers it should enforce including E causing phab's environment to be passed to sub-commands, but does not want to mess with it on users' machines.
Apr 28 2023
Apr 28 2023
valerio.bozzolan moved T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo) from Backlog to Epic on the PHP 8 support board.
Apr 27 2023
Apr 27 2023
valerio.bozzolan triaged T15281: $HOME missing from commands issued by ExecFuture as Normal priority.
Apr 26 2023
Apr 26 2023
aklapper renamed T15239: phutil_nonempty_scalar() should never throw an exception with valid scalars (like booleans) from phutil_nonempty_scalar() shoud never throw an exception with valid scalars (like booleans) to phutil_nonempty_scalar() should never throw an exception with valid scalars (like booleans).
I can no longer reproduce this, so I'm guessing it was something bad in my setup.
Apr 25 2023
Apr 25 2023
Apr 21 2023
Apr 21 2023
aklapper updated the task description for T15263: PHP 8.1 "rawurlencode(null)" exception in phutil_escape_uri.
Apr 20 2023
Apr 20 2023
valerio.bozzolan added a comment to T15259: arc patch broken on php 8.2 when certificate is uninstalled.
Dear @goddenrich you are now mentioned in the Change Log > 2023 Week 2 :) Thanks again
valerio.bozzolan renamed T15259: arc patch broken on php 8.2 when certificate is uninstalled from arc patch broken on php 8.2 to arc patch broken on php 8.2 when certificate is uninstalled.
Wow. Probably this can be considered resolved.
valerio.bozzolan updated the task description for T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo).
goddenrich closed T15259: arc patch broken on php 8.2 when certificate is uninstalled, a subtask of T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo), as Resolved.
goddenrich closed T15259: arc patch broken on php 8.2 when certificate is uninstalled as Resolved by committing rARCca5f5cd1522c: Fix idx default empty string in ArcanistWorkflow.
Apr 19 2023
Apr 19 2023
valerio.bozzolan updated the task description for T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo).
goddenrich closed T15257: arc lint broken on php 8.2, a subtask of T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo), as Resolved.
goddenrich closed T15257: arc lint broken on php 8.2 as Resolved by committing rARC75af13abe917: Fix early exit from getMatchSeverity on null severity.
Apr 18 2023
Apr 18 2023
I think that @goddenrich is executing a lint on a personal private project, so it's not easy for you to share the project itself, to reproduce this quickly. Isn't it?
20after4 added a comment to T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..
@ton welcome, glad to have your input here.
Apr 15 2023
Apr 15 2023
Apr 14 2023
Apr 14 2023
valerio.bozzolan closed T15253: Commit hook is sometime broken: InvalidArgumentException as Resolved by committing rPa5c93dea568b: Fix InvalidArgumentException on commit hook.
valerio.bozzolan updated the task description for T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo).
valerio.bozzolan renamed T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies from PHP 8.1: strlen() does not accept NULL anymore - understand fix strategies to PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies.
valerio.bozzolan updated the task description for T15253: Commit hook is sometime broken: InvalidArgumentException.
valerio.bozzolan added a comment to T15253: Commit hook is sometime broken: InvalidArgumentException.
Let's put another red warning in T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies
valerio.bozzolan updated the task description for T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies.
valerio.bozzolan triaged T15253: Commit hook is sometime broken: InvalidArgumentException as Unbreak Now! priority.
ton added a comment to T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..
Having been invited to chime in from Q46 I will leave my 2 cents here:
Apr 12 2023
Apr 12 2023
Cigaryno added a project to T15244: Arcanist is broken on Subversion when moving a file: Bug Reports.
At least using svn 1.13.0, adding --show-inherited-props to the command doesn't print an error and exits with status 0 from the propget command, but I'm not sure what it actually does.
valerio.bozzolan added a comment to T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..
Indeed. Thanks for cleaning. Having said that "Moving a file" is not a "specific" use-case for Subversion users. That kind of bug is an indicator that probably shows to us that this component is essentially not usable by a majority of Subversion* cases.
avivey removed subtasks for T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues.: T15244: Arcanist is broken on Subversion when moving a file, T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo), T15174: Phorge←GitHub: create a bot that imports "Pull requests".
avivey added a comment to T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..
@valerio.bozzolan - marking all bugs in Arcanist as subtasks of this task is not helpful. This task is about discussing users not being happy about arcanist; No specific bug or specific broken use-case is actually relevant to having users not want to use it, because in almost all cases users either refuse to even try it (so they are not effected the bug).
Bugs that are found and are causing any discomfort are fixed.
I put this into a subtask of T15096 since it's obvious to me that, without fixing this problem, users simply cannot use Arcanist with Subversion. We cannot just propose to end-users to do not rename a file.
valerio.bozzolan triaged T15244: Arcanist is broken on Subversion when moving a file as High priority.
Apr 8 2023
Apr 8 2023
Sten added a comment to T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..
In T15096#2230, @20after4 wrote:Honestly the effort to set up arcanist isn't huge (the flow for setting up your CLI cert couldn't be more perfect and user friendly IMO) and it's all worth it because of the productivity gained by automatic lint fixes, easy patch submission and code review checkouts (arc patch is awesome!)
Apr 7 2023
Apr 7 2023
valerio.bozzolan added a comment to T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies.
Basically phutil_nonempty_scalar() cannot be used since, instead of returning false when receiving false, it explodes.
valerio.bozzolan updated the task description for T15239: phutil_nonempty_scalar() should never throw an exception with valid scalars (like booleans).
valerio.bozzolan added a comment to T15239: phutil_nonempty_scalar() should never throw an exception with valid scalars (like booleans).
I've also a strong opinion about phutil_nonempty_stringlike() that should also not throw an exception on true, but it should consider true as a valid nonempty stringlike since it returns the string 1. And, it should consider false as an empty stringlike.
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0