Maniphest T15259

arc patch broken on php 8.2 when certificate is uninstalled
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	goddenrich
	Apr 19 2023, 17:05

Tags

Referenced Files

None

Subscribers

valerio.bozzolan

Tokens

"Grey Medal" token, awarded by valerio.bozzolan.

Description

ran arc patch before arc install-certificate and got this exception:

[2023-04-18 07:45:00] EXCEPTION: (RuntimeException) strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [<arcanist>/src/error/PhutilErrorHandler.php:261]
arcanist(), tmphutil()
  #0 PhutilErrorHandler::handleError(integer, string, string, integer) called at [<arcanist>/src/workflow/ArcanistWorkflow.php:483]
  #1 ArcanistWorkflow::authenticateConduit() called at [<arcanist>/src/workflow/ArcanistPatchWorkflow.php:398]
  #2 ArcanistPatchWorkflow::run() called at [<arcanist>/scripts/arcanist.php:427]
<<< [1] (+930) <exec> 930,645 us

Revisions and Commits

rARC Arcanist
	D25128	rARC8c084061e180 Promote 2023.17 to stable
	D25128	rARCca5f5cd1522c Fix idx default empty string in ArcanistWorkflow

Related Objects
Search...

		Status	Assigned	Task
		Open	None	T15064 Make Phorge compatible with PHP 8.1/8.2
		Open	None	T15187 Fix Arcanist in PHP 8.1+ (testing the Phorge repo)
		Resolved	goddenrich	T15259 arc patch broken on php 8.2 when certificate is uninstalled

Event Timeline

goddenrich created this task.Apr 19 2023, 17:05

Herald added subscribers: Cigaryno, Matthew, chris and 2 others. · View Herald TranscriptApr 19 2023, 17:05

goddenrich added a parent task: T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo).Apr 19 2023, 17:06

goddenrich added a revision: D25128: Fix idx default empty string in ArcanistWorkflow.Apr 19 2023, 17:09

valerio.bozzolan awarded a token.Apr 19 2023, 20:27

valerio.bozzolan mentioned this in T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo).Apr 19 2023, 21:08

goddenrich closed this task as Resolved by committing rARCca5f5cd1522c: Fix idx default empty string in ArcanistWorkflow.Apr 20 2023, 10:18

goddenrich claimed this task.

goddenrich added a commit: rARCca5f5cd1522c: Fix idx default empty string in ArcanistWorkflow.

Dear @goddenrich you are now mentioned in the Change Log > 2023 Week 2 :) Thanks again

avivey mentioned this in 2023 Week 17.Apr 25 2023, 06:54

avivey added a commit: rARC8c084061e180: Promote 2023.17 to stable.Apr 25 2023, 07:12

valerio.bozzolan mentioned this in Next Up (since Week 18).Apr 25 2023, 20:29