Page MenuHomePhorge
Differential D25122

Fix InvalidArgumentException on commit hook
ClosedPublic
Actions

Authored by valerio.bozzolan on Apr 14 2023, 12:05.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 11, 10:13
Unknown Object (File)
Mon, Apr 8, 09:41
Unknown Object (File)
Thu, Apr 4, 11:15
Unknown Object (File)
Wed, Apr 3, 21:11
Unknown Object (File)
Mon, Apr 1, 01:13
Unknown Object (File)
Sun, Mar 31, 03:09
Unknown Object (File)
Sat, Mar 30, 08:02
Unknown Object (File)
Thu, Mar 28, 07:38
View All 100 Files
Subscribers
Cigaryno
Matthew
speck
tobiaswiese

Details

Reviewers
avivey
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies
T15253: Commit hook is sometime broken: InvalidArgumentException
Commits
rP9a3a0354b2da: Fix InvalidArgumentException on commit hook
rPa5c93dea568b: Fix InvalidArgumentException on commit hook
Summary

Fix a regression introduced here:

96ae4ba13acbf0e2f8932e950a92af0495f034d7

I reproduced this exception executing "svn commit" on a hosted repository.

That crash happened because the PHP getenv() function can return false.
But, that is a very terrible value that blasts the non-string-empty check.

So, now the default getenv() value is skipped, without causing problems.

Closes T15253
Ref T15190

Test Plan
  • I've run svn commit and I have not encountered any issue now

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

valerio.bozzolan created this revision.Apr 14 2023, 12:05
Owners added a reviewer: O1: Blessed Committers.Apr 14 2023, 12:05
Herald added subscribers: Cigaryno, Matthew, tobiaswiese, speck. · View Herald TranscriptApr 14 2023, 12:05
valerio.bozzolan requested review of this revision.Apr 14 2023, 12:05
Harbormaster completed remote builds in B246: Diff 487.Apr 14 2023, 12:05
valerio.bozzolan updated this revision to Diff 488.Apr 14 2023, 12:32
  • fix damn linter putting every line under 80 chars
Harbormaster completed remote builds in B247: Diff 488.Apr 14 2023, 12:32
valerio.bozzolan mentioned this in T15253: Commit hook is sometime broken: InvalidArgumentException.Apr 14 2023, 12:42
valerio.bozzolan edited the summary of this revision. (Show Details)
valerio.bozzolan added a task: T15253: Commit hook is sometime broken: InvalidArgumentException.
valerio.bozzolan edited the summary of this revision. (Show Details)
valerio.bozzolan mentioned this in Z1: Phorge.
valerio.bozzolan edited the summary of this revision. (Show Details)Apr 14 2023, 12:50
valerio.bozzolan added a task: T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies.
valerio.bozzolan updated this revision to Diff 489.Apr 14 2023, 13:05

Removed some whitespaces unremoved by lint autofixer

Harbormaster completed remote builds in B248: Diff 489.Apr 14 2023, 13:05
valerio.bozzolan added inline comments.Apr 14 2023, 15:06
scripts/repository/commit_hook.php
121

https://www.php.net/manual/en/function.getenv.php

«returns ... false if the environment variable varname does not exist»

avivey accepted this revision.Apr 14 2023, 17:06
This revision is now accepted and ready to land.Apr 14 2023, 17:06
avivey mentioned this in 2023 Week 2.Apr 14 2023, 17:18
Closed by commit rPa5c93dea568b: Fix InvalidArgumentException on commit hook. · Explain WhyApr 14 2023, 20:09
This revision was automatically updated to reflect the committed changes.
valerio.bozzolan added a commit: rPa5c93dea568b: Fix InvalidArgumentException on commit hook.
avivey mentioned this in 2023 Week 17.Apr 25 2023, 06:54
avivey added a commit: rP9a3a0354b2da: Fix InvalidArgumentException on commit hook.Apr 25 2023, 07:11

Revision Contents
Changeset List

PathSizePackages
scripts/
repository/
32 linesO1: Blessed Committers

Diff 493

View Options

scripts/repository/commit_hook.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0