Differential D25038
Conduit column.search: add status, sequence and isDefault to API results Authored by 20after4 on Apr 24 2022, 18:29. Tags None Referenced Files
Details
This seems like a fairly obvious oversight with the column.search API. Knowing:
are all necessary for a lot of things that very sensible real-world API clients need to do when working with columns. Cherry-picked from https://phabricator.wikimedia.org/rPHABebfe30890b52784d222ec4ed36c05462b2a57f92 Tested on phabricator.wikimedia.org over many months and used by real client apps.
Diff Detail
Event Timeline
Comment Actions Thank you @20after4 for this patch. The inline comments seem reasonable to me. What do you think about?
Comment Actions I tested this locally and it works, thank you. The only strange thing is that the sequence field is supposed - internally - to be an integer but it's exposed as a string in this API. I say, that it's supposed to be an int, since I noticed: PhabricatorBoardLayoutEngine.php $next_sequence = last($board_columns)->getSequence() + 1; And: PhabricatorProjectColumnPosition.php ->addInt($this->getSequence()) So, I suggest to expose the sequence field as an integer, and not as a string. In case, I suggest to return an int just from the API, without touching in any way the PhabricatorEdgeObject#getSequence() - in this moment.
Comment Actions @20after4 do you agree in exposing the sequence as an integer? (since it's assumed to be an integer internally) | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||