Page MenuHomePhorge

FilesProject
ActivePublic

Members

  • This project does not have any members.
  • View All

Watchers

  • This project does not have any watchers.
  • View All

Details

Description

Collection of stuff related to the Files component.

That is, the core component allowing you to upload a File in your Phorge.

Not related to whatever thing is a normal file on a file system.

Recent Activity

Mon, Apr 29

valerio.bozzolan added a comment to T15106: "Upload file" in remarkup text fields should attach by default .

Minor clarification.

Mon, Apr 29, 05:48 · Files, Remarkup

Thu, Apr 11

avivey raised the priority of T15106: "Upload file" in remarkup text fields should attach by default from Normal to High.
Thu, Apr 11, 10:41 · Files, Remarkup

Apr 3 2024

avivey added a comment to T15768: Better tracking tools for Files.

See also note in https://we.phorge.it/D25475#inline-3542 - looks like "creating a transformation" is done in many places.

Apr 3 2024, 06:41 · Files

Apr 2 2024

valerio.bozzolan added a project to T15768: Better tracking tools for Files: Files.
Apr 2 2024, 13:09 · Files

Mar 14 2024

avivey added a comment to D25051: Destroy file attachments when file is deleted.

I'm a little worried about this migration; Do we have garbage collector for this? it would be safer to let it run.

You are concerned for performance reasons because it doesn't limit the results. Right?

Mar 14 2024, 08:34 · Files

Mar 11 2024

valerio.bozzolan added a comment to D25051: Destroy file attachments when file is deleted.

I'm a little worried about this migration; Do we have garbage collector for this? it would be safer to let it run.

Mar 11 2024, 08:42 · Files

Feb 29 2024

valerio.bozzolan closed T15293: Try to avoid message: Transaction (of type "core:file") has no effect as Resolved by committing rP6df26b98c104: Comments: avoid confusing warning about "core:file".
Feb 29 2024, 08:17 · Files, Remarkup
valerio.bozzolan closed T15293: Try to avoid message: Transaction (of type "core:file") has no effect, a subtask of T15106: "Upload file" in remarkup text fields should attach by default , as Resolved.
Feb 29 2024, 08:17 · Files, Remarkup

Feb 28 2024

valerio.bozzolan added a revision to T15293: Try to avoid message: Transaction (of type "core:file") has no effect: D25544: Comments: avoid confusing warning about "core:file".
Feb 28 2024, 15:49 · Files, Remarkup
valerio.bozzolan claimed T15293: Try to avoid message: Transaction (of type "core:file") has no effect.

Gotcha. Probably this is generating the attachment transactions but should be "ignored on no effects":

Feb 28 2024, 15:23 · Files, Remarkup
valerio.bozzolan added a comment to T15106: "Upload file" in remarkup text fields should attach by default .

This feature is not complete also for Conpherence AFAIK

Feb 28 2024, 15:02 · Files, Remarkup

Jan 23 2024

aklapper closed T15326: PHP 8.0 without GD installed: Unhandled Exception setting a project profile image: Call to undefined function imagecreatefromstring() as Resolved by committing rP7a86040f8a46: Avoid exception setting project profile image when GD not installed.
Jan 23 2024, 14:11 · Files, PHP 8 support

Jan 13 2024

aklapper added a revision to T15326: PHP 8.0 without GD installed: Unhandled Exception setting a project profile image: Call to undefined function imagecreatefromstring(): D25515: Avoid exception setting project profile image when GD not installed.
Jan 13 2024, 20:54 · Files, PHP 8 support
aklapper updated the task description for T15326: PHP 8.0 without GD installed: Unhandled Exception setting a project profile image: Call to undefined function imagecreatefromstring().
Jan 13 2024, 14:32 · Files, PHP 8 support

Dec 15 2023

waldyrious added a project to T15270: "Access Denied: Restricted File" strings concatenated without whitespace: UX.
Dec 15 2023, 08:49 · UX, Good Starter Task, Files

Nov 22 2023

valerio.bozzolan closed T15674: Image Transforms should reflect policy of parent Image as Invalid.

My steps to reproduce are wrong / unclear / not always happening.

Nov 22 2023, 13:08 · Files, User-valerio.bozzolan
valerio.bozzolan triaged T15674: Image Transforms should reflect policy of parent Image as Normal priority.
Nov 22 2023, 13:04 · Files, User-valerio.bozzolan

Nov 20 2023

valerio.bozzolan added a comment to T15125: Unknown edge constant "26"! when deleting a file with old attachment edges.

Other edges have probably been eliminated in the past. For example this one:

Nov 20 2023, 10:17 · Affects-Wikimedia, Files, Bug Reports

Oct 25 2023

speck added a comment to T15106: "Upload file" in remarkup text fields should attach by default .

I had communicated these upstream (almost exactly a year ago~) and some helpful information was provided

Oct 25 2023, 21:33 · Files, Remarkup

Sep 25 2023

Dylsss added inline comments to D25051: Destroy file attachments when file is deleted.
Sep 25 2023, 10:55 · Files

Sep 22 2023

waldyrious added a comment to T15270: "Access Denied: Restricted File" strings concatenated without whitespace.

For others reading this thread: there's some discussion going on in the thread of the patch linked above, D25419.

Sep 22 2023, 22:26 · UX, Good Starter Task, Files

Sep 19 2023

valerio.bozzolan added inline comments to D25051: Destroy file attachments when file is deleted.
Sep 19 2023, 11:03 · Files

Sep 18 2023

Dylsss updated the diff for D25051: Destroy file attachments when file is deleted.

PhabricatorFileAttachmentQuery seems to eagerly load the object relation, however since the DestructionEngine extensions run after the object is already deleted, this fails and nothing is returned in the query. Changed to LiskDAO loadAllWhere, which also seems to use less queries in general (due to not eagerly loading), so changed the query in PhabricatorFile as well. Changed mpull to foreach per suggestion.

Sep 18 2023, 20:18 · Files
Dylsss added inline comments to D25051: Destroy file attachments when file is deleted.
Sep 18 2023, 19:24 · Files
Ekubischta added inline comments to D25051: Destroy file attachments when file is deleted.
Sep 18 2023, 17:44 · Files
valerio.bozzolan added inline comments to D25051: Destroy file attachments when file is deleted.
Sep 18 2023, 08:07 · Files
avivey added inline comments to D25051: Destroy file attachments when file is deleted.
Sep 18 2023, 07:47 · Files

Sep 17 2023

Dylsss updated the summary of D25051: Destroy file attachments when file is deleted.
Sep 17 2023, 23:33 · Files
Dylsss merged T15618: Lots of "Unknown Object"s referenced from revisions into T15110: File reference not removed when file is deleted.
Sep 17 2023, 23:32 · Files, Bug Reports
Dylsss edited projects for D25051: Destroy file attachments when file is deleted, added: Files; removed Files (archived).
Sep 17 2023, 23:31 · Files

Jul 20 2023

valerio.bozzolan added a comment to T15125: Unknown edge constant "26"! when deleting a file with old attachment edges.

Please share the output of this:

Jul 20 2023, 15:07 · Affects-Wikimedia, Files, Bug Reports

Jul 5 2023

aklapper added a comment to T15498: PHP 8.2 "strlen(null)" exception when viewing image details.

OK I can reproduce now. I was missing the php-gd extension for some reasons.

Jul 5 2023, 17:45 · Files, PHP 8 support
aklapper closed T15498: PHP 8.2 "strlen(null)" exception when viewing image details as Resolved by committing rPf45d6421a13c: Fix PHP 8.1 "strlen(null)" exception opening a File overlay (Lightbox comment….
Jul 5 2023, 17:38 · Files, PHP 8 support
valerio.bozzolan added a comment to T15498: PHP 8.2 "strlen(null)" exception when viewing image details.

OK I can reproduce now. I was missing the php-gd extension for some reasons.

Jul 5 2023, 12:42 · Files, PHP 8 support
valerio.bozzolan added a comment to T15498: PHP 8.2 "strlen(null)" exception when viewing image details.

I'm trying to reproduce this, but in my local installation I do not have any allowed file formats. I also do not remember how to make that list available.

Jul 5 2023, 11:38 · Files, PHP 8 support

Jul 1 2023

20after4 added a project to Q49: File uploads - default permissions: Files.
Jul 1 2023, 21:42 · Files
20after4 added a project to Q62: Extension: how to use PhabricatorFile::newFromFileData(): Files.
Jul 1 2023, 21:41 · Files

Jun 30 2023

aklapper added a comment to T15326: PHP 8.0 without GD installed: Unhandled Exception setting a project profile image: Call to undefined function imagecreatefromstring().

Do you mean PHP 8.0 or PHP 8.1? I'm confused.

Jun 30 2023, 10:16 · Files, PHP 8 support
Cigaryno added a project to T15498: PHP 8.2 "strlen(null)" exception when viewing image details: Files.
Jun 30 2023, 07:31 · Files, PHP 8 support
Cigaryno moved T15125: Unknown edge constant "26"! when deleting a file with old attachment edges from Backlog to Bug Reports on the Affects-Wikimedia board.
Jun 30 2023, 07:24 · Affects-Wikimedia, Files, Bug Reports

Jun 29 2023

Cigaryno added a comment to T15326: PHP 8.0 without GD installed: Unhandled Exception setting a project profile image: Call to undefined function imagecreatefromstring().

Do you mean PHP 8.0 or PHP 8.1? I'm confused.

Jun 29 2023, 20:41 · Files, PHP 8 support

Jun 17 2023

valerio.bozzolan triaged T15270: "Access Denied: Restricted File" strings concatenated without whitespace as Low priority.
Jun 17 2023, 15:22 · UX, Good Starter Task, Files

Jun 8 2023

aklapper added a comment to T15125: Unknown edge constant "26"! when deleting a file with old attachment edges.

For the records, I had the same experience when deleting a repository via ./bin/remove destroy rESHP for Unknown edge constant "25" (not 26 as mentioned in the task title) in downstream https://phabricator.wikimedia.org/T119588

Jun 8 2023, 16:46 · Affects-Wikimedia, Files, Bug Reports

May 29 2023

valerio.bozzolan added a comment to T15106: "Upload file" in remarkup text fields should attach by default .

Another use case: Drag & Drop on a new Object description, even if the Object is not already created, should attach by default to it.

May 29 2023, 10:11 · Files, Remarkup

May 9 2023

aklapper added a project to T15125: Unknown edge constant "26"! when deleting a file with old attachment edges: Affects-Wikimedia.
May 9 2023, 17:18 · Affects-Wikimedia, Files, Bug Reports
avivey removed a project from T15273: Cannot Attach Restricted files to Phame Posts: Phame (archived).
May 9 2023, 10:51 · Files

May 6 2023

aklapper closed T15342: PHP 8.1 "strlen(null)" exception blocks rendering a File page when Alt Text was altered as Resolved by committing rP651e3f7263b5: Fix PHP 8.1 "strlen(null)" exception which blocks rendering a File page when….
May 6 2023, 02:08 · Files, PHP 8 support
aklapper closed T15341: PHP 8.1 "strlen(null)" exceptions block rendering page of a File as Resolved by committing rP6c692ddbbba8: Fix PHP 8.1 "strlen(null)" exceptions which block rendering page of a File.
May 6 2023, 02:07 · Files, PHP 8 support

May 4 2023

valerio.bozzolan updated the task description for T15293: Try to avoid message: Transaction (of type "core:file") has no effect.
May 4 2023, 16:38 · Files, Remarkup
valerio.bozzolan updated the task description for T15293: Try to avoid message: Transaction (of type "core:file") has no effect.
May 4 2023, 15:48 · Files, Remarkup