Page MenuHomePhorge

April 19, 2022
Updated 19 Days AgoPublic

This document has been moved to /w/planning_meetings/2022-04-19/. You can edit it to put new content here, or use history to revert to an earlier version.

Last Author
Matthew
Last Edited
Tue, May 3, 18:55

Event Timeline

Matthew added subscribers: dcog, 20after4, Matthew.
Matthew added a project: Governance.
Matthew added subscribers: luca.itro, speck.

FYI, it seemed that the issue with the wiki preview loading may be been related to tagging names... if the tags are removed, the preview loads

As I started to thinking about the script to process the pht() files, it hit me that converting something something like:

pht('Connect to Phabricator install specified by __uri__.')

into

pht('Connect to {} install specified by __uri__.', $platformName)

Is something that Rector could likely automate as well... taking a look at their default rules overview https://github.com/rectorphp/rector/blob/main/docs/rector_rules_overview.md

I noticed that there's a rather inviting contact page on the Rector site: https://getrector.org/contact

I'm not sure if they sell support or what, but I'm thinking I really want to try contacting. Does anyone else thinks that's a worthwhile idea? Perhaps they would want to join in some capacity...

If anyone has any ideas about anything to say, or if you think it's not a good idea to contact, or if someone else besides me should do the contacting, just let me know

There is quite a bit of text that is setup like this:

pht(
  'blah blah blah %s blah blah'.
  'blah blah Phabricator blah %s'.
  'blah blah.',
  $var1,
  $var2);

Adding a new placeholder in that text would need to be refactored to look like this

pht(
  'blah blah blah %s blah blah'.
  'blah blah %s blah %s'.
  'blah blah.',
  $var1,
  $phabricator_product_name,
  $var2);

I would guess this complicates the refactoring that's necessary since it has to be aware of the positional arguments of a concatenated string and insert the new argument in the appropriate position (and declare the variable somewhere possibly).

I don't think it could hurt to reach out and contact them to ask about this sort of thing.

translations,The rebranding approach of changing the pht() keys will invalidate a lot of existing translations. Investigate if there are ways to avoid this.

What if we make a new Phorge project on TranslateWiki and use the API to transfer in bulk?

@speck Would it be totally unreasonable to instead do:

pht(
  'blah blah blah %s blah blah'.
  'blah blah @@PHORGE_INSTALL_NAME@@ blah %s'.
  'blah blah.',
  $var1,
  $var2);

And have pht recognize the identifier and pull it from configuration?