Page MenuHomePhorge
Create Task
Maniphest T15891

Ineffective instanceof check in PhabricatorMySQLSetupCheck:shouldUseMySQLSearchEngine()
Open, Needs TriagePublic
Actions

Description

Per PHPStan static code analysis,
Instanceof between PhabricatorSearchService and PhabricatorMySQLSearchHost will always evaluate to false
in https://we.phorge.it/source/phorge/browse/master/src/applications/config/check/PhabricatorMySQLSetupCheck.php$392

This code was introduced by rPe41c25de5050d69b720424dadbe3d8680362ceaf.

Related Objects

Event Timeline

aklapper created this task.Jul 23 2024, 13:24
Herald added subscribers: Cigaryno, Matthew, chris, tobiaswiese. · View Herald TranscriptJul 23 2024, 13:24
valerio.bozzolan subscribed.Jul 23 2024, 13:51

I don't get this 🤔

valerio.bozzolan added a comment.Jul 23 2024, 13:53

Ah. Maybe PhabricatorSearchHost should extend PhabricatorSearchService? Boh

aklapper added a subscriber: 20after4.Jul 23 2024, 20:25

Not sure if @20after4 has any opinions on this? :) For the records, the code looked like this before this last change: https://we.phorge.it/source/phorge/browse/master/src/applications/config/check/PhabricatorMySQLSetupCheck.php;a41d158490c0cd0a0454653473c39f7ad2b5954f$381-384

20after4 added a comment.Jul 23 2024, 21:15

I think line 392 should be:

if ($service->engine instanceof PhabricatorFerretFulltextStorageEngine) {
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0