Feed All Stories

All Stories
Use Results
Edit Query
Hide Query

	Include stories about projects I am a member of.

Jun 20 2024

speck added inline comments to D25051: Destroy file attachments when file is deleted, or object is deleted.

Jun 20 2024, 21:26 · Files

valerio.bozzolan assigned T15110: File reference not removed when file is deleted to Dylsss.

Jun 20 2024, 20:36 · Files, Bug Reports

valerio.bozzolan updated the name of F2236006: Phorge error Unknown objects.png from "image.png" to "Phorge error Unknown objects.png".

Jun 20 2024, 20:20

pppery added a comment to T15862: Some messages that support PLURAL are not detected as such by the i18n string extractor.

From an attempt I made to fix this before running out of motivation (this lists all parameters that vary on number in the US English translation but the i18n extractor thinks they don't)

WARNING  /applications/calendar/notifications/PhabricatorCalendarNotificationEngine.php:269: missing PhutilNumber call?
WARNING  /applications/config/check/PhabricatorExtraConfigSetupCheck.php:72: missing PhutilNumber call?
WARNING  /applications/config/view/PhabricatorSetupIssueView.php:58: missing PhutilNumber call?
WARNING  /applications/config/view/PhabricatorSetupIssueView.php:73: missing PhutilNumber call?
WARNING  /applications/config/view/PhabricatorSetupIssueView.php:316: missing PhutilNumber call?
WARNING  /applications/config/view/PhabricatorSetupIssueView.php:321: missing PhutilNumber call?
WARNING  /applications/config/view/PhabricatorSetupIssueView.php:347: missing PhutilNumber call?
WARNING  /applications/config/view/PhabricatorSetupIssueView.php:390: missing PhutilNumber call?
WARNING  /applications/config/view/PhabricatorSetupIssueView.php:397: missing PhutilNumber call?
WARNING  /applications/config/view/PhabricatorSetupIssueView.php:524: missing PhutilNumber call?
WARNING  /applications/config/view/PhabricatorSetupIssueView.php:578: missing PhutilNumber call?
WARNING  /applications/conpherence/xaction/ConpherenceThreadParticipantsTransaction.php:74: missing PhutilNumber call?
WARNING  /applications/conpherence/xaction/ConpherenceThreadParticipantsTransaction.php:80: missing PhutilNumber call?
WARNING  /applications/differential/edge/DifferentialRevisionDependedOnByRevisionEdgeType.php:36: missing PhutilNumber call?
WARNING  /applications/differential/edge/DifferentialRevisionDependedOnByRevisionEdgeType.php:48: missing PhutilNumber call?
WARNING  /applications/differential/edge/DifferentialRevisionDependedOnByRevisionEdgeType.php:78: missing PhutilNumber call?
WARNING  /applications/differential/edge/DifferentialRevisionDependedOnByRevisionEdgeType.php:92: missing PhutilNumber call?
WARNING  /applications/differential/edge/DifferentialRevisionDependsOnRevisionEdgeType.php:39: missing PhutilNumber call?
WARNING  /applications/differential/edge/DifferentialRevisionDependsOnRevisionEdgeType.php:51: missing PhutilNumber call?
WARNING  /applications/differential/edge/DifferentialRevisionDependsOnRevisionEdgeType.php:81: missing PhutilNumber call?
WARNING  /applications/differential/edge/DifferentialRevisionDependsOnRevisionEdgeType.php:95: missing PhutilNumber call?
WARNING  /applications/differential/edge/DifferentialRevisionHasCommitEdgeType.php:34: missing PhutilNumber call?
WARNING  /applications/differential/edge/DifferentialRevisionHasCommitEdgeType.php:46: missing PhutilNumber call?
WARNING  /applications/differential/edge/DifferentialRevisionHasReviewerEdgeType.php:18: missing PhutilNumber call?
WARNING  /applications/differential/edge/DifferentialRevisionHasReviewerEdgeType.php:30: missing PhutilNumber call?
WARNING  /applications/differential/edge/DifferentialRevisionHasReviewerEdgeType.php:61: missing PhutilNumber call?
WARNING  /applications/differential/edge/DifferentialRevisionHasReviewerEdgeType.php:75: missing PhutilNumber call?
WARNING  /applications/differential/edge/DifferentialRevisionHasTaskEdgeType.php:33: missing PhutilNumber call?
WARNING  /applications/differential/edge/DifferentialRevisionHasTaskEdgeType.php:45: missing PhutilNumber call?
WARNING  /applications/differential/edge/DifferentialRevisionHasTaskEdgeType.php:76: missing PhutilNumber call?
WARNING  /applications/differential/edge/DifferentialRevisionHasTaskEdgeType.php:90: missing PhutilNumber call?
WARNING  /applications/differential/mail/DifferentialCreateMailReceiver.php:75: missing PhutilNumber call?
WARNING  /applications/differential/render/DifferentialChangesetHTMLRenderer.php:523: missing PhutilNumber call?
WARNING  /applications/differential/render/DifferentialChangesetHTMLRenderer.php:525: missing PhutilNumber call?
WARNING  /applications/differential/render/DifferentialChangesetHTMLRenderer.php:529: missing PhutilNumber call?
WARNING  /applications/differential/render/DifferentialChangesetHTMLRenderer.php:531: missing PhutilNumber call?
WARNING  /applications/differential/render/DifferentialChangesetHTMLRenderer.php:556: missing PhutilNumber call?
WARNING  /applications/differential/render/DifferentialChangesetHTMLRenderer.php:558: missing PhutilNumber call?
WARNING  /applications/differential/render/DifferentialChangesetHTMLRenderer.php:562: missing PhutilNumber call?
WARNING  /applications/differential/render/DifferentialChangesetHTMLRenderer.php:564: missing PhutilNumber call?
WARNING  /applications/differential/storage/DifferentialTransaction.php:593: missing PhutilNumber call?
WARNING  /applications/differential/storage/DifferentialTransaction.php:597: missing PhutilNumber call?
WARNING  /applications/diffusion/edge/DiffusionCommitHasRevisionEdgeType.php:34: missing PhutilNumber call?
WARNING  /applications/diffusion/edge/DiffusionCommitHasRevisionEdgeType.php:46: missing PhutilNumber call?
WARNING  /applications/diffusion/edge/DiffusionCommitHasTaskEdgeType.php:33: missing PhutilNumber call?
WARNING  /applications/diffusion/edge/DiffusionCommitHasTaskEdgeType.php:45: missing PhutilNumber call?
WARNING  /applications/diffusion/edge/DiffusionCommitHasTaskEdgeType.php:76: missing PhutilNumber call?
WARNING  /applications/diffusion/edge/DiffusionCommitHasTaskEdgeType.php:90: missing PhutilNumber call?
WARNING  /applications/diffusion/edge/DiffusionCommitRevertedByCommitEdgeType.php:22: missing PhutilNumber call?
WARNING  /applications/diffusion/edge/DiffusionCommitRevertedByCommitEdgeType.php:34: missing PhutilNumber call?
WARNING  /applications/diffusion/edge/DiffusionCommitRevertedByCommitEdgeType.php:64: missing PhutilNumber call?
WARNING  /applications/diffusion/edge/DiffusionCommitRevertedByCommitEdgeType.php:78: missing PhutilNumber call?
WARNING  /applications/diffusion/edge/DiffusionCommitRevertsCommitEdgeType.php:25: missing PhutilNumber call?
WARNING  /applications/diffusion/edge/DiffusionCommitRevertsCommitEdgeType.php:37: missing PhutilNumber call?
WARNING  /applications/diffusion/edge/DiffusionCommitRevertsCommitEdgeType.php:67: missing PhutilNumber call?
WARNING  /applications/diffusion/edge/DiffusionCommitRevertsCommitEdgeType.php:81: missing PhutilNumber call?
WARNING  /applications/legalpad/edge/LegalpadObjectNeedsSignatureEdgeType.php:17: missing PhutilNumber call?
WARNING  /applications/maniphest/edge/ManiphestTaskDependedOnByTaskEdgeType.php:32: missing PhutilNumber call?
WARNING  /applications/maniphest/edge/ManiphestTaskDependedOnByTaskEdgeType.php:44: missing PhutilNumber call?
WARNING  /applications/maniphest/edge/ManiphestTaskDependedOnByTaskEdgeType.php:74: missing PhutilNumber call?
WARNING  /applications/maniphest/edge/ManiphestTaskDependedOnByTaskEdgeType.php:88: missing PhutilNumber call?
WARNING  /applications/maniphest/edge/ManiphestTaskDependsOnTaskEdgeType.php:37: missing PhutilNumber call?
WARNING  /applications/maniphest/edge/ManiphestTaskDependsOnTaskEdgeType.php:49: missing PhutilNumber call?
WARNING  /applications/maniphest/edge/ManiphestTaskDependsOnTaskEdgeType.php:79: missing PhutilNumber call?
WARNING  /applications/maniphest/edge/ManiphestTaskDependsOnTaskEdgeType.php:93: missing PhutilNumber call?
WARNING  /applications/maniphest/edge/ManiphestTaskHasCommitEdgeType.php:33: missing PhutilNumber call?
WARNING  /applications/maniphest/edge/ManiphestTaskHasCommitEdgeType.php:45: missing PhutilNumber call?
WARNING  /applications/maniphest/edge/ManiphestTaskHasCommitEdgeType.php:76: missing PhutilNumber call?
WARNING  /applications/maniphest/edge/ManiphestTaskHasCommitEdgeType.php:90: missing PhutilNumber call?
WARNING  /applications/maniphest/edge/ManiphestTaskHasMockEdgeType.php:21: missing PhutilNumber call?
WARNING  /applications/maniphest/edge/ManiphestTaskHasMockEdgeType.php:33: missing PhutilNumber call?
WARNING  /applications/maniphest/edge/ManiphestTaskHasRevisionEdgeType.php:33: missing PhutilNumber call?
WARNING  /applications/maniphest/edge/ManiphestTaskHasRevisionEdgeType.php:45: missing PhutilNumber call?
WARNING  /applications/maniphest/edge/ManiphestTaskHasRevisionEdgeType.php:76: missing PhutilNumber call?
WARNING  /applications/maniphest/edge/ManiphestTaskHasRevisionEdgeType.php:90: missing PhutilNumber call?
WARNING  /applications/owners/xaction/PhabricatorOwnersPackageOwnersTransaction.php:54: missing PhutilNumber call?
WARNING  /applications/owners/xaction/PhabricatorOwnersPackageOwnersTransaction.php:60: missing PhutilNumber call?
WARNING  /applications/pholio/edge/PholioMockHasTaskEdgeType.php:21: missing PhutilNumber call?
WARNING  /applications/pholio/edge/PholioMockHasTaskEdgeType.php:33: missing PhutilNumber call?
WARNING  /applications/pholio/xaction/PholioImageFileTransaction.php:61: missing PhutilNumber call?
WARNING  /applications/pholio/xaction/PholioImageFileTransaction.php:67: missing PhutilNumber call?
WARNING  /applications/phortune/controller/account/PhortuneAccountOverviewController.php:116: missing PhutilNumber call?
WARNING  /applications/phortune/edge/PhortuneAccountHasMemberEdgeType.php:17: missing PhutilNumber call?
WARNING  /applications/phortune/edge/PhortuneAccountHasMemberEdgeType.php:29: missing PhutilNumber call?
WARNING  /applications/phortune/edge/PhortuneMerchantHasMemberEdgeType.php:17: missing PhutilNumber call?
WARNING  /applications/phortune/edge/PhortuneMerchantHasMemberEdgeType.php:29: missing PhutilNumber call?
WARNING  /applications/project/edge/PhabricatorProjectMemberOfProjectEdgeType.php:22: missing PhutilNumber call?
WARNING  /applications/project/edge/PhabricatorProjectMemberOfProjectEdgeType.php:34: missing PhutilNumber call?
WARNING  /applications/project/edge/PhabricatorProjectObjectHasProjectEdgeType.php:24: missing PhutilNumber call?
WARNING  /applications/project/edge/PhabricatorProjectObjectHasProjectEdgeType.php:36: missing PhutilNumber call?
WARNING  /applications/project/edge/PhabricatorProjectObjectHasProjectEdgeType.php:67: missing PhutilNumber call?
WARNING  /applications/project/edge/PhabricatorProjectObjectHasProjectEdgeType.php:81: missing PhutilNumber call?
WARNING  /applications/project/edge/PhabricatorProjectProjectHasMemberEdgeType.php:22: missing PhutilNumber call?
WARNING  /applications/project/edge/PhabricatorProjectProjectHasMemberEdgeType.php:34: missing PhutilNumber call?
WARNING  /applications/project/edge/PhabricatorProjectProjectHasMemberEdgeType.php:64: missing PhutilNumber call?
WARNING  /applications/project/edge/PhabricatorProjectProjectHasMemberEdgeType.php:78: missing PhutilNumber call?
WARNING  /applications/project/storage/PhabricatorProjectTransaction.php:108: missing PhutilNumber call?
WARNING  /applications/project/storage/PhabricatorProjectTransaction.php:120: missing PhutilNumber call?
WARNING  /applications/project/xaction/PhabricatorProjectSlugsTransaction.php:56: missing PhutilNumber call?
WARNING  /applications/project/xaction/PhabricatorProjectSlugsTransaction.php:62: missing PhutilNumber call?
WARNING  /applications/project/xaction/PhabricatorProjectSlugsTransaction.php:90: missing PhutilNumber call?
WARNING  /applications/project/xaction/PhabricatorProjectSlugsTransaction.php:97: missing PhutilNumber call?
WARNING  /applications/repository/worker/PhabricatorRepositoryPushMailWorker.php:77: missing PhutilNumber call?
WARNING  /applications/repository/worker/PhabricatorRepositoryPushMailWorker.php:108: missing PhutilNumber call?
WARNING  /applications/subscriptions/engineextension/PhabricatorSubscriptionsCurtainExtension.php:98: missing PhutilNumber call?
WARNING  /applications/subscriptions/view/SubscriptionListStringBuilder.php:67: missing PhutilNumber call?
WARNING  /applications/transactions/edges/PhabricatorObjectHasContributorEdgeType.php:22: missing PhutilNumber call?
WARNING  /applications/transactions/edges/PhabricatorObjectHasContributorEdgeType.php:34: missing PhutilNumber call?
WARNING  /applications/transactions/edges/PhabricatorObjectHasWatcherEdgeType.php:21: missing PhutilNumber call?
WARNING  /applications/transactions/edges/PhabricatorObjectHasWatcherEdgeType.php:33: missing PhutilNumber call?
WARNING  /applications/transactions/edges/PhabricatorObjectHasWatcherEdgeType.php:63: missing PhutilNumber call?
WARNING  /applications/transactions/edges/PhabricatorObjectHasWatcherEdgeType.php:77: missing PhutilNumber call?
WARNING  /applications/transactions/response/PhabricatorApplicationTransactionNoEffectResponse.php:38: missing PhutilNumber call?
WARNING  /applications/transactions/response/PhabricatorApplicationTransactionNoEffectResponse.php:39: missing PhutilNumber call?
WARNING  /applications/transactions/response/PhabricatorApplicationTransactionNoEffectResponse.php:44: missing PhutilNumber call?
WARNING  /applications/transactions/response/PhabricatorApplicationTransactionNoEffectResponse.php:55: missing PhutilNumber call?
WARNING  /applications/transactions/response/PhabricatorApplicationTransactionNoEffectResponse.php:56: missing PhutilNumber call?
WARNING  /applications/transactions/storage/PhabricatorApplicationTransaction.php:1042: missing PhutilNumber call?
WARNING  /applications/transactions/storage/PhabricatorApplicationTransaction.php:1053: missing PhutilNumber call?
WARNING  /infrastructure/diff/view/PHUIDiffTableOfContentsItemView.php:140: missing PhutilNumber call?
WARNING  /infrastructure/edges/type/PhabricatorEdgeType.php:66: missing PhutilNumber call?
WARNING  /infrastructure/edges/type/PhabricatorEdgeType.php:78: missing PhutilNumber call?
WARNING  /infrastructure/edges/type/PhabricatorEdgeType.php:109: missing PhutilNumber call?
WARNING  /infrastructure/edges/type/PhabricatorEdgeType.php:123: missing PhutilNumber call?

Not all of these should be fixed in the obvious way, or even can be.

Jun 20 2024, 18:42 · Localization

pppery created T15863: Phorge doesn't seem to properly support gramatical gender.

Jun 20 2024, 18:11 · Localization

pppery created T15862: Some messages that support PLURAL are not detected as such by the i18n string extractor.

Jun 20 2024, 18:03 · Localization

mturdus accepted D25612: Use more css and phorge standard elements for application view.

Jun 20 2024, 16:06 · Arcanist, Diagrams (Extension)

pppery updated the diff for D25695: Add fallback languages for locale files.

Fix a typo

Jun 20 2024, 15:07

pppery added a comment to D25695: Add fallback languages for locale files.

Done that. I left the technically-redundant methods where I have a lengthy comment explaining why I return en_US, since I think it's helpful to explain why that is.

Jun 20 2024, 15:06

pppery updated the diff for D25695: Add fallback languages for locale files.

Don't make unnecessary whitespace changes

Jun 20 2024, 15:04

pppery updated the diff for D25695: Add fallback languages for locale files.

Set fallback locale in base class

Jun 20 2024, 15:02

pppery added a comment to D25695: Add fallback languages for locale files.

The current behavior if a fallback locale is not specified is to fallback to the proto-English string (English without applying pluralization). It probably does make sense, now that you bring it up, to fall back to en_US instead by default instead of doing that in every locale.

Jun 20 2024, 14:56

avivey added a comment to D25695: Add fallback languages for locale files.

What's the current behavior for fallback from cs_CZ? Would it make sense to set the default to en_US in the base class?

Jun 20 2024, 06:42

Mr08J added a watcher for Trusted Contributors: Mr08J.

Jun 20 2024, 05:56

Mr08J added a comment to Template.

{F2235244}

Jun 20 2024, 03:13

Jun 19 2024

pppery updated the diff for D25695: Add fallback languages for locale files.

Ce a comment

Jun 19 2024, 21:36

aklapper planned changes to D25696: Avoid "Unknown Object (????)" for custom Select field values in Herald editor.

This is not a full fix, still it is an improvement (and a base if anyone feels like fixing this perfectly).

Jun 19 2024, 20:35

aklapper requested review of D25696: Avoid "Unknown Object (????)" for custom Select field values in Herald editor.

Jun 19 2024, 20:33

aklapper added a revision to T15860: Editing a Herald rule fails to display values of custom field: "Unknown Object (????)": D25696: Avoid "Unknown Object (????)" for custom Select field values in Herald editor.

Jun 19 2024, 20:33 · Herald

pppery added inline comments to D25695: Add fallback languages for locale files.

Jun 19 2024, 20:29

pppery updated the diff for D25695: Add fallback languages for locale files.

Fix lint

Jun 19 2024, 20:16

pppery requested review of D25695: Add fallback languages for locale files.

Jun 19 2024, 20:12

pppery created T15861: Support bidirectional fallback locales.

Jun 19 2024, 19:43 · Arcanist, Localization

aklapper abandoned D25635: Fix PHP 8.1 "preg_replace(null)" exception in PhabricatorEditorURIEngine.php.

revi confirmed this is called by getRepositorySlug() so abandoning this patch as hiding the underlying issue (no repository slug defined?) is not the right approach

Jun 19 2024, 16:33

aklapper created T15860: Editing a Herald rule fails to display values of custom field: "Unknown Object (????)".

Jun 19 2024, 15:49 · Herald

• l2dy added inline comments to D25694: Set "preconnect" HTTP header when "security.alternate-file-domain" is set.

Jun 19 2024, 14:32

revi added a comment to T15824: Deprecation notice at PhabricatorEditorURIEngine.php:283.

$ git show
commit d519f75dfdee61bb109468aa708c47f53f3e5128 (HEAD -> stable, origin/stable)
Author: Mark Jervelund <EMAIL-REDACTED>
Date:   Mon Feb 12 11:51:24 2024 +0100

Jun 19 2024, 14:05 · PHP 8 support, Deprecation Notice

revi created P43 paste.php.

Jun 19 2024, 14:04

aklapper added a comment to D25636: Fix exception awarding empty badge to user.

In D25636#17849, @valerio.bozzolan wrote:

Nice catch. Basically the question is, why is this not working?

Jun 19 2024, 13:53

aklapper added a comment to T15824: Deprecation notice at PhabricatorEditorURIEngine.php:283.

@revi: Could you please double-check and confirm that the line 144 in <phorge>/src/infrastructure/editor/PhabricatorEditorURIEngine.php is
'n' => $this->escapeToken($repository->getRepositorySlug()),
in your installation? Thanks in advance!

Jun 19 2024, 13:52 · PHP 8 support, Deprecation Notice

aklapper added inline comments to D25694: Set "preconnect" HTTP header when "security.alternate-file-domain" is set.

Jun 19 2024, 09:49

aklapper added a comment to D25694: Set "preconnect" HTTP header when "security.alternate-file-domain" is set.

can it cause anything bad

Jun 19 2024, 09:37

avivey added a comment to D25694: Set "preconnect" HTTP header when "security.alternate-file-domain" is set.

What if $cdn has some evil characters? Do we have some escaping, or can it cause anything bad, or do we not care? Looks like we're including a bunch of other config as-is here, so maybe it's ok.

Jun 19 2024, 08:11

avivey accepted D25546: Warn in comment field if task is closed as duplicate.

Looks good to me.

Jun 19 2024, 07:33

aklapper added inline comments to D25694: Set "preconnect" HTTP header when "security.alternate-file-domain" is set.

Jun 19 2024, 07:30

speck added inline comments to D25694: Set "preconnect" HTTP header when "security.alternate-file-domain" is set.

Jun 19 2024, 02:43

Jun 18 2024

aklapper closed T15224: Mobile hamburger menu in User Profile page contains only useless stuff as Resolved by committing rP5d479556c329: Display same items in mobile menu on User Profile page as on desktop.

Jun 18 2024, 18:01 · User-valerio.bozzolan, People, User-Cigaryno, Mobile

aklapper closed D25687: Display same items in mobile menu on User Profile page as on desktop.

Jun 18 2024, 18:01

aklapper committed rP5d479556c329: Display same items in mobile menu on User Profile page as on desktop.

Display same items in mobile menu on User Profile page as on desktop

Jun 18 2024, 18:01

valerio.bozzolan triaged T15859: Set "preconnect" HTTP header when "security.alternate-file-domain" is set as Wishlist priority.

Jun 18 2024, 15:20 · Feature Requests

aklapper added a comment to D25694: Set "preconnect" HTTP header when "security.alternate-file-domain" is set.

Good point, thanks! Updated.

Jun 18 2024, 15:18

aklapper updated the summary of D25694: Set "preconnect" HTTP header when "security.alternate-file-domain" is set.

Jun 18 2024, 15:18

• l2dy added a comment to D25694: Set "preconnect" HTTP header when "security.alternate-file-domain" is set.

Should the summary also include https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/rel/preconnect as a reference? https://developer.mozilla.org/en-US/docs/Web/Performance/dns-prefetch doesn't mention preconnect in the first few paragraphs, so it's somewhat confusing.

Jun 18 2024, 14:13

aklapper requested review of D25694: Set "preconnect" HTTP header when "security.alternate-file-domain" is set.

Jun 18 2024, 10:36

aklapper added a revision to T15859: Set "preconnect" HTTP header when "security.alternate-file-domain" is set: D25694: Set "preconnect" HTTP header when "security.alternate-file-domain" is set.

Jun 18 2024, 10:36 · Feature Requests

aklapper created T15859: Set "preconnect" HTTP header when "security.alternate-file-domain" is set.

Jun 18 2024, 10:29 · Feature Requests

aklapper updated the diff for D25546: Warn in comment field if task is closed as duplicate.

Also remove now unused private $objectPHID

Jun 18 2024, 10:26

aklapper updated the diff for D25546: Warn in comment field if task is closed as duplicate.

Remove a needless ->setObjectPHID($object_phid) call I missed now that we pass $object

Jun 18 2024, 10:23

aklapper added a comment to D25546: Warn in comment field if task is closed as duplicate.

I still don't like the solution of using place-holder text for that

Jun 18 2024, 10:19

aklapper updated the diff for D25546: Warn in comment field if task is closed as duplicate.

Thanks for the review (and for your patience!).

Jun 18 2024, 10:17

aklapper updated the test plan for D25546: Warn in comment field if task is closed as duplicate.

Jun 18 2024, 10:12

Jun 16 2024

mturdus closed Q139: Add remarkup syntax help for custom remarkup rule tokens as resolved.

Jun 16 2024, 17:22 · Extension Development

mturdus added Q139: Add remarkup syntax help for custom remarkup rule tokens (Answer 172).

Jun 16 2024, 17:22

avivey updated the question details for Q139: Add remarkup syntax help for custom remarkup rule tokens.

Jun 16 2024, 15:49 · Extension Development

avivey added Q139: Add remarkup syntax help for custom remarkup rule tokens (Answer 171).

Jun 16 2024, 15:44

avivey added Q138: SAML 2.0 support (Answer 170).

Jun 16 2024, 15:33

mturdus updated the task description for T15858: Conduit API: allow phriction.edit to modify viewPolicy and editPolicy.

Jun 16 2024, 15:24 · Phriction, Feature Requests

mturdus updated the diff for D25693: Conduit API: allow phriction.edit to modify viewPolicy and editPolicy.

Updating D25693: Conduit API: allow phriction.edit to modify viewPolicy and editPolicy

Jun 16 2024, 15:21

avivey added a comment to D25546: Warn in comment field if task is closed as duplicate.

I still don't like the solution of using place-holder text for that; But this implementation also adds another DB access which I think is redundant.

Jun 16 2024, 09:16

avivey added a comment to D25693: Conduit API: allow phriction.edit to modify viewPolicy and editPolicy.

Instead of this diff, can you add a modern endpoint that uses the EditEngine/transactions? e.g. maniphest.edit, badge.edit, etc.
That will need a different name (phriction.document.edit?), but will allow full editing capability.

Jun 16 2024, 07:53

Jun 15 2024

mturdus requested review of D25693: Conduit API: allow phriction.edit to modify viewPolicy and editPolicy.

Jun 15 2024, 15:03

mturdus added a revision to T15858: Conduit API: allow phriction.edit to modify viewPolicy and editPolicy: D25693: Conduit API: allow phriction.edit to modify viewPolicy and editPolicy.

Jun 15 2024, 15:03 · Phriction, Feature Requests

mturdus created T15858: Conduit API: allow phriction.edit to modify viewPolicy and editPolicy.

Jun 15 2024, 15:00 · Phriction, Feature Requests

mturdus closed T15857: Fix PHP 8.1 "strlen(null)" exception in PhabricatorMailSMTPAdapter when sending email as Resolved by committing rP000bccf8e4f7: Fix PHP 8.1 "strlen(null)" exception in PhabricatorMailSMTPAdapter when sending….

Jun 15 2024, 13:14

mturdus closed D25692: Fix PHP 8.1 "strlen(null)" exception in PhabricatorMailSMTPAdapter when sending email.

Jun 15 2024, 13:14

mturdus committed rP000bccf8e4f7: Fix PHP 8.1 "strlen(null)" exception in PhabricatorMailSMTPAdapter when sending….

Fix PHP 8.1 "strlen(null)" exception in PhabricatorMailSMTPAdapter when sending…

Jun 15 2024, 13:14

speck accepted D25692: Fix PHP 8.1 "strlen(null)" exception in PhabricatorMailSMTPAdapter when sending email.

Thank you!

Jun 15 2024, 13:12

mturdus retitled D25692: Fix PHP 8.1 "strlen(null)" exception in PhabricatorMailSMTPAdapter when sending email from Fix PHP 8.1 "strlen(null)" exception in Diviner when sending email via SMTP

Jun 15 2024, 12:43

mturdus requested review of D25692: Fix PHP 8.1 "strlen(null)" exception in PhabricatorMailSMTPAdapter when sending email.

Jun 15 2024, 12:40

mturdus added a revision to T15857: Fix PHP 8.1 "strlen(null)" exception in PhabricatorMailSMTPAdapter when sending email: D25692: Fix PHP 8.1 "strlen(null)" exception in PhabricatorMailSMTPAdapter when sending email.

Jun 15 2024, 12:40

mturdus created T15857: Fix PHP 8.1 "strlen(null)" exception in PhabricatorMailSMTPAdapter when sending email.

Jun 15 2024, 12:39

Jack_who_built_the_house attached a referenced file: F2228581: image.png.

Jun 15 2024, 01:39 · Accessibility, Phorge

Jack_who_built_the_house updated subscribers of T15856: Navigating links using keyboard does not show an outline indicating the currently active link.

I have this look on Windows for

a {
  outline-style: auto;
}

Last Chrome	Last Firefox

Jun 15 2024, 01:35 · Accessibility, Phorge

aklapper added a comment to T15856: Navigating links using keyboard does not show an outline indicating the currently active link.

This is the same as Q132: Why is there an `outline-style: none;` declaration for all links within Phorge/Phabricator?

Jun 15 2024, 00:39 · Accessibility, Phorge

Jun 14 2024

Jack_who_built_the_house created T15856: Navigating links using keyboard does not show an outline indicating the currently active link.

Jun 14 2024, 19:08 · Accessibility, Phorge

aklapper added a comment to T15749: Display warning about commenting on a task which is closed as a duplicate.

Cleaner attempt in D25546 Diff 2113.

Jun 14 2024, 05:51 · Feature Requests

aklapper updated the test plan for D25546: Warn in comment field if task is closed as duplicate.

Jun 14 2024, 05:50

aklapper updated the diff for D25546: Warn in comment field if task is closed as duplicate.

Allow to setEditEngine when constructing a PhabricatorApplicationTransactionCommentView

Jun 14 2024, 05:49

Jun 13 2024

mturdus asked Q139: Add remarkup syntax help for custom remarkup rule tokens.

Jun 13 2024, 19:15 · Extension Development

aklapper added a comment to T15749: Display warning about commenting on a task which is closed as a duplicate.

Thanks for the pointers, I really appreciate them.

Jun 13 2024, 15:04 · Feature Requests

aklapper added a comment to D25676: Fix responsible authors in DifferentialRevisionQuery.

Ah, thanks, makes sense now. I'd probably rephrase "but harms the authors constraint" a little bit to explicitly cover what you explained well in D25676#18549 - an author PHID in $this->responsibles might not always be a member of a project or owner of a package, so the query results were incomplete beforehand.

Jun 13 2024, 09:55 · Differential

zhe awarded Q138: SAML 2.0 support a Orange Medal token.

Jun 13 2024, 03:43 · Feature Requests