Minimal fix to the issue as discussed...

That works...

I've replaced it with DifferentialRevertPlanCommitMessageField, anyway - that one already has all the required stuff.

Simply adding a FIELDKEY adds Test: to the title of a new diff, but the full fix of making DifferentialTestCommitMessageField a DifferentialCommitMessageCustomField doesn't

Unfortunately, that fix adds the word "Test:" to the title of any new diff. I'm trying to find an existing field that can make the test work, or else find another creative solution.

The test-field gets picked up automatically because we pick all fields. It's missing FIELDKEY, so arc-diff doesn't work at all, and if we add FIELDKEY it shows up as the first field in the arc-diff form.

I have a fix, but can't create it. Will need manually applying to the server:

Please also manually run this

Yeah bob, feel free to add your nice screenshots in the Task description for more visibility. You are a good minion!

LGTM

LGTM

LGTM

In workboard, empty column's drop zone is a little bit 'agressive' isn't it ?

Updating D25383: Removing useless fallback string definition when calling idx

Gotcha. So

• isset() is safer when pulling things out of arrays.
• phutil_non_empty_string() provides for stricter parameter checking as it demands the array value is set, even if set to null.

Thanks! Interestingly you fixed an incomplete fix since D25128

tl;dr: I like phutil_nonempty_string($map['query']) better if we know $map['query'] is defined, and phutil_nonempty_string(idx($map, 'query')) otherwise.

Gentle reminder that this has been waiting review for a while now...

Gentle reminder that this has been waiting review for a while now...

Gentle reminder that this has been waiting review for a while now...

Gentle reminder that this has been waiting review for a while now...

Gentle reminder that this has been waiting review for a while now...

Would you like to try yourself arc patch D25381 and then arc land to land into master branch?

Perfect ! Thanks for the review valerio !

Thanks bob, ready for land

Great news, thanks for your review valerio !

Can you attach the stack trace of when you try to re-upload an image?

let's also fix a typo (thanks Sten)

Thanks bob! Ready to land

I finally found it, D25381 fix the issue.

Sorry for the noise on this diff, I did something wrong during another diff creation procedure (I'm not an arcanist pro since I don't use it in my professional workflow).

Great, I'll give it a try as soon as I can.

What was your strategy to locate strlen(null) issue without any stacktrace, manual code analysis ?

'git grep' to find where the error page was generated, then adding the missing phlog($ex) to get the stack trace.

Contact Amazon ASAP?

I applied this diff but unfortunately, it doesn't fix the issue...
What was your strategy to locate strlen(null) issue without any stacktrace, manual code analysis ?

Partially related to T15578: The action "Quote comment" has an incomplete fragment URL

Testing with my PHP 8.1, I can't replicate this. But I do have a bunch of PHP 8.1 fixes in place which are still awaiting approval.