In T15188#9488, @speck wrote:

It looks like upstream just straight-up removed the call to utf8_decode() in the master branch: https://secure.phabricator.com/diffusion/ARC/browse/master/src/utils/utf8.php$290-292

It looks like upstream just straight-up removed the call to utf8_decode() in the master branch: https://secure.phabricator.com/diffusion/ARC/browse/master/src/utils/utf8.php$290-292

These are the stack traces:

Hoping to be useful, without further feedback I will land this in 7 days :)

Have you your stack traces before this was happening?

Another use case: Drag & Drop on a new Object description, even if the Object is not already created, should attach by default to it.

Aaaaaand... thaaanks again!

Indeed, getStr() can do that, right...

I think the README is somehow OK now. Any further improvement is welcome. Thanks :)

Thanks!

It would be helpful to have reproducing steps here, but probably this was never reproduced by the reporter, just found from TranslateWiki

yeah, ./scripts/celerity/generate_sprites.php. It will also generate the sprite files (and after that, bin/celerity map)

Fixed thanks aklapper

@valerio.bozzolan F267558 in the task description is not attached, thus it cannot be seen by others.

I have no idea how to create the hash value in resources/sprite/manifest/login.json. Probably there's some magic commands to do all of this. While I created the CSS etc manually.

getLoginIcon() { return PlatformSymbols::getPlatformServerName(); } returns Phorge.
Thus no corresponding icon is found as Phorge.png does not exist and code falls back to first icon.

Before this change, some git commands here were executed without any HOME...

In D25238#7248, @valerio.bozzolan wrote:

Thanks again for this patch!

If you want to try a new hallucinatory thing, try this to "Land" this change:

../arcanist/bin/arc patch D25238
../arcanist/bin/arc land

The tradition wants that the author lands.

If you don't want to try, feel free to just say "Naaah whatever, land this for me". No problem! :)

Update README to add some useful notes proposed by avivey

Just to be sure, run again Celerity map:

Thanks for this

In D25025#6842, @valerio.bozzolan wrote:

Hoping to be useful I will land this approved change in 7 days if the original author can't :) Thanks again

I agree that a small link to the original macro page would also be useful. Also, this mitigates some potential copyright troubles, since sometime the macro page contains some credits and disclaimers.

Yeah why not. Indeed not everybody using Phorge has an international audience, so it would be nice also to have a related option to eventually supress that info I guess.

@valerio.bozzolan Will allowing a Timezone option in the user's "Date Format" solve this?

This is probably a configuration issue - mine shows "This install does not have any active MFA providers configured".

From reading the last messages in T109 (starting https://phabricator.wikimedia.org/T109#8874116), it sounds like adding that text will be bad for screen readers, because it will add lots of repetitive, "un-useful reading" to the page.

(Raising to "HIGH", until we figure out if there's a security concern).

The text says "The user who uploaded a file can always view and edit it.". I checked the DB, and the author field for the relevant file is null.
That implies that this upload code is bypassing some security checks...

I think a more generic solution here is "Make the Remarkup Help Page Extensible", so that Remarkup rules can add their own sections (Possibly under the Guides application, if it still exists?)

I was intrigued that Evan added the perl version in the first place, but I went and read the licenses and I think it's fine to remove these parts.

This programming langauge clearly outsmarts me

Shorten 87 char line to pass linter

You can also remove the is_bool() thing and just keep the strict check with triple equals, since it already verifies the type

I could reproduce this locally:

1. As an admin, go to http://phorge.localhost/herald/create/
2. Select "Maniphest Tasks"
3. On http://phorge.localhost/herald/create/?adapter=HeraldManiphestTaskAdapter , select "Global Rule"
4. Under "Conditions", select any of and set the three conditions Description | contains | Internet Archive, Description | contains | archive.org, Description | contains | Wayback Machine.
5. Under "Action", select Add projects | someProject
6. Select "Save Rule"
7. Trigger the rule by creating a new task.
8. Wait, wait, and wait, then look at the Herald Transcript linked from the task.