Page MenuHomePhorge

Cleanup unused cowsay files (related to legacy Perl binary version)
ClosedPublic

Authored by valerio.bozzolan on May 24 2023, 15:13.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jun 15, 18:49
Unknown Object (File)
Sat, Jun 15, 11:31
Unknown Object (File)
Sat, Jun 15, 11:31
Unknown Object (File)
Sat, Jun 15, 11:31
Unknown Object (File)
Sat, Jun 15, 10:38
Unknown Object (File)
Sat, Jun 15, 09:56
Unknown Object (File)
Thu, Jun 13, 18:59
Unknown Object (File)
Thu, Jun 13, 15:04

Details

Summary

Premising that Remarkup supports a fully-featured cowsay generator (!)... since 2015 this awesome
thing no longer requires a binary cowsay command, since everything was rewritten in the core:

c705c8011e964945a6f73ae78087e188de0bd71f

So, some files from the legacy cowsay version in Perl can be safely removed.

We still thank the original author Tony Monroe for the original version in Perl (dated 2000),
and Evan Priestley for the re-implementation in PHP.

Probably nobody knows about this feature. This may change in the future. See T15401.

Closes T15418

Test Plan

Try some awesome cows to verify that everything still works. For instance:

cowsay {{{
 hello
}}}
cowsay (think=yes,eyes=XX,tongue=^^) {{{
 hello
}}}
cowsay (cow=stegosaurus) {{{
 hello
}}}

If nothing explodes, yuppie! Cowsay still works.

Credits to the original version in Perl remained in place.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

avivey subscribed.

I was intrigued that Evan added the perl version in the first place, but I went and read the licenses and I think it's fine to remove these parts.

To be even more fine, we can put a note in the README that we "modified" this version by deleting all the perl code and re-implemented it in src/infrastructure/markup/interpreter/PhabricatorRemarkupCowsayBlockInterpreter.php.

This revision is now accepted and ready to land.May 27 2023, 07:42

Update README to add some useful notes proposed by avivey

externals/cowsay/README
40–46

Do you like this?

I think the README is somehow OK now. Any further improvement is welcome. Thanks :)