Page MenuHomePhorge
Differential D25255

Correct Phorge icon on Auth Provider page
ClosedPublic
Actions

Authored by aklapper on May 28 2023, 14:51.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Sep 21, 02:20
Unknown Object (File)
Fri, Sep 1, 08:47
Unknown Object (File)
Wed, Aug 30, 11:22
Unknown Object (File)
Mon, Aug 28, 20:30
Unknown Object (File)
Aug 22 2023, 05:41
Unknown Object (File)
Aug 9 2023, 00:50
Unknown Object (File)
Aug 8 2023, 09:52
Unknown Object (File)
Aug 8 2023, 08:18
View All 11 Files
Subscribers
avivey
Cigaryno
Matthew
speck
tobiaswiese
valerio.bozzolan

Details

Reviewers
valerio.bozzolan
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T15403: Fix "Amazon" icon on Phorge OAuth
Commits
rP8e6bb9b6903c: Correct Phorge icon on Auth Provider page
Summary

Add Phorge icon to auth/login PNG files.

Closes T15403

Test Plan

Go to /auth/config/new/ in browser and look at icons.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

aklapper created this revision.May 28 2023, 14:51
Owners added a reviewer: O1: Blessed Committers.May 28 2023, 14:51
Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptMay 28 2023, 14:51
aklapper requested review of this revision.May 28 2023, 14:51
Harbormaster completed remote builds in B473: Diff 829.May 28 2023, 14:51
aklapper added a comment.May 28 2023, 14:53

I have no idea how to create the hash value in resources/sprite/manifest/login.json. Probably there's some magic commands to do all of this. While I created the CSS etc manually.

valerio.bozzolan added inline comments.May 28 2023, 16:28
resources/sprite/manifest/login.json
74–78

Interestingly, probably this script is related:

./scripts/celerity/generate_sprites.php

I discovered that since I played with git blame on this file and found this commit that mentions that:

23d192cb3ddefa5f69d94640ac3ce96a466ccc0e

avivey subscribed.May 28 2023, 18:19

yeah, ./scripts/celerity/generate_sprites.php. It will also generate the sprite files (and after that, bin/celerity map)

aklapper updated this revision to Diff 880.Jun 3 2023, 11:18

Ran ./scripts/celerity/generate_sprites.php and ./bin/celerity map

Harbormaster completed remote builds in B506: Diff 880.Jun 3 2023, 11:18
aklapper mentioned this in Z5: Phorge (flame).Jun 14 2023, 21:00
valerio.bozzolan added a comment.Jun 15 2023, 06:38

I asked for help to make a vector of that logo and render it x2 without grainy

valerio.bozzolan added a comment.Jun 15 2023, 07:02

Hoping to be useful here some useful materials exactly at 28x28 and 56x56:

T15478: Graphical Kit

aklapper updated this revision to Diff 966.Jun 15 2023, 08:35

Thanks! Used PNG images from T15478; then ran ./bin/celerity sprites (which replaced ./scripts/celerity/generate_sprites.php)

Harbormaster completed remote builds in B561: Diff 966.Jun 15 2023, 08:35
valerio.bozzolan accepted this revision.Jun 15 2023, 09:35

Tested, thanks!

I approve this one also because the mere idea of receiving a fine from Amazon for calling it "Phorge" scares me on a molecular level ihih

lgtm

This revision is now accepted and ready to land.Jun 15 2023, 09:35
Closed by commit rP8e6bb9b6903c: Correct Phorge icon on Auth Provider page (authored by aklapper). · Explain WhyJun 15 2023, 10:02
This revision was automatically updated to reflect the committed changes.
aklapper added a commit: rP8e6bb9b6903c: Correct Phorge icon on Auth Provider page.

Revision Contents
Changeset List

Diff 968

View Options

resources/celerity/map.php

Loading...
View Options

resources/sprite/login_1x/Phorge.png

Loading...
View Options

resources/sprite/login_2x/Phorge.png

Loading...
View Options

resources/sprite/manifest/login.json

Loading...
View Options

webroot/rsrc/css/sprite-login.css

Loading...
View Options

webroot/rsrc/image/sprite-login-X2.png

Loading...
View Options

webroot/rsrc/image/sprite-login.png

Loading...