Paths

Table of Contentst

Differential D25255

Correct Phorge icon on Auth Provider page
ClosedPublic
Actions

Authored by aklapper on May 28 2023, 14:51.

Tags

None

Referenced Files

	F4046169: D25255.1746737391.diff
	Wed, May 7, 20:49

	F4046165: D25255.1746737358.diff
	Wed, May 7, 20:49

	F4045338: D25255.1746732790.diff
	Wed, May 7, 19:33

	F4021432: D25255.1746667788.diff
	Wed, May 7, 01:29

	F4014028: D25255.1746630822.diff
	Tue, May 6, 15:13

	F3973646: D25255.1746533333.diff
	Mon, May 5, 12:08

	F3969869: D25255.1746524075.diff
	Mon, May 5, 09:34

	F3945928: D25255.1746445822.diff
	Sun, May 4, 11:50

View All 48 Files

Subscribers

valerio.bozzolan

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15403: Fix "Amazon" icon on Phorge OAuth

Commits

rP8e6bb9b6903c: Correct Phorge icon on Auth Provider page

Summary

Add Phorge icon to auth/login PNG files.

Closes T15403

Test Plan

Go to /auth/config/new/ in browser and look at icons.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.May 28 2023, 14:51

Owners added a reviewer: O1: Blessed Committers.May 28 2023, 14:51

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptMay 28 2023, 14:51

aklapper requested review of this revision.May 28 2023, 14:51

Harbormaster completed remote builds in B473: Diff 829.May 28 2023, 14:51

I have no idea how to create the hash value in resources/sprite/manifest/login.json. Probably there's some magic commands to do all of this. While I created the CSS etc manually.

valerio.bozzolan added inline comments.May 28 2023, 16:28

resources/sprite/manifest/login.json
74–78	Interestingly, probably this script is related: ./scripts/celerity/generate_sprites.php I discovered that since I played with `git blame` on this file and found this commit that mentions that: 23d192cb3ddefa5f69d94640ac3ce96a466ccc0e

yeah, ./scripts/celerity/generate_sprites.php. It will also generate the sprite files (and after that, bin/celerity map)

Ran ./scripts/celerity/generate_sprites.php and ./bin/celerity map

Harbormaster completed remote builds in B506: Diff 880.Jun 3 2023, 11:18

aklapper mentioned this in Z5: Phorge (flame).Jun 14 2023, 21:00

I asked for help to make a vector of that logo and render it x2 without grainy

Hoping to be useful here some useful materials exactly at 28x28 and 56x56:

T15478: Graphical Kit

Thanks! Used PNG images from T15478; then ran ./bin/celerity sprites (which replaced ./scripts/celerity/generate_sprites.php)

Harbormaster completed remote builds in B561: Diff 966.Jun 15 2023, 08:35

Tested, thanks!

I approve this one also because the mere idea of receiving a fine from Amazon for calling it "Phorge" scares me on a molecular level ihih

lgtm

This revision is now accepted and ready to land.Jun 15 2023, 09:35

Closed by commit rP8e6bb9b6903c: Correct Phorge icon on Auth Provider page. · Explain WhyJun 15 2023, 10:02

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rP8e6bb9b6903c: Correct Phorge icon on Auth Provider page.

Revision Contents
Changeset List

Path

Size

Packages

resources/

celerity/

O1: Blessed Committers

sprite/

login_1x/

O1: Blessed Committers

login_2x/

O1: Blessed Committers

manifest/

O1: Blessed Committers

webroot/

rsrc/

css/

sprite-login.css

O1: Blessed Committers

image/

sprite-login-X2.png

O1: Blessed Committers

sprite-login.png

O1: Blessed Committers

Diff 968

resources/celerity/map.php

Loading...

resources/sprite/login_1x/Phorge.png

Loading...

resources/sprite/login_2x/Phorge.png

Loading...

resources/sprite/manifest/login.json

Loading...

webroot/rsrc/css/sprite-login.css

Loading...

webroot/rsrc/image/sprite-login-X2.png

Loading...

webroot/rsrc/image/sprite-login.png

Loading...