Page MenuHomePhorge

Correct Phorge icon on Auth Provider page
ClosedPublic

Authored by aklapper on May 28 2023, 14:51.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Sep 21, 02:20
Unknown Object (File)
Fri, Sep 1, 08:47
Unknown Object (File)
Wed, Aug 30, 11:22
Unknown Object (File)
Mon, Aug 28, 20:30
Unknown Object (File)
Aug 22 2023, 05:41
Unknown Object (File)
Aug 9 2023, 00:50
Unknown Object (File)
Aug 8 2023, 09:52
Unknown Object (File)
Aug 8 2023, 08:18

Details

Summary

Add Phorge icon to auth/login PNG files.

Closes T15403

Test Plan

Go to /auth/config/new/ in browser and look at icons.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I have no idea how to create the hash value in resources/sprite/manifest/login.json. Probably there's some magic commands to do all of this. While I created the CSS etc manually.

resources/sprite/manifest/login.json
74–78

Interestingly, probably this script is related:

./scripts/celerity/generate_sprites.php

I discovered that since I played with git blame on this file and found this commit that mentions that:

23d192cb3ddefa5f69d94640ac3ce96a466ccc0e

yeah, ./scripts/celerity/generate_sprites.php. It will also generate the sprite files (and after that, bin/celerity map)

Ran ./scripts/celerity/generate_sprites.php and ./bin/celerity map

I asked for help to make a vector of that logo and render it x2 without grainy

Hoping to be useful here some useful materials exactly at 28x28 and 56x56:

T15478: Graphical Kit

Thanks! Used PNG images from T15478; then ran ./bin/celerity sprites (which replaced ./scripts/celerity/generate_sprites.php)

Tested, thanks!

I approve this one also because the mere idea of receiving a fine from Amazon for calling it "Phorge" scares me on a molecular level ihih

lgtm

This revision is now accepted and ready to land.Jun 15 2023, 09:35
This revision was automatically updated to reflect the committed changes.