Steps to reproduce:
- Visit a very old Task
- click on "View Herald Transcript"
Example:
https://we.phorge.it/herald/transcript/268/
What should happen instead:
Not a crash visiting that page.
Reported from Wikimedia by aklapper, Nov 2 2021:
Description
Description
Revisions and Commits
Revisions and Commits
Event Timeline
Comment Actions
I could reproduce this locally:
- As an admin, go to http://phorge.localhost/herald/create/
- Select "Maniphest Tasks"
- On http://phorge.localhost/herald/create/?adapter=HeraldManiphestTaskAdapter , select "Global Rule"
- Under "Conditions", select any of and set the three conditions Description | contains | Internet Archive, Description | contains | archive.org, Description | contains | Wayback Machine.
- Under "Action", select Add projects | someProject
- Select "Save Rule"
- Trigger the rule by creating a new task.
- Wait, wait, and wait, then look at the Herald Transcript linked from the task.
Callstack in src/applications/herald/controller/HeraldTranscriptController.php:
- public function handleRequest(AphrontRequest $request) calls $navigation = $this->newSideNavView($xscript, $view_key);
- private function newSideNavView(HeraldTranscript $xscript, $view_key) calls $xaction_phids = $this->getTranscriptTransactionPHIDs($xscript);
- private function getTranscriptTransactionPHIDs(HeraldTranscript $xscript) calls $xaction_phids = $object_xscript->getAppliedTransactionPHIDs();
- getAppliedTransactionPHIDs() is just a simple getter method.
Comment Actions
@valerio.bozzolan Thanks a lot for your help, debugging, deeper investigation! Resolving.